Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15.0
    • Component/s: build
    • Labels:
      None

      Description

      HADOOP-1436 changed the Tool and Toolbase APIs, but the HDFS antlib was not updated.

      1. 1806-3.patch
        2 kB
        Chris Douglas

        Activity

        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Chris!

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Chris!
        Hide
        Enis Soztutar added a comment -

        Compile dependency compile-ant-tasks, package dependency ant-tasks seems reasonable. +1 for me.

        Show
        Enis Soztutar added a comment - Compile dependency compile-ant-tasks, package dependency ant-tasks seems reasonable. +1 for me.
        Show
        Hadoop QA added a comment - +1 http://issues.apache.org/jira/secure/attachment/12364804/1806-3.patch applied and successfully tested against trunk revision r571256. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/657/testReport/ Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/657/console
        Hide
        Hadoop QA added a comment -

        -1, build or testing failed

        2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12364804/1806-3.patch against trunk revision r570983.

        Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/651/testReport/
        Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/651/console

        Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.

        Show
        Hadoop QA added a comment - -1, build or testing failed 2 attempts failed to build and test the latest attachment http://issues.apache.org/jira/secure/attachment/12364804/1806-3.patch against trunk revision r570983. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/651/testReport/ Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/651/console Please note that this message is automatically generated and may represent a problem with the automation system and not the patch.
        Hide
        Chris Douglas added a comment -

        OK. This should do the trick.

        Show
        Chris Douglas added a comment - OK. This should do the trick.
        Hide
        Chris Douglas added a comment -

        I've been told that this patch doesn't restore the original behavior; I'm pulling it back for now.

        Show
        Chris Douglas added a comment - I've been told that this patch doesn't restore the original behavior; I'm pulling it back for now.
        Show
        Hadoop QA added a comment - +1 http://issues.apache.org/jira/secure/attachment/12364795/1806-2.patch applied and successfully tested against trunk revision r570937. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/649/testReport/ Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/649/console
        Hide
        Chris Douglas added a comment -

        nod Soright

        Show
        Chris Douglas added a comment - nod Soright
        Hide
        Doug Cutting added a comment -

        The "compile" target should compile all the code it can, no? It's the default target. It seems strange to me to use the "package" target in order to get compilation errors. If folks only want to compile a subset of things, then they can use the "compile-core", etc. targets.

        Show
        Doug Cutting added a comment - The "compile" target should compile all the code it can, no? It's the default target. It seems strange to me to use the "package" target in order to get compilation errors. If folks only want to compile a subset of things, then they can use the "compile-core", etc. targets.
        Hide
        Chris Douglas added a comment -

        Hmm... it's inexpensive to build, but it's rarely necessary, particularly for developers. The current patch is sufficient to catch compile errors before commit; until the antlib has unit tests, the only time someone would actually build it is if they have a particular use for it. Even then they'd only rebuild it to accommodate incompatible API changes. Either way, it accounts for a second or two during builds so whatever.

        Show
        Chris Douglas added a comment - Hmm... it's inexpensive to build, but it's rarely necessary, particularly for developers. The current patch is sufficient to catch compile errors before commit; until the antlib has unit tests, the only time someone would actually build it is if they have a particular use for it. Even then they'd only rebuild it to accommodate incompatible API changes. Either way, it accounts for a second or two during builds so whatever.
        Hide
        Doug Cutting added a comment -

        Shouldn't we also make the "compile" task depend on "compile-ant-tasks"?

        Show
        Doug Cutting added a comment - Shouldn't we also make the "compile" task depend on "compile-ant-tasks"?
        Hide
        Chris Douglas added a comment -

        That's a good idea; added "ant-tasks" dependency on "package" target.

        Show
        Chris Douglas added a comment - That's a good idea; added "ant-tasks" dependency on "package" target.
        Hide
        Enis Soztutar added a comment -

        Maybe we should include the target ant-tasks in target package?

        Show
        Enis Soztutar added a comment - Maybe we should include the target ant-tasks in target package?
        Show
        Hadoop QA added a comment - +1 http://issues.apache.org/jira/secure/attachment/12364742/1806.patch applied and successfully tested against trunk revision r570633. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/642/testReport/ Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/642/console
        Hide
        Chris Douglas added a comment -

        This fixes the compile error, but not the lack of unit tests (HADOOP-1807)

        Show
        Chris Douglas added a comment - This fixes the compile error, but not the lack of unit tests ( HADOOP-1807 )

          People

          • Assignee:
            Chris Douglas
            Reporter:
            Chris Douglas
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development