Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-18029

Update CompressionCodecFactory to handle uppercase file extensions

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.4.0
    • common, io, test
    • Tested locally on macOS 11.6.1, IntelliJ IDEA 2021.2.3, running maven commands through terminal. Forked from trunk branch on November 29th, 2021.

    Description

      I've updated the CompressionCodecFactory to be able to handle filenames with capitalized compression extensions. Two of the three maps internal to the class which are used to store codecs have existing lowercase casts, but it is absent from the call inside getCodec() used for comparing path names.

      I updated the corresponding unit test in TestCodecFactory to include intended use cases, and confirmed the test passes with the change. I also updated the error message in the case of a null from an NPE to a rich error message. I've resolved all checkstyle violations within the changed files.

      Attachments

        Issue Links

          Activity

            People

              desisson Desmond Sisson
              desisson Desmond Sisson
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h
                  2h