XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: In Progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.3.1
    • Fix Version/s: None
    • Component/s: fs/s3

      Description

      I know I'm closing ~all S3Guard issues as wontfix, but this is pressing so I'm going to do it anyway

      S3guard import of directory tree containing many, many files will OOM. Looking at the code this is going to be because

      • import tool builds a map of all dirs imported, which as the comments note "superfluous for DDB". - cut
      • DDB AncestorState tracks files as well as dirs, purely as a safety check to make sure current op doesn't somehow write a file entry above a dir entry in the same operation

      We've been running S3Guard for a long time, and condition #2 has never arisen.

      Propose: don't store filenames there, so memory consumption goes from O(files + dirs) to O(dirs)

      Code straightforward, can't think of any tests

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                stevel@apache.org Steve Loughran
                Reporter:
                stevel@apache.org Steve Loughran
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m