[HADOOP-17126] implement non-guava Precondition checkNotNull

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.2, 3.2.4
• Labels: pull-request-available
• Assignee: Ahmed Hussein
• Reporter: Ahmed Hussein
• Created: 13/Jul/20 21:16
• Updated: 12/Jul/22 10:55
• Resolved: 20/Sep/21 15:01

Description

As part In order to replace Guava Preconditions, we need to implement our own versions of the API.
This Jira is to create checkNotNull in a new package dubbed unguava.

 The plan is as follows

• create a new package org.apache.hadoop.util.unguava;
• create class Validate
• implement  package org.apache.hadoop.util.unguava.Validate; with the following interface
  • checkNotNull(final T obj)
  • checkNotNull(final T reference, final Object errorMessage)
  • checkNotNull(final T obj, final String message, final Object... values)
  • checkNotNull(final T obj,final Supplier<String> msgSupplier)
• guava.preconditions used String.lenientformat which suppressed exceptions caused by string formatting of the exception message . So, in order to avoid changing the behavior, the implementation catches Exceptions triggered by building the message (IllegalFormat, InsufficientArg, NullPointer..etc)
• After merging the new class, we can replace guava.Preconditions.checkNotNull by {{unguava.Validate.checkNotNull}}
• We need the change to go into trunk, 3.1, 3.2, and 3.3

 

Similar Jiras will be created to implement checkState, checkArgument, checkIndex

Issue Links

• is part of: HADOOP-17108 Create Classes to wrap Guava code replacement
• is required by: HADOOP-17110 Replace Guava Preconditions to avoid Guava dependency
• is required by: HADOOP-17123 remove guava Preconditions from Hadoop-common-project modules
• links to: GitHub Pull Request #3050