[HADOOP-16925] MetricsConfig incorrectly loads the configuration whose value is String list in the properties file

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.3
• Fix Version/s: 3.2.2, 3.3.1
• Component/s: metrics
• Assignee: Jiayi Liu
• Reporter: Jiayi Liu
• Created: 16/Mar/20 07:05
• Updated: 24/Aug/20 13:08
• Resolved: 24/Aug/20 13:07

Description

HADOOP-15549 modified loadFirst function in MetricsConfig, and forget to set the DelimiterHandler, which caused that when loading the properties file, if the configured value is a String List, the value will not be loaded as a String Array, but just a String. For example, if we set

*.sink.ganglia.dmax=jvm.metrics.threadsBlocked=70,jvm.metrics.memHeapUsedM=40

in hadoop-metrics2.properties. If we use conf.getStringArray("*.sink.ganglia.dmax") to get the value list, we will get an array with single element, the content of which is "jvm.metrics.threadsBlocked=70,jvm.metrics.memHeapUsedM=40", which wil cause an error during loadGangliaConf. loadGangliaConf will assume that the value of jvm.metrics.threadsBlocked is "70, jvm.metrics.memHeapUsedM", which will cause an error "java.lang.NumberFormatException: For input string: "70,jvm.metrics.memHeapUsedM".

Issue Links

• is caused by: HADOOP-15549 Upgrade to commons-configuration 2.1 regresses task CPU consumption
• links to: GitHub Pull Request #1896