[HADOOP-16581] ValueQueue does not trigger an async refill when number of values falls below watermark

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.4, 3.2.0
• Fix Version/s: 2.10.0, 3.3.0, 3.1.4, 3.2.2
• Component/s: common, kms
• Assignee: Yuval Degani
• Reporter: Yuval Degani
• Created: 17/Sep/19 20:27
• Updated: 23/Sep/19 22:00
• Resolved: 20/Sep/19 17:19

Description

The ValueQueue facility was designed to cache EDEKs for KMS KeyProviders so that EDEKs could be served quickly, while the cache is replenished in a background thread.

The existing code for triggering an asynchronous refill is only triggered when a key queue becomes empty, rather than when it falls below the configured watermark.

This is a relatively minor fix in the main code, however, most of the tests require some changes as they verify the previous unintended behavior.

Issue Links

• links to: GitHub Pull Request #1463