[HADOOP-16509] [hadoop-mapreduce-project] Fix order of actual and expected expression in assert statements

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Adam Antal
• Reporter: Adam Antal
• Created: 18/Apr/19 13:58
• Updated: 12/Aug/19 16:35
• Resolved: 12/Aug/19 11:57

Description

Fix order of actual and expected expression in assert statements which gives misleading message when test case fails. Attached file has some of the places where it is placed wrongly.

[ERROR] testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)  Time elapsed: 3.385 s  <<< FAILURE!
java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but was:<0>

For long term, AssertJ can be used for new test cases which avoids such mistakes.

This is a follow-up Jira on the fix for the MR project.

Issue Links

• relates to: HADOOP-12693 Many misusages of assertEquals(expected, actual)