[HADOOP-16503] [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 3.2.0
• Target Version/s: 3.3.0
• Assignee: Kinga Marton
• Reporter: Adam Antal
• Created: 10/Aug/19 13:56
• Updated: 01/Oct/19 15:45
• Resolved: 01/Oct/19 13:11

Description

Many of the tests in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue fails with the following error message running on JDK11:

[ERROR] testSingleQueueWithOneUser(org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue)  Time elapsed: 0.204 s  <<< ERROR!
org.mockito.exceptions.misusing.WrongTypeOfReturnValue:

YarnConfiguration cannot be returned by getRMNodes()
getRMNodes() should return ConcurrentMap
***
If you're unsure why you're getting above error read on.
Due to the nature of the syntax above problem might occur because:
1. This exception *might* occur in wrongly written multi-threaded tests.
   Please refer to Mockito FAQ on limitations of concurrency testing.
2. A spy is stubbed using when(spy.foo()).then() syntax. It is safer to stub spies -
   - with doReturn|Throw() family of methods. More in javadocs for Mockito.spy() method.

	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue.setUpInternal(TestLeafQueue.java:221)
	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue.setUp(TestLeafQueue.java:144)
       ...

This is due to the actual execution of the call, while we need to record only the invocation of it. According to the javadocs and other folks.

Issue Links

• is a child of: HADOOP-16264 [JDK11] Track failing Hadoop unit tests
• relates to: YARN-9784 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue is flaky