[HADOOP-16431] Remove useless log in IOUtils.java and ExceptionDiags.java

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Lisheng Sun
• Reporter: Lisheng Sun
• Created: 15/Jul/19 07:25
• Updated: 02/Oct/19 17:13
• Resolved: 24/Jul/19 01:06

Description

When there is no String Constructor for the exception, we Log a Warn Message, and rethrow the exception. We can change the Log level to TRACE/DEBUG.

private static <T extends IOException> T wrapWithMessage(
  T exception, String msg) {
  Class<? extends Throwable> clazz = exception.getClass();
  try {
    Constructor<? extends Throwable> ctor =
      clazz.getConstructor(String.class);
    Throwable t = ctor.newInstance(msg);
    return (T) (t.initCause(exception));
  } catch (Throwable e) {
    LOG.trace("Unable to wrap exception of type " +
             clazz + ": it has no (String) constructor", e);
    return exception;
  }
}

Issue Links

• is related to: HADOOP-16453 Update how exceptions are handled in NetUtils
• relates to: HADOOP-16243 Change Log Level to trace in NetUtils.java
• links to: GitHub Pull Request #1091