[HADOOP-16208] Do Not Log InterruptedException in Client

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0, 3.2.1, 3.1.3, 2.10.2
• Component/s: common
• Flags: Patch
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 26/Mar/19 21:06
• Updated: 22/Dec/20 21:59
• Resolved: 04/Apr/19 15:18

Description

       } catch (InterruptedException e) {
        Thread.currentThread().interrupt();
        LOG.warn("interrupted waiting to send rpc request to server", e);
        throw new IOException(e);
      }

https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java#L1450

I'm working on a project that uses an ExecutorService to launch a bunch of threads. Each thread spins up an HDFS client connection. At any point in time, the program can terminate and call ExecutorService#shutdownNow() to forcibly close vis-à-vis Thread#interrupt(). At that point, I get a cascade of logging from the above code and there's no easy to way to turn it off.

"Log and throw" is generally frowned upon, just throw the Exception and move on.

https://community.oracle.com/docs/DOC-983543#logAndThrow

Issue Links

• relates to: HDFS-13150 [Edit Tail Fast Path] Allow SbNN to tail in-progress edits from JN via RPC
• relates to: HDFS-13888 RequestHedgingProxyProvider shows InterruptedException
• relates to: HDFS-14395 Remove WARN Logging From Interrupts in DataStreamer