[HADOOP-16126] ipc.Client.stop() may sleep too long to wait for all connections

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.10.0, 3.3.0, 2.8.6, 2.9.3, 3.1.4, 3.2.2
• Component/s: ipc
• Assignee: Tsz-wo Sze
• Reporter: Tsz-wo Sze
• Created: 19/Feb/19 22:34
• Updated: 02/Oct/19 23:56
• Resolved: 25/Feb/19 21:17

Description

//Client.java
  public void stop() {
    ...
    // wait until all connections are closed
    while (!connections.isEmpty()) {
      try {
        Thread.sleep(100);
      } catch (InterruptedException e) {
      }
    }
    ...
  }

In the code above, the sleep time is 100ms. We found that simply changing the sleep time to 10ms could improve a Hive job running time by 10x.

Issue Links

• is required by: HADOOP-16127 In ipc.Client, put a new connection could happen after stop