Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-16067

Incorrect Format Debug Statement KMSACLs

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.3.0
    • Component/s: kms
    • Labels:

      Description

            if (LOG.isDebugEnabled()) {
              LOG.debug("Checking user [{}] for: {}: {}" + ugi.getShortUserName(),
                  opType.toString(), acl.getAclString());
            }
      

      The logging message here is incorrect because the first variable is being concatenated to the string instead of being passed as an argument.

      -- Notice the user name 'hdfs' at the end and the spare curly brackets
      2019-01-23 13:27:45,244 DEBUG org.apache.hadoop.crypto.key.kms.server.KMSACLs: Checking user [GENERATE_EEK] for: hdfs supergroup: {}hdfs
      

      https://github.com/apache/hadoop/blob/a55d6bba71c81c1c4e9d8cd11f55c78f10a548b0/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSACLs.java#L313-L316

        Attachments

        1. HADOOP-16067.001.patch
          0.9 kB
          Charan Hebri

          Activity

            People

            • Assignee:
              charanh Charan Hebri
              Reporter:
              belugabehr David Mollitor
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: