Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to IssueMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments


    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.1.0
    • 3.3.0
    • fs/s3
    • None


      S3Guard was initially done on the premise that a new MetadataStore would be the source of truth, and that it wouldn't provide guarantees if updates were done without using S3Guard.

      I've been seeing increased demand for better support for scenarios where operations are done on the data that can't reasonably be done with S3Guard involved. For example:

      • A file is deleted using S3Guard, and replaced by some other tool. S3Guard can't tell the difference between the new file and delete / list inconsistency and continues to treat the file as deleted.
      • An S3Guard-ed file is overwritten by a longer file by some other tool. When reading the file, only the length of the original file is read.

      We could possibly have smarter behavior here by querying both S3 and the MetadataStore (even in cases where we may currently only query the MetadataStore in getFileStatus) and use whichever one has the higher modified time.

      This kills the performance boost we currently get in some workloads with the short-circuited getFileStatus, but we could keep it with authoritative mode which should give a larger performance boost. At least we'd get more correctness without authoritative mode and a clear declaration of when we can make the assumptions required to short-circuit the process. If we can't consider S3Guard the source of truth, we need to defer to S3 more.

      We'd need to be extra sure of any locality / time zone issues if we start relying on mod_time more directly, but currently we're tracking the modification time as returned by S3 anyway.


        1. HADOOP-15999.001.patch
          12 kB
          Gabor Bota
        2. HADOOP-15999.002.patch
          19 kB
          Gabor Bota
        3. HADOOP-15999.003.patch
          23 kB
          Gabor Bota
        4. HADOOP-15999.004.patch
          23 kB
          Gabor Bota
        5. HADOOP-15999.005.patch
          25 kB
          Gabor Bota
        6. HADOOP-15999.006.patch
          25 kB
          Gabor Bota
        7. HADOOP-15999.008.patch
          27 kB
          Gabor Bota
        8. HADOOP-15999.009.patch
          27 kB
          Gabor Bota
        9. HADOOP-15999-007.patch
          26 kB
          Steve Loughran
        10. out-of-band-operations.patch
          4 kB
          Sean Mackrory

        Issue Links


          This comment will be Viewable by All Users Viewable by All Users


            gabor.bota Gabor Bota Assign to me
            mackrorysd Sean Mackrory
            0 Vote for this issue
            6 Start watching this issue




                Issue deployment