[HADOOP-15922] DelegationTokenAuthenticationFilter get wrong doAsUser since it does not decode URL

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0, 3.2.1, 3.1.3
• Component/s: common, kms
• Target Version/s: 3.3.0, 3.2.1, 3.1.3
• Hadoop Flags: Incompatible change, Reviewed
• Release Note: - Fix DelegationTokenAuthentication filter for incorrectly double encode doAs user parameter.
• Assignee: Xiaoqiao He
• Reporter: Xiaoqiao He
• Created: 12/Nov/18 13:08
• Updated: 08/Sep/19 23:59
• Resolved: 23/Jan/19 00:37

Description

DelegationTokenAuthenticationFilter get wrong doAsUser when proxy user from client is complete kerberos name (e.g., user/[e-mail], actually it is acceptable), because DelegationTokenAuthenticationFilter does not decode DOAS parameter in URL which is encoded by URLEncoder at client.
e.g. KMS as example:
a. KMSClientProvider creates connection to KMS Server using DelegationTokenAuthenticatedURL#openConnection.
b. If KMSClientProvider is a doAsUser, KMSClientProvider will put doas with url encoded user as one parameter of http request.

    // proxyuser
    if (doAs != null) {
      extraParams.put(DO_AS, URLEncoder.encode(doAs, "UTF-8"));
    }

c. when KMS server receives the request, it does not decode the proxy user.

As result, KMS Server will get the wrong proxy user if this proxy user is complete Kerberos Name or it includes some special character. Some other authentication and authorization exception will throws next to it.

Issue Links

• depends upon: HADOOP-15996 Plugin interface to support more complex usernames in Hadoop