Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-15831

Include modificationTime in the toString method of CopyListingFileStatus

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None

      Description

      I was looking at a DistCp error observed in hbase backup test:

      2018-10-08 18:12:03,067 WARN  [Thread-933] mapred.LocalJobRunner$Job(590): job_local1175594345_0004
      java.io.IOException: Inconsistent sequence file: current chunk file org.apache.hadoop.tools.CopyListingFileStatus@7ac56817{hdfs://localhost:41712/user/hbase/test-data/       c0f6352c-cf39-bbd1-7d10-57a9c01e7ce9/data/default/test-1539022262249/be1bf5445faddb63e45726410a07917a/f/f565f49046b04eecbf8d129eac7a7b88_SeqId_205_ length = 5100 aclEntries  = null, xAttrs = null} doesnt match prior entry org.apache.hadoop.tools.CopyListingFileStatus@7aa4deb2{hdfs://localhost:41712/user/hbase/test-data/c0f6352c-cf39-bbd1-7d10-   57a9c01e7ce9/data/default/test-1539022262249/be1bf5445faddb63e45726410a07917a/f/41b6cb64bae64cbcac47d1fd9aae59f4_SeqId_205_ length = 5142 aclEntries = null, xAttrs = null}
        at org.apache.hadoop.tools.mapred.CopyCommitter.concatFileChunks(CopyCommitter.java:276)
        at org.apache.hadoop.tools.mapred.CopyCommitter.commitJob(CopyCommitter.java:100)
        at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:567)
      2018-10-08 18:12:03,150 INFO  [Time-limited test] mapreduce.MapReduceBackupCopyJob$BackupDistCp(226): Progress: 100.0% subTask: 1.0 mapProgress: 1.0
      

      I noticed that modificationTime was not included in the toString of CopyListingFileStatus.

      I propose including modificationTime so that it is easier to tell when the respective files last change.

        Attachments

        1. HADOOP-15831.03.patch
          2 kB
          Ted Yu
        2. HADOOP-15831.02.patch
          2 kB
          Ted Yu
        3. HADOOP-15831.01.patch
          0.8 kB
          Ted Yu

          Issue Links

            Activity

              People

              • Assignee:
                yuzhihong@gmail.com Ted Yu
                Reporter:
                yuzhihong@gmail.com Ted Yu
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: