Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-15717

TGT renewal thread does not log IOException

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I came across a case where tgt.getEndTime() was returned null and it resulted in an NPE, this observation was popped out of a test suite execution on a cluster. The reason for logging the IOException is that it helps to troubleshoot what caused the exception, as it can come from two different calls from the try-catch.

      I can see that Gabor Bota handled this with HADOOP-15593, but apart from logging the fact that the ticket's endDate was null, we have not logged the exception at all.
      With the current code, the exception is swallowed and the thread terminates in case the ticket's endDate is null.
      As this can happen with OpenJDK for example, it is required to print the exception (stack trace, message) to the log.
      The code should be updated here: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java#L918

        Attachments

        1. HADOOP-15717.001.patch
          0.8 kB
          Szilard Nemeth
        2. HADOOP-15717.002.patch
          2 kB
          Szilard Nemeth

          Activity

            People

            • Assignee:
              snemeth Szilard Nemeth
              Reporter:
              snemeth Szilard Nemeth
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: