[HADOOP-1555] Fix a few more FindBugs issues

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 0.13.0
• Component/s: fs
• Assignee: Unassigned
• Reporter: Albert Strasheim
• Created: 01/Jul/07 04:17
• Updated: 16/Jul/11 18:58
• Resolved: 16/Jul/11 18:58

Description

I'm attaching a patch to fix a few more FindBugs issues. Most of these fixes are relatively minor. I also went ahead and fixed some issues in the tests.

This patch includes some fixes for "inconsistent synchronization" reported by FindBugs. However, FindBugs still reports some cases of inconsistent synchronization that I'm not quite sure how to fix.

Also, in ChecksumFileSystem.copyToLocalFile, there is an instanceof ChecksumFileSystem check that FindBugs says will always return true. I'm not quite sure what was intended here.