[HADOOP-15546] ABFS: tune imports & javadocs; stabilise tests

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: HADOOP-15407
• Fix Version/s: 3.2.0
• Component/s: fs/azure
• Target Version/s: HADOOP-15407
• Assignee: Thomas Marqardt
• Reporter: Steve Loughran
• Created: 15/Jun/18 17:33
• Updated: 08/Jun/20 12:28
• Resolved: 08/Aug/18 20:08

Description

Followup on HADOOP-15540 with some initial review tuning

Tuning

• ordering of imports
• rely on azure-auth-keys.xml to store credentials (change imports, docs,.gitignore)
• log4j -> info
• add a "." to the first sentence of all the javadocs I noticed.
• remove @Public annotations except for some constants (which includes some commitment to maintain them).
• move the AbstractFS declarations out of the src/test/resources XML file into core-default.xml for all to use
• other IDE-suggested tweaks

Testing

Review the tests, move to ContractTestUtil assertions, make more consistent to contract test setup, and general work to make the tests work well over slower links, document, etc.

Issue Links

• contains: HADOOP-15579 ABFS: TestAbfsConfigurationFieldsValidation breaks if FS is configured in core-site
• contains: HADOOP-15545 ABFS initialize() throws string out of bounds exception of the URI isn't fully qualified