Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-15056

Fix TestUnbuffer#testUnbufferException failure

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 3.1.0, 2.10.0, 2.9.1, 3.0.1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Flags:
      Patch

      Description

      Hello! I am a new contributor and actually contributing to open source for the very first time.

      I pulled down Hadoop today and when running the tests I encountered a failure with the TestUnbuffer#testUnbufferException test.

      The unbuffer code has recently gone through some changes and I believe this test case may have been overlooked. Using today's git commit (659e85e304d070f9908a96cf6a0e1cbafde6a434), and upon running the test case, there is an expect mock for an exception UnsupportedOperationException that is no longer being thrown.

      It would appear that a test like this would be valuable so my initial proposed patch did not remove it. Instead, I removed the conditions that were guarding the cast from being able to fire – as was the previous behavior. Now when we encounter an object that doesn't have the UNBUFFERED StreamCapability, it will throw an error as it did prior to the recent changes.

      Please review and let me know what you think!

        Attachments

        1. HADOOP-15056.001.patch
          2 kB
          Jack Bearden
        2. HADOOP-15056.002.patch
          2 kB
          John Zhuge
        3. HADOOP-15056.003.patch
          4 kB
          Jack Bearden
        4. HADOOP-15056.004.patch
          4 kB
          Jack Bearden
        5. HADOOP-15056.005.patch
          3 kB
          Jack Bearden
        6. HADOOP-15056.006.patch
          3 kB
          Jack Bearden
        7. HADOOP-15056.007.patch
          3 kB
          Jack Bearden

          Issue Links

            Activity

              People

              • Assignee:
                jackbearden Jack Bearden
                Reporter:
                jackbearden Jack Bearden
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: