[HADOOP-14954] MetricsSystemImpl#init should increment refCount when already initialized

• Type: Bug
• Status: Reopened
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.7.0
• Component/s: metrics
• Target Version/s: 3.5.0
• Assignee: John Zhuge
• Reporter: John Zhuge
• Created: 16/Oct/17 20:27
• Updated: 04/Jan/24 11:28

Description

++refCount here in init should be symmetric to --refCount in shutdown.

  public synchronized MetricsSystem init(String prefix) {
    if (monitoring && !DefaultMetricsSystem.inMiniClusterMode()) {
      LOG.warn(this.prefix +" metrics system already initialized!");
      return this;
    }
    this.prefix = checkNotNull(prefix, "prefix");
    ++refCount;

Move ++refCount to the beginning of this method.

Issue Links

• breaks: HADOOP-14974 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation fails in trunk
• duplicates: HADOOP-14974 org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation fails in trunk