[HADOOP-14851] LambdaTestUtils.eventually() doesn't spin on Assertion failures

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.1
• Fix Version/s: 3.0.0-beta1
• Component/s: test
• Target Version/s: 2.9.0, 3.0.0-beta1
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 08/Sep/17 11:19
• Updated: 29/Sep/17 10:35
• Resolved: 09/Sep/17 03:29

Description

This is funny. The LsmbdaTestUtils.eventually() method, meant to spin until a closure stops raising exceptions, doesn't catch Error and subclasses, so doesn't fail on an Assert.assert() failure, which raises an AssertionError. My bad

Example:

    eventually(TIMEOUT,
        () -> {
          while (counter.incrementAndGet()  < 5) {
            assert false : "oops";
          }
        },
        retryLogic);

Fix: catch Throwable, rethrow. Needs to add VirtualMachineError & subclasses to the set of errors not to spin on (OOM, stack overflow, ...)

Issue Links

• is depended upon by: HADOOP-13271 Intermittent failure of TestS3AContractRootDir.testListEmptyRootDirectory
• is related to: HADOOP-14220 Enhance S3GuardTool with bucket-info and set-capacity commands, tests