Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14781

Clarify that HADOOP_CONF_DIR shouldn't actually be set in hadoop-env.sh

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-beta1
    • Fix Version/s: 3.0.0-beta1
    • Component/s: documentation, scripts
    • Labels:
      None

      Description

      We should be more explicit in the documentation in hadoop-env.sh that HADOOP_CONF_DIR:

      • shouldn't actually be set in this file
      • is really intended for something "outside" of this file to set
      • will break --config if the pointed to configs don't also set HADOOP_CONF_DIR appropriately
      1. HADOOP-14781.00.patch
        1 kB
        Allen Wittenauer

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 18m 59s trunk passed
        -1 mvnsite 0m 18s hadoop-common in trunk failed.
              Patch Compile Tests
        -1 mvnsite 0m 10s hadoop-common in the patch failed.
        +1 shellcheck 0m 0s There were no new shellcheck issues.
        +1 shelldocs 0m 6s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
              Other Tests
        +1 unit 2m 20s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        23m 0s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14781
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884295/HADOOP-14781.00.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux 26f27b84e3f2 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1f6dc4e
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13121/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt
        shellcheck v0.4.6
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13121/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13121/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13121/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 18m 59s trunk passed -1 mvnsite 0m 18s hadoop-common in trunk failed.       Patch Compile Tests -1 mvnsite 0m 10s hadoop-common in the patch failed. +1 shellcheck 0m 0s There were no new shellcheck issues. +1 shelldocs 0m 6s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 unit 2m 20s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 23m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14781 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884295/HADOOP-14781.00.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 26f27b84e3f2 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1f6dc4e mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13121/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt shellcheck v0.4.6 mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/13121/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13121/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13121/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        +1 could you retrigger the build? precommit failures look unrelated.

        Show
        andrew.wang Andrew Wang added a comment - +1 could you retrigger the build? precommit failures look unrelated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 55s trunk passed
        +1 mvnsite 1m 25s trunk passed
              Patch Compile Tests
        +1 mvnsite 1m 18s the patch passed
        +1 shellcheck 0m 0s There were no new shellcheck issues.
        +1 shelldocs 0m 9s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
              Other Tests
        +1 unit 2m 9s hadoop-common in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        19m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HADOOP-14781
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884295/HADOOP-14781.00.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs
        uname Linux 87ab8c726738 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 71bbb86
        shellcheck v0.4.6
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13142/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13142/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 55s trunk passed +1 mvnsite 1m 25s trunk passed       Patch Compile Tests +1 mvnsite 1m 18s the patch passed +1 shellcheck 0m 0s There were no new shellcheck issues. +1 shelldocs 0m 9s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 unit 2m 9s hadoop-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 19m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HADOOP-14781 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884295/HADOOP-14781.00.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs uname Linux 87ab8c726738 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 71bbb86 shellcheck v0.4.6 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13142/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13142/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        I'm going to assume that the previous +1 counts and commit this.

        Thanks!

        Show
        aw Allen Wittenauer added a comment - I'm going to assume that the previous +1 counts and commit this. Thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12290 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12290/)
        HADOOP-14781. Clarify that HADOOP_CONF_DIR shouldn't actually be set in (aw: rev 27359b713982b480d456067e4a71bf0c4ffb1df2)

        • (edit) hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12290 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12290/ ) HADOOP-14781 . Clarify that HADOOP_CONF_DIR shouldn't actually be set in (aw: rev 27359b713982b480d456067e4a71bf0c4ffb1df2) (edit) hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks Allen! +1 again after the fact for ultimate clarity.

        Show
        andrew.wang Andrew Wang added a comment - Thanks Allen! +1 again after the fact for ultimate clarity.

          People

          • Assignee:
            aw Allen Wittenauer
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development