Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14760

Add missing override to LoadBalancingKMSClientProvider

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 3.0.0-beta1
    • Component/s: kms
    • Labels:
      None

      Description

      HADOOP-13827 added reencryptEncryptedKey to the KMS. An @Override was missed in LBKMSCP.

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 14m 0s trunk passed
          +1 compile 14m 7s trunk passed
          +1 checkstyle 0m 37s trunk passed
          +1 mvnsite 1m 30s trunk passed
          +1 findbugs 1m 25s trunk passed
          +1 javadoc 0m 50s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 39s the patch passed
          +1 compile 10m 38s the patch passed
          +1 javac 10m 38s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 1m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 42s the patch passed
          +1 javadoc 0m 52s the patch passed
                Other Tests
          -1 unit 8m 13s hadoop-common in the patch failed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          59m 5s



          Reason Tests
          Failed junit tests hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14760
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881503/HADOOP-14760.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bfa29df48b75 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4222c97
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13008/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13008/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13008/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 0s trunk passed +1 compile 14m 7s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 30s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 50s trunk passed       Patch Compile Tests +1 mvninstall 0m 39s the patch passed +1 compile 10m 38s the patch passed +1 javac 10m 38s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 42s the patch passed +1 javadoc 0m 52s the patch passed       Other Tests -1 unit 8m 13s hadoop-common in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 59m 5s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14760 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881503/HADOOP-14760.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bfa29df48b75 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4222c97 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13008/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13008/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13008/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          +1 Thanks Xiao Chen!

          Show
          jojochuang Wei-Chiu Chuang added a comment - +1 Thanks Xiao Chen !
          Hide
          xiaochen Xiao Chen added a comment -

          No unit tests needed, test failure unrelated.

          Committed to trunk. Thanks a lot Wei-Chiu Chuang!

          Show
          xiaochen Xiao Chen added a comment - No unit tests needed, test failure unrelated. Committed to trunk. Thanks a lot Wei-Chiu Chuang !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12167 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12167/)
          HADOOP-14760. Add missing override to LoadBalancingKMSClientProvider. (xiao: rev 07fff43f4a1e724c83ff8fcc90fac64aa04a39eb)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12167 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12167/ ) HADOOP-14760 . Add missing override to LoadBalancingKMSClientProvider. (xiao: rev 07fff43f4a1e724c83ff8fcc90fac64aa04a39eb) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java

            People

            • Assignee:
              xiaochen Xiao Chen
              Reporter:
              xiaochen Xiao Chen
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development