Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14709

Fix checkstyle warnings in ContractTestUtils

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.1
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: test
    • Labels:
      None

      Description

      ContractTestUtils is generating a lot of minor checkstyle complaints which make patching against the file noisier. Clean up

      (based on work in HADOOP-14660)

      1. HADOOP-14709-001.patch
        5 kB
        Steve Loughran
      2. HADOOP-14709-branch-2-001.patch
        5 kB
        Steve Loughran

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 001; extracted from Thomas's work

          Show
          stevel@apache.org Steve Loughran added a comment - Patch 001; extracted from Thomas's work
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 1s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 16m 55s trunk passed
          +1 compile 17m 24s trunk passed
          +1 checkstyle 0m 42s trunk passed
          +1 mvnsite 1m 43s trunk passed
          +1 findbugs 1m 42s trunk passed
          +1 javadoc 0m 58s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 49s the patch passed
          +1 compile 12m 56s the patch passed
          +1 javac 12m 56s the patch passed
          +1 checkstyle 0m 43s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 13 fixed = 3 total (was 16)
          +1 mvnsite 1m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 53s the patch passed
          +1 javadoc 0m 57s the patch passed
                Other Tests
          -1 unit 9m 15s hadoop-common in the patch failed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          70m 33s



          Reason Tests
          Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem
            hadoop.security.TestRaceWhenRelogin
            hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879853/HADOOP-14709-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 49eec14658fd 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b38a1ee
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12915/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12915/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12915/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 1s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 16m 55s trunk passed +1 compile 17m 24s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 43s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 58s trunk passed       Patch Compile Tests +1 mvninstall 0m 49s the patch passed +1 compile 12m 56s the patch passed +1 javac 12m 56s the patch passed +1 checkstyle 0m 43s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 13 fixed = 3 total (was 16) +1 mvnsite 1m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 57s the patch passed       Other Tests -1 unit 9m 15s hadoop-common in the patch failed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 70m 33s Reason Tests Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem   hadoop.security.TestRaceWhenRelogin   hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879853/HADOOP-14709-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 49eec14658fd 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b38a1ee Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12915/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12915/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12915/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1 for this in trunk,
          changing name to branch-2 to see how yetus handles it

          Show
          stevel@apache.org Steve Loughran added a comment - +1 for this in trunk, changing name to branch-2 to see how yetus handles it
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                branch-2 Compile Tests
          +1 mvninstall 7m 21s branch-2 passed
          +1 compile 6m 59s branch-2 passed with JDK v1.8.0_131
          +1 compile 7m 32s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 28s branch-2 passed
          +1 mvnsite 1m 7s branch-2 passed
          +1 findbugs 1m 59s branch-2 passed
          +1 javadoc 0m 50s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 0m 56s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          +1 mvninstall 0m 44s the patch passed
          +1 compile 6m 21s the patch passed with JDK v1.8.0_131
          +1 javac 6m 21s the patch passed
          +1 compile 7m 45s the patch passed with JDK v1.7.0_131
          +1 javac 7m 45s the patch passed
          +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 13 fixed = 3 total (was 16)
          +1 mvnsite 1m 4s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 8s the patch passed
          +1 javadoc 0m 47s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 55s the patch passed with JDK v1.7.0_131
                Other Tests
          +1 unit 9m 23s hadoop-common in the patch passed with JDK v1.7.0_131.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          68m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HADOOP-14709
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879892/HADOOP-14709-branch-2-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 82bdb9c7d0df 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 4006cc2
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12919/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12919/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-2 Compile Tests +1 mvninstall 7m 21s branch-2 passed +1 compile 6m 59s branch-2 passed with JDK v1.8.0_131 +1 compile 7m 32s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 28s branch-2 passed +1 mvnsite 1m 7s branch-2 passed +1 findbugs 1m 59s branch-2 passed +1 javadoc 0m 50s branch-2 passed with JDK v1.8.0_131 +1 javadoc 0m 56s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests +1 mvninstall 0m 44s the patch passed +1 compile 6m 21s the patch passed with JDK v1.8.0_131 +1 javac 6m 21s the patch passed +1 compile 7m 45s the patch passed with JDK v1.7.0_131 +1 javac 7m 45s the patch passed +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 13 fixed = 3 total (was 16) +1 mvnsite 1m 4s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 0m 47s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 55s the patch passed with JDK v1.7.0_131       Other Tests +1 unit 9m 23s hadoop-common in the patch passed with JDK v1.7.0_131. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 68m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14709 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879892/HADOOP-14709-branch-2-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 82bdb9c7d0df 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 4006cc2 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12919/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12919/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1
          committed to branch-2 & trunk. Thanks!

          Show
          stevel@apache.org Steve Loughran added a comment - +1 committed to branch-2 & trunk. Thanks!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12102 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12102/)
          HADOOP-14709. Fix checkstyle warnings in ContractTestUtils. Contributed (stevel: rev 5e4434f62890eb60048e8132ebe89e0c2a9580db)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/ContractTestUtils.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12102 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12102/ ) HADOOP-14709 . Fix checkstyle warnings in ContractTestUtils. Contributed (stevel: rev 5e4434f62890eb60048e8132ebe89e0c2a9580db) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/ContractTestUtils.java

            People

            • Assignee:
              tmarquardt Thomas Marquardt
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development