Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14690

RetryInvocationHandler$RetryInfo should override toString()

    Details

    • Hadoop Flags:
      Reviewed

      Description

      RetryInvocationHandler.java
            LOG.trace("#{} processRetryInfo: retryInfo={}, waitTime={}",
                callId, retryInfo, waitTime);
      

      RetryInfo is used for logging but it does not output useful information.

        Activity

        Hide
        Cyl Yeliang Cang added a comment -

        Hi Akira Ajisaka, I submit a patch like you suggested. Please see it!

        Show
        Cyl Yeliang Cang added a comment - Hi Akira Ajisaka , I submit a patch like you suggested. Please see it!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 25s trunk passed
        +1 compile 13m 35s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 1m 27s trunk passed
        +1 findbugs 1m 23s trunk passed
        +1 javadoc 0m 49s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 38s the patch passed
        +1 compile 10m 12s the patch passed
        +1 javac 10m 12s the patch passed
        +1 checkstyle 0m 35s the patch passed
        +1 mvnsite 1m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 0m 49s the patch passed
              Other Tests
        -1 unit 8m 3s hadoop-common in the patch failed.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        56m 55s



        Reason Tests
        Failed junit tests hadoop.security.TestRaceWhenRelogin
          hadoop.security.TestKDiag
          hadoop.net.TestDNS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14690
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879475/HADOOP-14690-001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e057b28f3608 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 890e14c
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12893/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12893/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12893/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 25s trunk passed +1 compile 13m 35s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 27s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 49s trunk passed       Patch Compile Tests +1 mvninstall 0m 38s the patch passed +1 compile 10m 12s the patch passed +1 javac 10m 12s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 1m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 49s the patch passed       Other Tests -1 unit 8m 3s hadoop-common in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 56m 55s Reason Tests Failed junit tests hadoop.security.TestRaceWhenRelogin   hadoop.security.TestKDiag   hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14690 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879475/HADOOP-14690-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e057b28f3608 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 890e14c Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12893/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12893/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12893/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Yeliang Cang for providing the patch! LGTM, +1. Checking this in.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Yeliang Cang for providing the patch! LGTM, +1. Checking this in.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk and branch-2. Thanks Yeliang Cang for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Yeliang Cang for the contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12076 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12076/)
        HADOOP-14690. RetryInvocationHandler should override toString(). (aajisaka: rev f14be0d24126747887ddc7580f4a9a70768de23d)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12076 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12076/ ) HADOOP-14690 . RetryInvocationHandler should override toString(). (aajisaka: rev f14be0d24126747887ddc7580f4a9a70768de23d) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
        Hide
        Cyl Yeliang Cang added a comment -

        Thank you for the review, Akira Ajisaka!

        Show
        Cyl Yeliang Cang added a comment - Thank you for the review, Akira Ajisaka !

          People

          • Assignee:
            Cyl Yeliang Cang
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development