Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14659

UGI getShortUserName does not need to search the Subject

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.2
    • Component/s: common
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      UGI#getShortUserName searches the subject for the User instance. It's not cheap to iterate a synchronized set, copy matches into a new set, then iterating that set. The UGI ctor already set the User into a final field...

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 26s trunk passed
        +1 compile 13m 29s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 1m 26s trunk passed
        +1 findbugs 1m 23s trunk passed
        +1 javadoc 0m 49s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 38s the patch passed
        +1 compile 10m 7s the patch passed
        +1 javac 10m 7s the patch passed
        +1 checkstyle 0m 37s the patch passed
        +1 mvnsite 1m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 29s the patch passed
        +1 javadoc 0m 50s the patch passed
              Other Tests
        -1 unit 8m 0s hadoop-common in the patch failed.
        +1 asflicense 0m 34s The patch does not generate ASF License warnings.
        56m 55s



        Reason Tests
        Failed junit tests hadoop.security.TestKDiag



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14659
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877152/HADOOP-14659.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux aa05fbebf3c7 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 945c095
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12779/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12779/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12779/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 26s trunk passed +1 compile 13m 29s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 26s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 49s trunk passed       Patch Compile Tests +1 mvninstall 0m 38s the patch passed +1 compile 10m 7s the patch passed +1 javac 10m 7s the patch passed +1 checkstyle 0m 37s the patch passed +1 mvnsite 1m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 50s the patch passed       Other Tests -1 unit 8m 0s hadoop-common in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 56m 55s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14659 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877152/HADOOP-14659.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux aa05fbebf3c7 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 945c095 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12779/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12779/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12779/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        fabbri Aaron Fabbri added a comment -

        +1 (non-binding) looks correct to me. I assume you're going to commit to trunk and backport?

        Show
        fabbri Aaron Fabbri added a comment - +1 (non-binding) looks correct to me. I assume you're going to commit to trunk and backport?
        Hide
        daryn Daryn Sharp added a comment -

        Yes, the patch applies to branch-2 as well.

        Show
        daryn Daryn Sharp added a comment - Yes, the patch applies to branch-2 as well.
        Hide
        shahrs87 Rushabh S Shah added a comment -

        +1 non-binding.

        Show
        shahrs87 Rushabh S Shah added a comment - +1 non-binding.
        Hide
        kihwal Kihwal Lee added a comment -

        +1 LGTM

        Show
        kihwal Kihwal Lee added a comment - +1 LGTM
        Hide
        kihwal Kihwal Lee added a comment -

        Committed to trunk, branch-2 and branch-2.8.

        Show
        kihwal Kihwal Lee added a comment - Committed to trunk, branch-2 and branch-2.8.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12039 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12039/)
        HADOOP-14659. UGI getShortUserName does not need to search the Subject. (kihwal: rev b3269f7cc119cbc51b16118b918f345f970804bc)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12039 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12039/ ) HADOOP-14659 . UGI getShortUserName does not need to search the Subject. (kihwal: rev b3269f7cc119cbc51b16118b918f345f970804bc) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java

          People

          • Assignee:
            daryn Daryn Sharp
            Reporter:
            daryn Daryn Sharp
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development