Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14608

KMS JMX servlet path not backwards compatible

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: 3.0.0-beta1
    • Component/s: kms
    • Labels:
      None

      Description

      HADOOP-13597 switched KMS from Tomcat to Jetty. The implementation changed JMX path from /kms/jmx to /jmx, which is inline with other HttpServer2 based servlets.

      1. HADOOP-14608.002.patch
        7 kB
        John Zhuge
      2. HADOOP-14608.001.patch
        1 kB
        John Zhuge

        Issue Links

          Activity

          Hide
          andrew.wang Andrew Wang added a comment -

          Is it possible to add a redirect or something for compatibility?

          Show
          andrew.wang Andrew Wang added a comment - Is it possible to add a redirect or something for compatibility?
          Hide
          jzhuge John Zhuge added a comment -

          Patch 001

          • Add JMX server /kms/jmx to web.xml

          Testing Done

          • Verified JMX /kms/jmx and /jmx. They produced the same output except some changed metric values.
          • KMS sanity tests including JMX /kms/jmx
            ✓ kms list key
             ✓ kms create key
             ✓ kms roll key
             ✓ kms delete key
             ✓ kms daemonlog
             ✓ kms servlet /kms/jmx
             ✓ kms servlet /jmx
             ✓ kms servlet /conf
             ✓ kms servlet /logLevel
             ✓ kms servlet /logs
             ✓ kms servlet /stacks
            
          Show
          jzhuge John Zhuge added a comment - Patch 001 Add JMX server /kms/jmx to web.xml Testing Done Verified JMX /kms/jmx and /jmx. They produced the same output except some changed metric values. KMS sanity tests including JMX /kms/jmx ✓ kms list key ✓ kms create key ✓ kms roll key ✓ kms delete key ✓ kms daemonlog ✓ kms servlet /kms/jmx ✓ kms servlet /jmx ✓ kms servlet /conf ✓ kms servlet /logLevel ✓ kms servlet /logs ✓ kms servlet /stacks
          Hide
          andrew.wang Andrew Wang added a comment -

          LGTM +1. Are your sanity tests covered by existing unit tests? That'd be good so it's automated for the future.

          Show
          andrew.wang Andrew Wang added a comment - LGTM +1. Are your sanity tests covered by existing unit tests? That'd be good so it's automated for the future.
          Hide
          jzhuge John Zhuge added a comment -

          Thanks Andrew Wang for the review and suggestion.

          Patch 002

          • Call the new testJMXQuery in testStartStop, thus test JMX in these 4 cases:
            • TestKMS.testStartStopHttpPseudo: ssl false, kerberos false
            • TestKMS.testStartStopHttpsPseudo: ssl true, kerberos false
            • TestKMS.testStartStopHttpKerberos: ssl false, kerberos true
            • TestKMS.testStartStopHttpsKerberos: ssl true, kerberos true
          Show
          jzhuge John Zhuge added a comment - Thanks Andrew Wang for the review and suggestion. Patch 002 Call the new testJMXQuery in testStartStop , thus test JMX in these 4 cases: TestKMS.testStartStopHttpPseudo: ssl false, kerberos false TestKMS.testStartStopHttpsPseudo: ssl true, kerberos false TestKMS.testStartStopHttpKerberos: ssl false, kerberos true TestKMS.testStartStopHttpsKerberos: ssl true, kerberos true
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 14m 18s trunk passed
          +1 compile 16m 19s trunk passed
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 findbugs 0m 31s trunk passed
          +1 javadoc 0m 19s trunk passed
          +1 mvninstall 0m 17s the patch passed
          +1 compile 12m 6s the patch passed
          +1 javac 12m 6s the patch passed
          -0 checkstyle 0m 19s hadoop-common-project/hadoop-kms: The patch generated 1 new + 98 unchanged - 0 fixed = 99 total (was 98)
          +1 mvnsite 0m 51s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 0m 40s the patch passed
          +1 javadoc 0m 20s the patch passed
          +1 unit 3m 4s hadoop-kms in the patch passed.
          +1 asflicense 0m 35s The patch does not generate ASF License warnings.
          53m 1s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14608
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875364/HADOOP-14608.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 030fb4b00ea0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fa1aaee
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12694/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12694/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12694/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 18s trunk passed +1 compile 16m 19s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 54s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 19s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 12m 6s the patch passed +1 javac 12m 6s the patch passed -0 checkstyle 0m 19s hadoop-common-project/hadoop-kms: The patch generated 1 new + 98 unchanged - 0 fixed = 99 total (was 98) +1 mvnsite 0m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 40s the patch passed +1 javadoc 0m 20s the patch passed +1 unit 3m 4s hadoop-kms in the patch passed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 53m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14608 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875364/HADOOP-14608.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 030fb4b00ea0 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fa1aaee Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12694/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12694/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12694/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 thanks for working on this John!

          Show
          andrew.wang Andrew Wang added a comment - +1 thanks for working on this John!
          Hide
          jzhuge John Zhuge added a comment -

          Committed to trunk with checkstyle fix.

          Thanks Andrew Wang for the review!

          Show
          jzhuge John Zhuge added a comment - Committed to trunk with checkstyle fix. Thanks Andrew Wang for the review!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11970 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11970/)
          HADOOP-14608. KMS JMX servlet path not backwards compatible. Contributed (jzhuge: rev 946dd256755109ca57d9cfa0912eef8402450181)

          • (edit) hadoop-common-project/hadoop-kms/src/main/resources/webapps/kms/WEB-INF/web.xml
          • (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11970 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11970/ ) HADOOP-14608 . KMS JMX servlet path not backwards compatible. Contributed (jzhuge: rev 946dd256755109ca57d9cfa0912eef8402450181) (edit) hadoop-common-project/hadoop-kms/src/main/resources/webapps/kms/WEB-INF/web.xml (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              jzhuge John Zhuge
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development