Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14602

allow custom release notes/changelog during create-release

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha3
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: build, scripts
    • Labels:
      None

      Description

      When doing a security release, we may not want to change JIRA to reflect that such a release is coming. Therefore, it would be nice to provide custom-made versions instead of allowing releasedocs to run. Since other features may require tweaking during a security release, let's create a --security flag which disables this behavior and potentially future behavior.

      1. HADOOP-14602.01.patch
        4 kB
        Allen Wittenauer
      2. HADOOP-14602.00.patch
        2 kB
        Allen Wittenauer

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11951 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11951/)
        HADOOP-14602. allow custom release notes/changelog during create-release (aw: rev 0c52da7d3e381ca59cd0ff72d143066a5c28d826)

        • (edit) dev-support/bin/create-release
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11951 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11951/ ) HADOOP-14602 . allow custom release notes/changelog during create-release (aw: rev 0c52da7d3e381ca59cd0ff72d143066a5c28d826) (edit) dev-support/bin/create-release
        Hide
        aw Allen Wittenauer added a comment -

        Thanks. I'll commit this in a sec.

        Yeah, we should add docs. I guess we need to change all of our directions to point to the new wiki since the old one can't be modified anymore... :/

        Show
        aw Allen Wittenauer added a comment - Thanks. I'll commit this in a sec. Yeah, we should add docs. I guess we need to change all of our directions to point to the new wiki since the old one can't be modified anymore... :/
        Hide
        chris.douglas Chris Douglas added a comment -

        +1 to the patch. I didn't try running it, but it looks reasonable.

        +    if [[ ! -d "${BASEDIR}/hadoop-common-project/hadoop-common/src/site/markdown/release/${HADOOP_VERSION}" ]]; then
        +      hadoop_error "ERROR: ${BASEDIR}/hadoop-common-project/hadoop-common/src/site/markdown/release/${HADOOP_VERSION} does not exist."
        +      hadoop_error "ERROR: This directory and its contents are required to be manually created for a security release."
        +      exit 1
        +    fi
        

        We should probably add a section to the wiki on the expected contents, also so it can serve as a checklist for reviewers of the RC.

        Show
        chris.douglas Chris Douglas added a comment - +1 to the patch. I didn't try running it, but it looks reasonable. + if [[ ! -d "${BASEDIR}/hadoop-common-project/hadoop-common/src/site/markdown/release/${HADOOP_VERSION}" ]]; then + hadoop_error "ERROR: ${BASEDIR}/hadoop-common-project/hadoop-common/src/site/markdown/release/${HADOOP_VERSION} does not exist." + hadoop_error "ERROR: This directory and its contents are required to be manually created for a security release." + exit 1 + fi We should probably add a section to the wiki on the expected contents, also so it can serve as a checklist for reviewers of the RC.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        0 mvndep 0m 21s Maven dependency ordering for branch
        0 mvndep 0m 19s Maven dependency ordering for patch
        +1 shellcheck 0m 2s The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
        +1 shelldocs 0m 11s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 25s The patch does not generate ASF License warnings.
        1m 52s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14602
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874899/HADOOP-14602.01.patch
        Optional Tests asflicense shellcheck shelldocs
        uname Linux 47b433c89941 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ee243e5
        shellcheck v0.4.6
        modules C: U:
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12648/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 21s Maven dependency ordering for branch 0 mvndep 0m 19s Maven dependency ordering for patch +1 shellcheck 0m 2s The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) +1 shelldocs 0m 11s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 1m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14602 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874899/HADOOP-14602.01.patch Optional Tests asflicense shellcheck shelldocs uname Linux 47b433c89941 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ee243e5 shellcheck v0.4.6 modules C: U: Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12648/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        -01:

        • correct patch
        • also fixes the shellcheck errors while we are here
        Show
        aw Allen Wittenauer added a comment - -01: correct patch also fixes the shellcheck errors while we are here
        Hide
        aw Allen Wittenauer added a comment -

        Argh. Thanks. I uploaded the wrong version of the patch. Let me dig out the correct one. Haha.

        Show
        aw Allen Wittenauer added a comment - Argh. Thanks. I uploaded the wrong version of the patch. Let me dig out the correct one. Haha.
        Hide
        chris.douglas Chris Douglas added a comment -

        Only skimmed the patch so this may be obvious in context, but --security sets SECURITYRELEASE while makearelease checks "${SECURITY}" == true ?

        Show
        chris.douglas Chris Douglas added a comment - Only skimmed the patch so this may be obvious in context, but --security sets SECURITYRELEASE while makearelease checks "${SECURITY}" == true ?
        Hide
        aw Allen Wittenauer added a comment -

        -00:

        • initial version
        Show
        aw Allen Wittenauer added a comment - -00: initial version

          People

          • Assignee:
            aw Allen Wittenauer
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development