[HADOOP-14524] Make CryptoCodec Closeable so it can be cleaned up proactively

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.6
• Hadoop Flags: Reviewed
• Assignee: Xiao Chen
• Reporter: Xiao Chen
• Created: 13/Jun/17 00:26
• Updated: 10/May/19 16:33
• Resolved: 16/Jun/17 16:50

Description

See HADOOP-14523 for motivation. Credit to Misha Dmitriev for reporting initially there.

Basically, the CryptoCodec class is not a closeable, but the OpensslAesCtrCryptoCodec implementation of it contains a closeable member (the Random object). Currently it is left for finalize() to clean up, this depends on when a FGC is run, and would create problems if OpensslAesCtrCryptoCodec is used with OsSecureRandom, which could let OS run out of FDs on /dev/urandom if too many codecs created.

Issue Links

• relates to: HADOOP-14523 OpensslAesCtrCryptoCodec.finalize() holds excessive amounts of memory