[HADOOP-14492] RpcDetailedMetrics and NameNodeMetrics use different rate metrics abstraction cause the Xavgtime confused

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: 2.8.0, 2.7.4
• Component/s: metrics
• Assignee: Erik Krogen
• Reporter: Lantao Jin
• Created: 06/Jun/17 02:27
• Updated: 07/Jun/17 18:25
• Resolved: 07/Jun/17 18:24

Description

For performance purpose, HADOOP-13782 change the metrics behaviour in RpcDetailedMetrics.
In 2.7.4:

public class RpcDetailedMetrics {

  @Metric MutableRatesWithAggregation rates;

In old version:

public class RpcDetailedMetrics {

  @Metric MutableRates rates;

But NameNodeMetrics still use MutableRate whatever in the new or old version:

public class NameNodeMetrics {
  @Metric("Block report") MutableRate blockReport;

It causes the metrics in JMX very different between them.

name: "Hadoop:service=NameNode,name=RpcDetailedActivityForPort8030",
modelerType: "RpcDetailedActivityForPort8030",
tag.port: "8030",
tag.Context: "rpcdetailed",
...
BlockReportNumOps: 237634,
BlockReportAvgTime: 1382,
...

name: "Hadoop:service=NameNode,name=NameNodeActivity",
modelerType: "NameNodeActivity",
tag.ProcessName: "NameNode",
...
BlockReportNumOps: 2592932,
BlockReportAvgTime: 19.258064516129032,
...

In the old version. They are correct.

Issue Links

• is related to: HADOOP-14502 Confusion/name conflict between NameNodeActivity#BlockReportNumOps and RpcDetailedActivity#BlockReportNumOps