Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14455

ViewFileSystem#rename should support be supported within same nameservice with different mountpoints

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.3
    • Component/s: viewfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Scenario:

      Mount Point NameService Value
      /tmp hacluster /tmp
      /user hacluster /user

      Move file from /tmp to /user
      It will fail by throwing the following error

      Caused by: java.io.IOException: Renames across Mount points not supported
              at org.apache.hadoop.fs.viewfs.ViewFileSystem.rename(ViewFileSystem.java:500)
              at org.apache.hadoop.hive.ql.metadata.Hive.moveFile(Hive.java:2692)
              ... 22 more
      
      1. HADOOP-14455.patch
        11 kB
        Brahma Reddy Battula
      2. HADOOP-14455-002.patch
        11 kB
        Brahma Reddy Battula
      3. HADOOP-14455-003.patch
        26 kB
        Brahma Reddy Battula
      4. HADOOP-14455-004.patch
        27 kB
        Brahma Reddy Battula
      5. HADOOP-14455-005.patch
        27 kB
        Brahma Reddy Battula
      6. HADOOP-14455-006.patch
        27 kB
        Brahma Reddy Battula
      7. HADOOP-14455-007.patch
        27 kB
        Brahma Reddy Battula
      8. HADOOP-14455-brach-2-007.patch
        27 kB
        Brahma Reddy Battula
      9. HADOOP-14455-branch-2-007.patch
        27 kB
        Brahma Reddy Battula

        Activity

        Hide
        stevel@apache.org Steve Loughran added a comment -

        Not convinced it can, let alone shoud

        Show
        stevel@apache.org Steve Loughran added a comment - Not convinced it can, let alone shoud
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Sorry, I didn't catch you..do you mean,no need to fix..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Sorry, I didn't catch you..do you mean,no need to fix..?
        Hide
        stevel@apache.org Steve Loughran added a comment -

        I mean "I'm not sure you could do a rename across mountpoints"

        Show
        stevel@apache.org Steve Loughran added a comment - I mean "I'm not sure you could do a rename across mountpoints"
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        oh ok..

        Show
        brahmareddy Brahma Reddy Battula added a comment - oh ok..
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        It's possible to do that.
        Uploading the patch..Kindly review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited It's possible to do that. Uploading the patch..Kindly review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 1m 34s Maven dependency ordering for branch
        +1 mvninstall 15m 17s trunk passed
        +1 compile 14m 36s trunk passed
        +1 checkstyle 1m 55s trunk passed
        +1 mvnsite 2m 5s trunk passed
        -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 1m 38s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 30s the patch passed
        +1 compile 10m 3s the patch passed
        -1 javac 10m 3s root generated 2 new + 787 unchanged - 0 fixed = 789 total (was 787)
        -0 checkstyle 2m 0s root: The patch generated 4 new + 263 unchanged - 3 fixed = 267 total (was 266)
        +1 mvnsite 2m 6s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 31s the patch passed
        +1 javadoc 1m 45s the patch passed
        -1 unit 7m 32s hadoop-common in the patch failed.
        -1 unit 63m 59s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 43s The patch does not generate ASF License warnings.
        155m 48s



        Reason Tests
        Failed junit tests hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
          hadoop.fs.viewfs.TestFcCreateMkdirLocalFs
          hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
          hadoop.fs.viewfs.TestFcMainOperationsLocalFs
          hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
          hadoop.fs.viewfs.TestViewFsLocalFs
          hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872229/HADOOP-14455.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a76dab3292e6 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 99634d1
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/diff-compile-javac-root.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 34s Maven dependency ordering for branch +1 mvninstall 15m 17s trunk passed +1 compile 14m 36s trunk passed +1 checkstyle 1m 55s trunk passed +1 mvnsite 2m 5s trunk passed -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 38s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 10m 3s the patch passed -1 javac 10m 3s root generated 2 new + 787 unchanged - 0 fixed = 789 total (was 787) -0 checkstyle 2m 0s root: The patch generated 4 new + 263 unchanged - 3 fixed = 267 total (was 266) +1 mvnsite 2m 6s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 31s the patch passed +1 javadoc 1m 45s the patch passed -1 unit 7m 32s hadoop-common in the patch failed. -1 unit 63m 59s hadoop-hdfs in the patch failed. +1 asflicense 0m 43s The patch does not generate ASF License warnings. 155m 48s Reason Tests Failed junit tests hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs   hadoop.fs.viewfs.TestFcCreateMkdirLocalFs   hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem   hadoop.fs.viewfs.TestFcMainOperationsLocalFs   hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem   hadoop.fs.viewfs.TestViewFsLocalFs   hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872229/HADOOP-14455.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a76dab3292e6 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99634d1 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12496/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch to address the testfailures and check-style issues.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch to address the testfailures and check-style issues.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 1m 20s Maven dependency ordering for branch
        +1 mvninstall 13m 35s trunk passed
        +1 compile 14m 10s trunk passed
        +1 checkstyle 1m 58s trunk passed
        +1 mvnsite 2m 7s trunk passed
        -1 findbugs 1m 30s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 1m 42s trunk passed
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 35s the patch passed
        +1 compile 10m 47s the patch passed
        -1 javac 10m 47s root generated 2 new + 787 unchanged - 0 fixed = 789 total (was 787)
        -0 checkstyle 2m 1s root: The patch generated 2 new + 263 unchanged - 3 fixed = 265 total (was 266)
        +1 mvnsite 2m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 37s the patch passed
        +1 javadoc 1m 52s the patch passed
        +1 unit 8m 2s hadoop-common in the patch passed.
        -1 unit 63m 54s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 43s The patch does not generate ASF License warnings.
        155m 10s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872396/HADOOP-14455-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c193e91c69dc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a2121cb
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/artifact/patchprocess/diff-compile-javac-root.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 1m 20s Maven dependency ordering for branch +1 mvninstall 13m 35s trunk passed +1 compile 14m 10s trunk passed +1 checkstyle 1m 58s trunk passed +1 mvnsite 2m 7s trunk passed -1 findbugs 1m 30s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 1m 42s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 35s the patch passed +1 compile 10m 47s the patch passed -1 javac 10m 47s root generated 2 new + 787 unchanged - 0 fixed = 789 total (was 787) -0 checkstyle 2m 1s root: The patch generated 2 new + 263 unchanged - 3 fixed = 265 total (was 266) +1 mvnsite 2m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 37s the patch passed +1 javadoc 1m 52s the patch passed +1 unit 8m 2s hadoop-common in the patch passed. -1 unit 63m 54s hadoop-hdfs in the patch failed. +1 asflicense 0m 43s The patch does not generate ASF License warnings. 155m 10s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12872396/HADOOP-14455-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c193e91c69dc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a2121cb Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12511/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Hi Manoj Govindassamy/Steve Loughran/Andrew Wang/Vinayakumar B
        if you get chance,can you please review the patch.?
        thanks

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Hi Manoj Govindassamy / Steve Loughran / Andrew Wang / Vinayakumar B if you get chance,can you please review the patch.? thanks
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks for reporting and posting patch Brahma Reddy Battula

        There were no historic reasons mentioned or found to allow only one of the alternative mentioned in comments. In ViewFileSystem#rename(..)

        Changing the current behavior straightaway is not correct.
        So it would be better to have a configuration, to keep current behavior intact and use the configuration to have desired behavior.

        There are 3 rename strategies available as of now.
        1. SAME_FILESYSTEM_ACROSS_MOUNTPOINT
        2. SAME_TARGET_URI_ACROSS_MOUNTPOINT
        3. SAME_MOUNTPOINT

        So, a config can be introduced to choose any one among the above, Default should be SAME_MOUNTPOINT.
        Based on the configuration, validation could vary.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks for reporting and posting patch Brahma Reddy Battula There were no historic reasons mentioned or found to allow only one of the alternative mentioned in comments. In ViewFileSystem#rename(..) Changing the current behavior straightaway is not correct. So it would be better to have a configuration, to keep current behavior intact and use the configuration to have desired behavior. There are 3 rename strategies available as of now. 1. SAME_FILESYSTEM_ACROSS_MOUNTPOINT 2. SAME_TARGET_URI_ACROSS_MOUNTPOINT 3. SAME_MOUNTPOINT So, a config can be introduced to choose any one among the above, Default should be SAME_MOUNTPOINT. Based on the configuration, validation could vary.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Ignoring the semantics of rename, test wise I think it fails my well known checklist of requirements of tests, namely

        • will assertions fail with any form of meaningful diagnostics, or will debugging Jenkins faiures be impossible without further patches to the tests. Fix: Use ContractTestUtils.assertPathExists()
        • Does it use hard-coded string comparisons when looking for exception text. Fix: static constant in production source, reference in test.
        • if a caught exception is not the one expected, is that caught exception lost, or is it the stack trace and the message propagated. Fix GenericTestUtils.assertExceptionContains(), or, if targeting java 8+ only, LambdaTestUtils.intercept()

        Imagine it is 18 months from now, and the test starts failing intermittently on Jenkins. Will the tests provide the information needed, or will you (or a successor) be left not having any idea what's going on? That's what tests should be trying to address. Not just verifying that the code works, but proving information needed to debug problems if/when it stops working

        Show
        stevel@apache.org Steve Loughran added a comment - Ignoring the semantics of rename, test wise I think it fails my well known checklist of requirements of tests , namely will assertions fail with any form of meaningful diagnostics, or will debugging Jenkins faiures be impossible without further patches to the tests. Fix: Use ContractTestUtils.assertPathExists() Does it use hard-coded string comparisons when looking for exception text. Fix: static constant in production source, reference in test. if a caught exception is not the one expected, is that caught exception lost, or is it the stack trace and the message propagated. Fix GenericTestUtils.assertExceptionContains() , or, if targeting java 8+ only, LambdaTestUtils.intercept() Imagine it is 18 months from now, and the test starts failing intermittently on Jenkins. Will the tests provide the information needed, or will you (or a successor) be left not having any idea what's going on? That's what tests should be trying to address. Not just verifying that the code works, but proving information needed to debug problems if/when it stops working
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Vinayakumar B thanks for taking look.

        Changing the current behavior straightaway is not correct.

        Agreed.

        So, a config can be introduced to choose any one among the above, Default should be SAME_MOUNTPOINT.

        Based on the configuration, validation could vary.

        done.

        Steve Loughran thanks for taking a look.

        Not just verifying that the code works, but proving information needed to debug problems if/when it stops working

        Agreed and updated the applicable as you mentioned.
        ContractTestUtils.assertPathExists() and GenericTestUtils.assertExceptionContains()

        Uploading the patch,kindly review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Vinayakumar B thanks for taking look. Changing the current behavior straightaway is not correct. Agreed. So, a config can be introduced to choose any one among the above, Default should be SAME_MOUNTPOINT. Based on the configuration, validation could vary. done. Steve Loughran thanks for taking a look. Not just verifying that the code works, but proving information needed to debug problems if/when it stops working Agreed and updated the applicable as you mentioned. ContractTestUtils.assertPathExists() and GenericTestUtils.assertExceptionContains() Uploading the patch,kindly review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
              trunk Compile Tests
        0 mvndep 1m 37s Maven dependency ordering for branch
        +1 mvninstall 13m 16s trunk passed
        +1 compile 15m 21s trunk passed
        +1 checkstyle 1m 57s trunk passed
        +1 mvnsite 2m 36s trunk passed
        -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 40s trunk passed
              Patch Compile Tests
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 30s the patch passed
        +1 compile 10m 13s the patch passed
        +1 javac 10m 13s the patch passed
        -0 checkstyle 1m 57s root: The patch generated 7 new + 291 unchanged - 3 fixed = 298 total (was 294)
        +1 mvnsite 2m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 3m 33s the patch passed
        +1 javadoc 1m 46s the patch passed
              Other Tests
        -1 unit 7m 41s hadoop-common in the patch failed.
        +1 unit 66m 5s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 50s The patch does not generate ASF License warnings.
        158m 19s



        Reason Tests
        Failed junit tests hadoop.conf.TestCommonConfigurationFields



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876414/HADOOP-14455-003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux f86f5cf50fc1 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 09653ea
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 1m 37s Maven dependency ordering for branch +1 mvninstall 13m 16s trunk passed +1 compile 15m 21s trunk passed +1 checkstyle 1m 57s trunk passed +1 mvnsite 2m 36s trunk passed -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 40s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 10m 13s the patch passed +1 javac 10m 13s the patch passed -0 checkstyle 1m 57s root: The patch generated 7 new + 291 unchanged - 3 fixed = 298 total (was 294) +1 mvnsite 2m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 33s the patch passed +1 javadoc 1m 46s the patch passed       Other Tests -1 unit 7m 41s hadoop-common in the patch failed. +1 unit 66m 5s hadoop-hdfs in the patch passed. +1 asflicense 0m 50s The patch does not generate ASF License warnings. 158m 19s Reason Tests Failed junit tests hadoop.conf.TestCommonConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876414/HADOOP-14455-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f86f5cf50fc1 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 09653ea Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12753/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment - - edited

        Patch almost looks good to me.
        Please fix the checkstyle issues and test failure.
        Test failure is due to new configuration in core-default.xml, which is not found in CommonConfigurationsKey.java.
        You can add this key to be ignored in the test, as this is present in Constants.java along with other viewfs keys.

        Show
        vinayrpet Vinayakumar B added a comment - - edited Patch almost looks good to me. Please fix the checkstyle issues and test failure. Test failure is due to new configuration in core-default.xml, which is not found in CommonConfigurationsKey.java. You can add this key to be ignored in the test, as this is present in Constants.java along with other viewfs keys.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Vinayakumar B thanks a lot for your review.
        Updated the patch to fix the checkstyle and testcase failure..Kindly review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Vinayakumar B thanks a lot for your review. Updated the patch to fix the checkstyle and testcase failure..Kindly review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
              trunk Compile Tests
        0 mvndep 1m 19s Maven dependency ordering for branch
        +1 mvninstall 12m 49s trunk passed
        +1 compile 13m 18s trunk passed
        +1 checkstyle 1m 53s trunk passed
        +1 mvnsite 2m 15s trunk passed
        -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 30s trunk passed
              Patch Compile Tests
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 1m 23s the patch passed
        +1 compile 9m 47s the patch passed
        +1 javac 9m 47s the patch passed
        -0 checkstyle 1m 44s root: The patch generated 19 new + 297 unchanged - 3 fixed = 316 total (was 300)
        +1 mvnsite 2m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 3m 48s the patch passed
        +1 javadoc 1m 41s the patch passed
              Other Tests
        +1 unit 7m 40s hadoop-common in the patch passed.
        -1 unit 68m 29s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        156m 2s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.web.TestWebHdfsTimeouts



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877066/HADOOP-14455-004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 4bbcd8055879 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b61ab85
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       trunk Compile Tests 0 mvndep 1m 19s Maven dependency ordering for branch +1 mvninstall 12m 49s trunk passed +1 compile 13m 18s trunk passed +1 checkstyle 1m 53s trunk passed +1 mvnsite 2m 15s trunk passed -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 30s trunk passed       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 23s the patch passed +1 compile 9m 47s the patch passed +1 javac 9m 47s the patch passed -0 checkstyle 1m 44s root: The patch generated 19 new + 297 unchanged - 3 fixed = 316 total (was 300) +1 mvnsite 2m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 48s the patch passed +1 javadoc 1m 41s the patch passed       Other Tests +1 unit 7m 40s hadoop-common in the patch passed. -1 unit 68m 29s hadoop-hdfs in the patch failed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 156m 2s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.web.TestWebHdfsTimeouts Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877066/HADOOP-14455-004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 4bbcd8055879 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b61ab85 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12774/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Corrected the indentation..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Corrected the indentation..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 21m 23s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
              trunk Compile Tests
        0 mvndep 1m 34s Maven dependency ordering for branch
        +1 mvninstall 13m 49s trunk passed
        +1 compile 14m 17s trunk passed
        +1 checkstyle 1m 59s trunk passed
        +1 mvnsite 2m 28s trunk passed
        -1 findbugs 1m 49s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 41s trunk passed
              Patch Compile Tests
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 31s the patch passed
        +1 compile 11m 0s the patch passed
        +1 javac 11m 0s the patch passed
        -0 checkstyle 2m 11s root: The patch generated 19 new + 297 unchanged - 3 fixed = 316 total (was 300)
        +1 mvnsite 2m 51s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 43s the patch passed
        +1 javadoc 1m 47s the patch passed
              Other Tests
        -1 unit 8m 25s hadoop-common in the patch failed.
        -1 unit 108m 16s hadoop-hdfs in the patch failed.
        +1 asflicense 2m 7s The patch does not generate ASF License warnings.
        224m 22s



        Reason Tests
        Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
          hadoop.hdfs.qjournal.client.TestQuorumJournalManager
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877107/HADOOP-14455-005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 269b54f52457 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b61ab85
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 21m 23s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       trunk Compile Tests 0 mvndep 1m 34s Maven dependency ordering for branch +1 mvninstall 13m 49s trunk passed +1 compile 14m 17s trunk passed +1 checkstyle 1m 59s trunk passed +1 mvnsite 2m 28s trunk passed -1 findbugs 1m 49s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 41s trunk passed       Patch Compile Tests 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 11m 0s the patch passed +1 javac 11m 0s the patch passed -0 checkstyle 2m 11s root: The patch generated 19 new + 297 unchanged - 3 fixed = 316 total (was 300) +1 mvnsite 2m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 43s the patch passed +1 javadoc 1m 47s the patch passed       Other Tests -1 unit 8m 25s hadoop-common in the patch failed. -1 unit 108m 16s hadoop-hdfs in the patch failed. +1 asflicense 2m 7s The patch does not generate ASF License warnings. 224m 22s Reason Tests Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.qjournal.client.TestQuorumJournalManager   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877107/HADOOP-14455-005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 269b54f52457 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b61ab85 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12777/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Testcase failures are unrelated to this change.Even I executed locally those tests.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Testcase failures are unrelated to this change.Even I executed locally those tests.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
              trunk Compile Tests
        0 mvndep 1m 34s Maven dependency ordering for branch
        +1 mvninstall 14m 20s trunk passed
        +1 compile 14m 37s trunk passed
        +1 checkstyle 1m 59s trunk passed
        +1 mvnsite 2m 31s trunk passed
        -1 findbugs 1m 51s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 45s trunk passed
              Patch Compile Tests
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 1m 37s the patch passed
        +1 compile 11m 11s the patch passed
        +1 javac 11m 11s the patch passed
        +1 checkstyle 2m 2s root: The patch generated 0 new + 296 unchanged - 3 fixed = 296 total (was 299)
        +1 mvnsite 2m 40s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 49s the patch passed
        +1 javadoc 1m 49s the patch passed
              Other Tests
        -1 unit 8m 43s hadoop-common in the patch failed.
        -1 unit 69m 43s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 41s The patch does not generate ASF License warnings.
        164m 38s



        Reason Tests
        Failed junit tests hadoop.ha.TestZKFailoverController
          hadoop.security.TestKDiag
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877214/HADOOP-14455-006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 95b8e5bd6225 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 228ddaa
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       trunk Compile Tests 0 mvndep 1m 34s Maven dependency ordering for branch +1 mvninstall 14m 20s trunk passed +1 compile 14m 37s trunk passed +1 checkstyle 1m 59s trunk passed +1 mvnsite 2m 31s trunk passed -1 findbugs 1m 51s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 45s trunk passed       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 1m 37s the patch passed +1 compile 11m 11s the patch passed +1 javac 11m 11s the patch passed +1 checkstyle 2m 2s root: The patch generated 0 new + 296 unchanged - 3 fixed = 296 total (was 299) +1 mvnsite 2m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 49s the patch passed +1 javadoc 1m 49s the patch passed       Other Tests -1 unit 8m 43s hadoop-common in the patch failed. -1 unit 69m 43s hadoop-hdfs in the patch failed. +1 asflicense 0m 41s The patch does not generate ASF License warnings. 164m 38s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.security.TestKDiag   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877214/HADOOP-14455-006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 95b8e5bd6225 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 228ddaa Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12780/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        test-failures are unrelated.Vinayakumar B can you please check the latest patch..can I go-head with commit..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - test-failures are unrelated. Vinayakumar B can you please check the latest patch..can I go-head with commit..?
        Hide
        vinayrpet Vinayakumar B added a comment -

        Patch looks almost good.

        Just 2 nits, You can commit once addressed.
        1. Even though reaching this line is impossible now, it should be IllegalArgumentException not IllegalStateException.

        +    default:
        +      throw new IllegalStateException("Unexpected rename strategy");
             }
        

        2. In below code, you can remove the comment line. Its no longer relavant here

        -    resSrc.targetFileSystem.renameInternal(resSrc.remainingPath,
        -      resDst.remainingPath, overwrite);
        +    //Alternate 1: renames within same file system
        +    URI srcUri = resSrc.targetFileSystem.getUri();
        +    URI dstUri = resDst.targetFileSystem.getUri();
        +    ViewFileSystem.verifyRenameStrategy(srcUri, dstUri,
        +        resSrc.targetFileSystem == resDst.targetFileSystem, renameStrategy);

        Once addressed, you can commit, unless others have different opinion

        Show
        vinayrpet Vinayakumar B added a comment - Patch looks almost good. Just 2 nits, You can commit once addressed. 1. Even though reaching this line is impossible now, it should be IllegalArgumentException not IllegalStateException . + default : + throw new IllegalStateException( "Unexpected rename strategy" ); } 2. In below code, you can remove the comment line. Its no longer relavant here - resSrc.targetFileSystem.renameInternal(resSrc.remainingPath, - resDst.remainingPath, overwrite); + //Alternate 1: renames within same file system + URI srcUri = resSrc.targetFileSystem.getUri(); + URI dstUri = resDst.targetFileSystem.getUri(); + ViewFileSystem.verifyRenameStrategy(srcUri, dstUri, + resSrc.targetFileSystem == resDst.targetFileSystem, renameStrategy); Once addressed, you can commit, unless others have different opinion
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploading the patch to address the minor nits.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploading the patch to address the minor nits.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
              trunk Compile Tests
        0 mvndep 1m 20s Maven dependency ordering for branch
        +1 mvninstall 13m 23s trunk passed
        +1 compile 13m 36s trunk passed
        +1 checkstyle 1m 56s trunk passed
        +1 mvnsite 2m 26s trunk passed
        -1 findbugs 1m 48s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 40s trunk passed
              Patch Compile Tests
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 31s the patch passed
        +1 compile 10m 15s the patch passed
        +1 javac 10m 15s the patch passed
        -0 checkstyle 1m 59s root: The patch generated 1 new + 296 unchanged - 3 fixed = 297 total (was 299)
        +1 mvnsite 2m 31s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 3m 35s the patch passed
        +1 javadoc 1m 46s the patch passed
              Other Tests
        -1 unit 8m 7s hadoop-common in the patch failed.
        -1 unit 64m 41s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 42s The patch does not generate ASF License warnings.
        155m 1s



        Reason Tests
        Failed junit tests hadoop.fs.shell.TestCopyFromLocal
          hadoop.security.TestKDiag
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878608/HADOOP-14455-007.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 1c63fe528ba6 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 770cc46
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       trunk Compile Tests 0 mvndep 1m 20s Maven dependency ordering for branch +1 mvninstall 13m 23s trunk passed +1 compile 13m 36s trunk passed +1 checkstyle 1m 56s trunk passed +1 mvnsite 2m 26s trunk passed -1 findbugs 1m 48s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 40s trunk passed       Patch Compile Tests 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 10m 15s the patch passed +1 javac 10m 15s the patch passed -0 checkstyle 1m 59s root: The patch generated 1 new + 296 unchanged - 3 fixed = 297 total (was 299) +1 mvnsite 2m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 35s the patch passed +1 javadoc 1m 46s the patch passed       Other Tests -1 unit 8m 7s hadoop-common in the patch failed. -1 unit 64m 41s hadoop-hdfs in the patch failed. +1 asflicense 0m 42s The patch does not generate ASF License warnings. 155m 1s Reason Tests Failed junit tests hadoop.fs.shell.TestCopyFromLocal   hadoop.security.TestKDiag   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878608/HADOOP-14455-007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 1c63fe528ba6 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 770cc46 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12844/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk, there are conflicts for branch-2..Uploading patch for same

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk , there are conflicts for branch-2..Uploading patch for same
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12053 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12053/)
        HADOOP-14455. ViewFileSystem#rename should support be supported within (brahma: rev 6d983cca52f113118bf49fec527ffb3eb869290a)

        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/Constants.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/ContractTestUtils.java
        • (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12053 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12053/ ) HADOOP-14455 . ViewFileSystem#rename should support be supported within (brahma: rev 6d983cca52f113118bf49fec527ffb3eb869290a) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/Constants.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/ContractTestUtils.java (edit) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
              branch-2 Compile Tests
        0 mvndep 0m 54s Maven dependency ordering for branch
        +1 mvninstall 7m 20s branch-2 passed
        +1 compile 6m 5s branch-2 passed with JDK v1.8.0_131
        +1 compile 7m 17s branch-2 passed with JDK v1.7.0_131
        +1 checkstyle 1m 30s branch-2 passed
        +1 mvnsite 1m 53s branch-2 passed
        +1 findbugs 3m 58s branch-2 passed
        +1 javadoc 1m 27s branch-2 passed with JDK v1.8.0_131
        +1 javadoc 1m 59s branch-2 passed with JDK v1.7.0_131
              Patch Compile Tests
        0 mvndep 0m 19s Maven dependency ordering for patch
        -1 mvninstall 0m 41s hadoop-hdfs in the patch failed.
        -1 compile 2m 8s root in the patch failed with JDK v1.8.0_131.
        -1 javac 2m 8s root in the patch failed with JDK v1.8.0_131.
        -1 compile 2m 7s root in the patch failed with JDK v1.7.0_131.
        -1 javac 2m 7s root in the patch failed with JDK v1.7.0_131.
        -0 checkstyle 1m 35s root: The patch generated 7 new + 304 unchanged - 3 fixed = 311 total (was 307)
        -1 mvnsite 0m 43s hadoop-hdfs in the patch failed.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        -1 findbugs 0m 27s hadoop-hdfs in the patch failed.
        +1 javadoc 1m 37s the patch passed with JDK v1.8.0_131
        +1 javadoc 2m 4s the patch passed with JDK v1.7.0_131
              Other Tests
        +1 unit 9m 2s hadoop-common in the patch passed with JDK v1.7.0_131.
        -1 unit 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        89m 45s



        Reason Tests
        JDK v1.8.0_131 Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5e40efe
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878832/HADOOP-14455-branch-2-007.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 33d00569e591 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 3d8c7d7
        Default Java 1.7.0_131
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/diff-checkstyle-root.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
        JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 54s Maven dependency ordering for branch +1 mvninstall 7m 20s branch-2 passed +1 compile 6m 5s branch-2 passed with JDK v1.8.0_131 +1 compile 7m 17s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 1m 30s branch-2 passed +1 mvnsite 1m 53s branch-2 passed +1 findbugs 3m 58s branch-2 passed +1 javadoc 1m 27s branch-2 passed with JDK v1.8.0_131 +1 javadoc 1m 59s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 19s Maven dependency ordering for patch -1 mvninstall 0m 41s hadoop-hdfs in the patch failed. -1 compile 2m 8s root in the patch failed with JDK v1.8.0_131. -1 javac 2m 8s root in the patch failed with JDK v1.8.0_131. -1 compile 2m 7s root in the patch failed with JDK v1.7.0_131. -1 javac 2m 7s root in the patch failed with JDK v1.7.0_131. -0 checkstyle 1m 35s root: The patch generated 7 new + 304 unchanged - 3 fixed = 311 total (was 307) -1 mvnsite 0m 43s hadoop-hdfs in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. -1 findbugs 0m 27s hadoop-hdfs in the patch failed. +1 javadoc 1m 37s the patch passed with JDK v1.8.0_131 +1 javadoc 2m 4s the patch passed with JDK v1.7.0_131       Other Tests +1 unit 9m 2s hadoop-common in the patch passed with JDK v1.7.0_131. -1 unit 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 89m 45s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.fs.sftp.TestSFTPFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878832/HADOOP-14455-branch-2-007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 33d00569e591 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 3d8c7d7 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-compile-root-jdk1.7.0_131.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12850/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s HADOOP-14455 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878946/HADOOP-14455-brach-2-007.patch
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12859/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HADOOP-14455 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878946/HADOOP-14455-brach-2-007.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12859/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Just renamed the patchas jenkins didn't picked earlier.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Just renamed the patchas jenkins didn't picked earlier.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
              branch-2 Compile Tests
        0 mvndep 0m 53s Maven dependency ordering for branch
        +1 mvninstall 6m 34s branch-2 passed
        +1 compile 5m 39s branch-2 passed with JDK v1.8.0_131
        +1 compile 6m 40s branch-2 passed with JDK v1.7.0_131
        +1 checkstyle 1m 29s branch-2 passed
        +1 mvnsite 1m 51s branch-2 passed
        +1 findbugs 3m 38s branch-2 passed
        +1 javadoc 1m 26s branch-2 passed with JDK v1.8.0_131
        +1 javadoc 1m 54s branch-2 passed with JDK v1.7.0_131
              Patch Compile Tests
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 27s the patch passed
        +1 compile 5m 39s the patch passed with JDK v1.8.0_131
        -1 javac 5m 39s root-jdk1.8.0_131 with JDK v1.8.0_131 generated 2 new + 1382 unchanged - 2 fixed = 1384 total (was 1384)
        +1 compile 6m 40s the patch passed with JDK v1.7.0_131
        +1 javac 6m 40s the patch passed
        -0 checkstyle 1m 37s root: The patch generated 1 new + 304 unchanged - 3 fixed = 305 total (was 307)
        +1 mvnsite 2m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 findbugs 4m 18s the patch passed
        +1 javadoc 1m 31s the patch passed with JDK v1.8.0_131
        +1 javadoc 1m 58s the patch passed with JDK v1.7.0_131
              Other Tests
        +1 unit 8m 42s hadoop-common in the patch passed with JDK v1.7.0_131.
        -1 unit 57m 6s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        209m 4s



        Reason Tests
        JDK v1.8.0_131 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
        JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.server.balancer.TestBalancerRPCDelay
        JDK v1.7.0_131 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5e40efe
        JIRA Issue HADOOP-14455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878948/HADOOP-14455-branch-2-007.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux f73cb7b9c792 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 554c3cd
        Default Java 1.7.0_131
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_131.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
        JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       branch-2 Compile Tests 0 mvndep 0m 53s Maven dependency ordering for branch +1 mvninstall 6m 34s branch-2 passed +1 compile 5m 39s branch-2 passed with JDK v1.8.0_131 +1 compile 6m 40s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 1m 29s branch-2 passed +1 mvnsite 1m 51s branch-2 passed +1 findbugs 3m 38s branch-2 passed +1 javadoc 1m 26s branch-2 passed with JDK v1.8.0_131 +1 javadoc 1m 54s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 5m 39s the patch passed with JDK v1.8.0_131 -1 javac 5m 39s root-jdk1.8.0_131 with JDK v1.8.0_131 generated 2 new + 1382 unchanged - 2 fixed = 1384 total (was 1384) +1 compile 6m 40s the patch passed with JDK v1.7.0_131 +1 javac 6m 40s the patch passed -0 checkstyle 1m 37s root: The patch generated 1 new + 304 unchanged - 3 fixed = 305 total (was 307) +1 mvnsite 2m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 4m 18s the patch passed +1 javadoc 1m 31s the patch passed with JDK v1.8.0_131 +1 javadoc 1m 58s the patch passed with JDK v1.7.0_131       Other Tests +1 unit 8m 42s hadoop-common in the patch passed with JDK v1.7.0_131. -1 unit 57m 6s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 209m 4s Reason Tests JDK v1.8.0_131 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.balancer.TestBalancerRPCDelay JDK v1.7.0_131 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HADOOP-14455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878948/HADOOP-14455-branch-2-007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f73cb7b9c792 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 554c3cd Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_131.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12860/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Pushed to branch-2 and branch-2.8 also. Vinayakumar B thanks a lot for your review and Steve Loughran thanks for additional review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Pushed to branch-2 and branch-2.8 also. Vinayakumar B thanks a lot for your review and Steve Loughran thanks for additional review.

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development