Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14449

The ASF Header in ComparableVersion.java and SSLHostnameVerifier.java is not correct

    Details

    • Hadoop Flags:
      Reviewed

      Description

      The ASF Header in ComparableVersion.java and SSLHostnameVerifier.java is not correct

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11773 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11773/)
        HADOOP-14449. The ASF Header in ComparableVersion.java and (brahma: rev b7a0c0e7019528fac492e1cb32d374ed014f8673)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLHostnameVerifier.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ComparableVersion.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11773 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11773/ ) HADOOP-14449 . The ASF Header in ComparableVersion.java and (brahma: rev b7a0c0e7019528fac492e1cb32d374ed014f8673) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLHostnameVerifier.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ComparableVersion.java
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Committed to trunk ,branch-2 and branch-2.8. ZhangBing Lin thanks for your contribution.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Committed to trunk , branch-2 and branch-2.8 . ZhangBing Lin thanks for your contribution.
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Brahma Reddy Battula,thank you for your review!

        Show
        linzhangbing ZhangBing Lin added a comment - Brahma Reddy Battula ,thank you for your review!
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        ZhangBing Lin nice finding.. Patch LGTM.. will commit..

        Show
        brahmareddy Brahma Reddy Battula added a comment - ZhangBing Lin nice finding.. Patch LGTM.. will commit..
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Just modifying the Hadoop Common's ASFHeader do not need unit tests

        Show
        linzhangbing ZhangBing Lin added a comment - Just modifying the Hadoop Common's ASFHeader do not need unit tests
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Brahma Reddy Battula,Can you plz take a quick review?

        Show
        linzhangbing ZhangBing Lin added a comment - Brahma Reddy Battula ,Can you plz take a quick review?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 44s trunk passed
        +1 compile 12m 14s trunk passed
        +1 checkstyle 0m 42s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        -1 findbugs 1m 18s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 0m 43s trunk passed
        +1 mvninstall 0m 34s the patch passed
        +1 compile 11m 45s the patch passed
        +1 javac 11m 45s the patch passed
        +1 checkstyle 0m 38s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 44s the patch passed
        +1 unit 7m 38s hadoop-common in the patch passed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        56m 10s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14449
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869584/HADOOP-14449.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5fc09a4735bc 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 52661e0
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12380/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12380/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12380/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 44s trunk passed +1 compile 12m 14s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 15s trunk passed -1 findbugs 1m 18s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 34s the patch passed +1 compile 11m 45s the patch passed +1 javac 11m 45s the patch passed +1 checkstyle 0m 38s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 7m 38s hadoop-common in the patch passed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 56m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14449 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869584/HADOOP-14449.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5fc09a4735bc 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 52661e0 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12380/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12380/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12380/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Looking at the compilation log, I found that the Hadoop Common module was compiled successfully.
        Just modifying the Hadoop Common's ASFHeader does not cause the Yarn UI module to compile failed
        Compilation failure is caused by compiling json files and js file errors in [Apache Hadoop YARN UI].
        Such as:
        [ERROR] bower ember#2.2.0 invalid-meta ember is missing "ignore" entry in bower.json
        [ERROR] bower select2#4.0.0 invalid-meta select2 is missing "ignore" entry in bower.json

        Show
        linzhangbing ZhangBing Lin added a comment - Looking at the compilation log, I found that the Hadoop Common module was compiled successfully. Just modifying the Hadoop Common's ASFHeader does not cause the Yarn UI module to compile failed Compilation failure is caused by compiling json files and js file errors in [Apache Hadoop YARN UI] . Such as: [ERROR] bower ember#2.2.0 invalid-meta ember is missing "ignore" entry in bower.json [ERROR] bower select2#4.0.0 invalid-meta select2 is missing "ignore" entry in bower.json
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 14m 37s trunk passed
        -1 compile 7m 20s root in trunk failed.
        +1 checkstyle 0m 48s trunk passed
        +1 mvnsite 1m 6s trunk passed
        +1 mvneclipse 0m 20s trunk passed
        -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
        +1 javadoc 0m 52s trunk passed
        +1 mvninstall 0m 44s the patch passed
        +1 compile 13m 34s the patch passed
        -1 javac 13m 34s root generated 501 new + 286 unchanged - 0 fixed = 787 total (was 286)
        +1 checkstyle 0m 51s the patch passed
        +1 mvnsite 1m 4s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 38s the patch passed
        +1 javadoc 0m 50s the patch passed
        +1 unit 7m 35s hadoop-common in the patch passed.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        56m 1s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HADOOP-14449
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869406/HADOOP-14449.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c43af384aa4e 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d0f346a
        Default Java 1.8.0_131
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/artifact/patchprocess/branch-compile-root.txt
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/artifact/patchprocess/diff-compile-javac-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 37s trunk passed -1 compile 7m 20s root in trunk failed. +1 checkstyle 0m 48s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 20s trunk passed -1 findbugs 1m 25s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 52s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 13m 34s the patch passed -1 javac 13m 34s root generated 501 new + 286 unchanged - 0 fixed = 787 total (was 286) +1 checkstyle 0m 51s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 38s the patch passed +1 javadoc 0m 50s the patch passed +1 unit 7m 35s hadoop-common in the patch passed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 56m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14449 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869406/HADOOP-14449.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c43af384aa4e 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0f346a Default Java 1.8.0_131 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/artifact/patchprocess/branch-compile-root.txt findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html javac https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/artifact/patchprocess/diff-compile-javac-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12377/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linzhangbing ZhangBing Lin added a comment -
        Show
        linzhangbing ZhangBing Lin added a comment - Brahma Reddy Battula ,thank you!
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        ZhangBing Lin thanks for reporting issue.. Added you as hadoop contributor..Now onwards you can assign jira's.

        Show
        brahmareddy Brahma Reddy Battula added a comment - ZhangBing Lin thanks for reporting issue.. Added you as hadoop contributor..Now onwards you can assign jira's.
        Hide
        linzhangbing ZhangBing Lin added a comment -

        Submit a patch!

        Show
        linzhangbing ZhangBing Lin added a comment - Submit a patch!

          People

          • Assignee:
            linzhangbing ZhangBing Lin
            Reporter:
            linzhangbing ZhangBing Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development