[HADOOP-14432] S3A copyFromLocalFile to be robust, tested

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 3.0.0-alpha4
• Component/s: fs
• Target Version/s: 3.0.0-alpha2
• Hadoop Flags: Reviewed
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 17/May/17 13:27
• Updated: 14/Nov/18 21:55
• Resolved: 19/May/17 18:53

Description

S3AFileSystem.copyFromLocalFile()

Doesn't

• check for local file existing. Fix: check and raise FNFE (today: AmazonClientException is raised)
• check for dest being a directory. Fix: Better checks before upload
• have any tests. Fix: write the tests

this is related to the committer work, but doesn't depend on it

Issue Links

• causes: HADOOP-15932 Oozie unable to create sharelib in s3a filesystem
• is depended upon by: HADOOP-13345 S3Guard: Improved Consistency for S3A
• is depended upon by: HADOOP-14766 Cloudup: an object store high performance dfs put command
• is duplicated by: HADOOP-13143 harden S3AFileSystem.copyFromLocalFile()