Description
HDFS-11170 added a builder-based create API for file creation which has a few issues to work out before it can be considered ready for use
1. There no specification in the filesystem.md of what it is meant to do, which means there's no public documentation on expected behaviour except on the Javadocs, which consists of the sentences "Create a new FSDataOutputStreamBuilder for the file with path" and "Base of specific file system FSDataOutputStreamBuilder".
I propose:
- Give the new method a relevant name rather than just define the return type, e.g. createFile().
- `Filesystem.md` to be extended with coverage of this method, and, sadly for the authors, coverage of what the semantics of FSDataOutputStreamBuilder.build() are.
2. There are only tests for HDFS and local, neither of them perfect. Proposed: move to AbstractContractCreateTest, test for all filesystems, fix tests and FS where appropriate.
3. Add more tests to generate the failure conditions implied by the updated filesystem spec. Eg. create over a an existing file, create over a directory, create with negative buffer size, negative block size, empty dest path, etc, etc.
This will clarify when precondition checks are made, as well as whether. For example: should newFSDataOutputStreamBuilder() validate the path immediately?
4. Add to FileContext.
5. Take the opportunity to look at the flaws in today's create() calls and address them, rather than replicate. In particular, I'd like to end the behaviour "create all parent dirs.
Attachments
Issue Links
- is broken by
-
HDFS-11170 Add builder-based create API to FileSystem
-
- Resolved
-
- is related to
-
HDFS-11644 Support for querying outputstream capabilities
-
- Resolved
-
-
HADOOP-15229 Add FileSystem builder-based openFile() API to match createFile(); S3A to implement S3 Select through this API.
-
- Resolved
-
-
-
- Resolved
-
- relates to
-
HADOOP-13327 Add OutputStream + Syncable to the Filesystem Specification
-
- Resolved
-