Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14356

Update CHANGES.txt to reflect all the changes in branch-2.7

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.4
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    1. HADOOP-14356.patch
      3 kB
      Brahma Reddy Battula
    2. HADOOP-14356-002.patch
      4 kB
      Brahma Reddy Battula
    3. HADOOP-14356-branch-2.7-003.patch
      4 kB
      Brahma Reddy Battula
    4. HADOOP-14356-branch-2.7-004.patch
      4 kB
      Brahma Reddy Battula

      Issue Links

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Attached the patch..Kindly Review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Attached the patch..Kindly Review.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Would you add the following issues?
        HADOOP-14195, YARN-1728, MAPREDUCE-6711, YARN-5694, HDFS-10941, HDFS-10921, YARN-3877

        Show
        ajisakaa Akira Ajisaka added a comment - Would you add the following issues? HADOOP-14195 , YARN-1728 , MAPREDUCE-6711 , YARN-5694 , HDFS-10941 , HDFS-10921 , YARN-3877
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I used git log --numstat to find the commits that do not edit CHANGES.txt.

        Show
        ajisakaa Akira Ajisaka added a comment - I used git log --numstat to find the commits that do not edit CHANGES.txt.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 7s HADOOP-14356 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HADOOP-14356
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865316/HADOOP-14356.patch
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12200/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 7s HADOOP-14356 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-14356 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865316/HADOOP-14356.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12200/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Oh, Updated now..Please review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Oh, Updated now..Please review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 7s HADOOP-14356 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HADOOP-14356
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865326/HADOOP-14356-002.patch
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12201/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 7s HADOOP-14356 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-14356 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865326/HADOOP-14356-002.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12201/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment - - edited

        Would you fix the indent for YARN-3877? I'm +1 if that is addressed.
        In addition, would you rename the patch to HADOOP-14356-branch-2.7-XX.patch to run precommit job for branch-2.7?

        Show
        ajisakaa Akira Ajisaka added a comment - - edited Would you fix the indent for YARN-3877 ? I'm +1 if that is addressed. In addition, would you rename the patch to HADOOP-14356 -branch-2.7-XX.patch to run precommit job for branch-2.7?
        Hide
        shv Konstantin Shvachko added a comment - - edited

        The patch looks good to me as well, modular what Akira Ajisaka said.
        Thanks for tracking this Brahma Reddy Battula.
        May be we should keep it open in case other inconsistencies with CHANGES.txt emerge. Make it the last commit before the release?

        Show
        shv Konstantin Shvachko added a comment - - edited The patch looks good to me as well, modular what Akira Ajisaka said. Thanks for tracking this Brahma Reddy Battula . May be we should keep it open in case other inconsistencies with CHANGES.txt emerge. Make it the last commit before the release?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Akira Ajisaka thanks for review.. Updated the patch.

        Konstantin Shvachko thanks for looking into this issue.

        May be we should keep it open in case other inconsistencies with CHANGES.txt emerge. Make it the last commit before the release?

        As of now, can we commit with this current missed list and track the commits till the release(which I used to do,then there I will try to update,so that every committer will be knowing)?

        Or

        will wait till release,as you mentioned..?

        anything is ok for me.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks for review.. Updated the patch. Konstantin Shvachko thanks for looking into this issue. May be we should keep it open in case other inconsistencies with CHANGES.txt emerge. Make it the last commit before the release? As of now, can we commit with this current missed list and track the commits till the release(which I used to do,then there I will try to update,so that every committer will be knowing)? Or will wait till release,as you mentioned..? anything is ok for me.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 12m 53s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        0 mvndep 0m 17s Maven dependency ordering for branch
        0 mvndep 0m 7s Maven dependency ordering for patch
        -1 whitespace 0m 0s The patch has 438 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        -1 whitespace 0m 10s The patch 16 line(s) with tabs.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        14m 19s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:c420dfe
        JIRA Issue HADOOP-14356
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866841/HADOOP-14356-branch-2.7-003.patch
        Optional Tests asflicense
        uname Linux 27f662bb0d6e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / c7c4108
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12264/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12264/artifact/patchprocess/whitespace-tabs.txt
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project hadoop-yarn-project U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12264/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 53s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 17s Maven dependency ordering for branch 0 mvndep 0m 7s Maven dependency ordering for patch -1 whitespace 0m 0s The patch has 438 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 10s The patch 16 line(s) with tabs. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 14m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HADOOP-14356 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866841/HADOOP-14356-branch-2.7-003.patch Optional Tests asflicense uname Linux 27f662bb0d6e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / c7c4108 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12264/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12264/artifact/patchprocess/whitespace-tabs.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project hadoop-yarn-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12264/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        anything is ok for me.

        agreed.

        Show
        ajisakaa Akira Ajisaka added a comment - anything is ok for me. agreed.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        HI Akira Ajisaka/Konstantin Shvachko

        As we getting closer for branch-2.7.4,we can commit this.. Please let me know,if I missed any jira.

        Show
        brahmareddy Brahma Reddy Battula added a comment - HI Akira Ajisaka / Konstantin Shvachko As we getting closer for branch-2.7.4 ,we can commit this.. Please let me know,if I missed any jira.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 10m 32s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        0 mvndep 0m 33s Maven dependency ordering for branch
        0 mvndep 0m 12s Maven dependency ordering for patch
        -1 whitespace 0m 0s The patch has 592 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        -1 whitespace 0m 14s The patch 16 line(s) with tabs.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        12m 14s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:67e87c9
        JIRA Issue HADOOP-14356
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873272/HADOOP-14356-branch-2.7-004.patch
        Optional Tests asflicense
        uname Linux 6f265f574d27 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / f36da00
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12543/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12543/artifact/patchprocess/whitespace-tabs.txt
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12543/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 32s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 33s Maven dependency ordering for branch 0 mvndep 0m 12s Maven dependency ordering for patch -1 whitespace 0m 0s The patch has 592 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 14s The patch 16 line(s) with tabs. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 12m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:67e87c9 JIRA Issue HADOOP-14356 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12873272/HADOOP-14356-branch-2.7-004.patch Optional Tests asflicense uname Linux 6f265f574d27 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / f36da00 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12543/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/12543/artifact/patchprocess/whitespace-tabs.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project hadoop-mapreduce-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12543/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        shv Konstantin Shvachko added a comment -

        I think we should commit this now. I think we were quite meticulous and I don't know of anything that is missing in CHANGES.txt except this.

        Show
        shv Konstantin Shvachko added a comment - I think we should commit this now. I think we were quite meticulous and I don't know of anything that is missing in CHANGES.txt except this.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Pushed to branch-2.7. Akira Ajisaka and Konstantin Shvachko thanks a lot for your review. hope we did n't miss anything..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Pushed to branch-2.7. Akira Ajisaka and Konstantin Shvachko thanks a lot for your review. hope we did n't miss anything..

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development