[HADOOP-14300] GraphiteSink reports metrics containing undesirable whitespaces

• Type: Bug
• Status: Patch Available
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3
• Component/s: metrics
• Assignee: Damien Claveau
• Reporter: Damien Claveau
• Created: 12/Apr/17 09:08
• Updated: 21/Dec/18 10:34

Description

According to the Graphite documentation, the data sent must be in the following format: <metric path> <metric value> <metric timestamp>

But some tag values that are flattened in the metricpath string sometimes include whitespaces and violate the carbon/graphite format.

For example, the dirpath enumeration from the datanode :
FSDatasetState.org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.Context=FSDatasetState.StorageInfo=FSDataset

{dirpath='[/data/1/hdfs/data/current, /data/2/hdfs/data/current]'}

.Hostname=worker1.Capacity 78436466688 1491986609

Currently, none of the aggregators available in the Graphite ecosystem can handle these malformed metrics. These whitespaces should be replaced by underscores.

I will be happy to attach a small patch.

Issue Links

• relates to: HADOOP-15230 org.apache.hadoop.metrics2.GraphiteSink is not implemented correctly