Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14280

Fix compilation of TestKafkaMetrics

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 3.0.0-alpha4
        • Fix Version/s: 3.0.0-alpha4
        • Component/s: tools
        • Labels:
          None

          Description

          The upgrade to Guava 21 at HADOOP-10101 missed updating this Kafka test.

          1. Text File
            HADOOP-14280.001.patch
            1.0 kB
            Andrew Wang
          2. Text File
            HADOOP-14280.002.patch
            2 kB
            Andrew Wang
          3. Text File
            HADOOP-14280.003.patch
            2 kB
            Andrew Wang

            Issue Links

            is broken by

            Improvement - An improvement or enhancement to an existing feature or task. HADOOP-10101 Update guava dependency to the latest version

            • Major - Major loss of function.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              andrew.wang Andrew Wang added a comment -

              Simple patch attached to fix the Guava issue.

              The hadoop-kafka module sets "maven.test.skip" which means that the code isn't even compiled. This is probably a bug, the intent of the profile was probably to skip test running, but not test compilation.

              Show
              andrew.wang Andrew Wang added a comment - Simple patch attached to fix the Guava issue. The hadoop-kafka module sets "maven.test.skip" which means that the code isn't even compiled. This is probably a bug, the intent of the profile was probably to skip test running, but not test compilation.
              Hide
              Permalink
              andrew.wang Andrew Wang added a comment -

              Spent a little more time to fix the test skipping.

              Show
              andrew.wang Andrew Wang added a comment - Spent a little more time to fix the test skipping.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              +1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 14s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              +1 mvninstall 12m 57s trunk passed
              +1 compile 0m 14s trunk passed
              +1 checkstyle 0m 11s trunk passed
              +1 mvnsite 0m 16s trunk passed
              +1 mvneclipse 0m 13s trunk passed
              +1 findbugs 0m 21s trunk passed
              +1 javadoc 0m 12s trunk passed
              +1 mvninstall 0m 13s the patch passed
              +1 compile 0m 11s the patch passed
              +1 javac 0m 11s the patch passed
              +1 checkstyle 0m 9s the patch passed
              +1 mvnsite 0m 11s the patch passed
              +1 mvneclipse 0m 11s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 findbugs 0m 31s the patch passed
              +1 javadoc 0m 9s the patch passed
              +1 unit 0m 12s hadoop-kafka in the patch passed.
              +1 asflicense 0m 16s The patch does not generate ASF License warnings.
              18m 0s



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:a9ad5d6
              JIRA Issue HADOOP-14280
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862023/HADOOP-14280.001.patch
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
              uname Linux f7a508261c98 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / 9e0e430
              Default Java 1.8.0_121
              findbugs v3.0.0
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12028/testReport/
              modules C: hadoop-tools/hadoop-kafka U: hadoop-tools/hadoop-kafka
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12028/console
              Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 57s trunk passed +1 compile 0m 14s trunk passed +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 16s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 21s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 13s the patch passed +1 compile 0m 11s the patch passed +1 javac 0m 11s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 11s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 0m 12s hadoop-kafka in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 18m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862023/HADOOP-14280.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f7a508261c98 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e0e430 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12028/testReport/ modules C: hadoop-tools/hadoop-kafka U: hadoop-tools/hadoop-kafka Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12028/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              +1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 20s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              +1 mvninstall 14m 23s trunk passed
              +1 compile 0m 13s trunk passed
              +1 checkstyle 0m 13s trunk passed
              +1 mvnsite 0m 13s trunk passed
              +1 mvneclipse 0m 13s trunk passed
              +1 findbugs 0m 22s trunk passed
              +1 javadoc 0m 12s trunk passed
              +1 mvninstall 0m 11s the patch passed
              +1 compile 0m 11s the patch passed
              +1 javac 0m 11s the patch passed
              +1 checkstyle 0m 8s the patch passed
              +1 mvnsite 0m 11s the patch passed
              +1 mvneclipse 0m 9s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 xml 0m 1s The patch has no ill-formed XML file.
              +1 findbugs 0m 23s the patch passed
              +1 javadoc 0m 9s the patch passed
              +1 unit 0m 11s hadoop-kafka in the patch passed.
              +1 asflicense 0m 17s The patch does not generate ASF License warnings.
              19m 18s



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:a9ad5d6
              JIRA Issue HADOOP-14280
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862024/HADOOP-14280.002.patch
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
              uname Linux df1d9b68330c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / 9e0e430
              Default Java 1.8.0_121
              findbugs v3.0.0
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12029/testReport/
              modules C: hadoop-tools/hadoop-kafka U: hadoop-tools/hadoop-kafka
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12029/console
              Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 23s trunk passed +1 compile 0m 13s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 13s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 22s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 11s the patch passed +1 compile 0m 11s the patch passed +1 javac 0m 11s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvnsite 0m 11s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 23s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 0m 11s hadoop-kafka in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 19m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862024/HADOOP-14280.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux df1d9b68330c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e0e430 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12029/testReport/ modules C: hadoop-tools/hadoop-kafka U: hadoop-tools/hadoop-kafka Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12029/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              ajisakaa Akira Ajisaka added a comment -

              +1, thanks Andrew.

              Show
              ajisakaa Akira Ajisaka added a comment - +1, thanks Andrew.
              Hide
              Permalink
              ajisakaa Akira Ajisaka added a comment -

              Cancelling my +1.
              Now TestKafkaMetrics uses mock to simulate Kafka cluster, so the test does not require additional settings via auth-keys.xml. Hi Andrew Wang, would you remove the setting entirely? I'm +1 if that is addressed.

              FYI: TestKafkaMetrics fails. Filed HADOOP-14281 to fix the test.

              Show
              ajisakaa Akira Ajisaka added a comment - Cancelling my +1. Now TestKafkaMetrics uses mock to simulate Kafka cluster, so the test does not require additional settings via auth-keys.xml. Hi Andrew Wang , would you remove the setting entirely? I'm +1 if that is addressed. FYI: TestKafkaMetrics fails. Filed HADOOP-14281 to fix the test.
              Hide
              Permalink
              andrew.wang Andrew Wang added a comment -

              Thanks for the review Akira, patch attached! FWIW the test seems to pass okay for me.

              Show
              andrew.wang Andrew Wang added a comment - Thanks for the review Akira, patch attached! FWIW the test seems to pass okay for me.
              Hide
              Permalink
              hadoopqa Hadoop QA added a comment -
              -1 overall



              Vote Subsystem Runtime Comment
              0 reexec 0m 17s Docker mode activated.
              +1 @author 0m 0s The patch does not contain any @author tags.
              +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              +1 mvninstall 14m 7s trunk passed
              +1 compile 0m 12s trunk passed
              +1 checkstyle 0m 11s trunk passed
              +1 mvnsite 0m 14s trunk passed
              +1 mvneclipse 0m 12s trunk passed
              +1 findbugs 0m 18s trunk passed
              +1 javadoc 0m 12s trunk passed
              +1 mvninstall 0m 12s the patch passed
              +1 compile 0m 11s the patch passed
              +1 javac 0m 11s the patch passed
              +1 checkstyle 0m 8s the patch passed
              +1 mvnsite 0m 12s the patch passed
              +1 mvneclipse 0m 10s the patch passed
              +1 whitespace 0m 0s The patch has no whitespace issues.
              +1 xml 0m 1s The patch has no ill-formed XML file.
              +1 findbugs 0m 23s the patch passed
              +1 javadoc 0m 9s the patch passed
              -1 unit 0m 14s hadoop-kafka in the patch failed.
              +1 asflicense 0m 16s The patch does not generate ASF License warnings.
              19m 5s



              Reason Tests
              Failed junit tests hadoop.metrics2.impl.TestKafkaMetrics



              Subsystem Report/Notes
              Docker Image:yetus/hadoop:a9ad5d6
              JIRA Issue HADOOP-14280
              JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862112/HADOOP-14280.003.patch
              Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
              uname Linux 642f9856b6c3 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
              Build tool maven
              Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
              git revision trunk / 34ab8e7
              Default Java 1.8.0_121
              findbugs v3.0.0
              unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12031/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-kafka.txt
              Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12031/testReport/
              modules C: hadoop-tools/hadoop-kafka U: hadoop-tools/hadoop-kafka
              Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12031/console
              Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

              This message was automatically generated.

              Show
              hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 7s trunk passed +1 compile 0m 12s trunk passed +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 14s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 18s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 12s the patch passed +1 compile 0m 11s the patch passed +1 javac 0m 11s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvnsite 0m 12s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 23s the patch passed +1 javadoc 0m 9s the patch passed -1 unit 0m 14s hadoop-kafka in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 19m 5s Reason Tests Failed junit tests hadoop.metrics2.impl.TestKafkaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14280 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12862112/HADOOP-14280.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 642f9856b6c3 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34ab8e7 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/12031/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-kafka.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/12031/testReport/ modules C: hadoop-tools/hadoop-kafka U: hadoop-tools/hadoop-kafka Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/12031/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
              Hide
              Permalink
              ajisakaa Akira Ajisaka added a comment -

              +1. The test failure will be fixed in HADOOP-14281.

              Show
              ajisakaa Akira Ajisaka added a comment - +1. The test failure will be fixed in HADOOP-14281 .
              Hide
              Permalink
              andrew.wang Andrew Wang added a comment -

              Thanks for the quick review Akira Ajisaka! Committed to trunk.

              Show
              andrew.wang Andrew Wang added a comment - Thanks for the quick review Akira Ajisaka ! Committed to trunk.
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11533 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11533/)
              HADOOP-14280. Fix compilation of TestKafkaMetrics. (wang: rev 7eea8d83fa64268469e24d6b3acde73598d56c7f)

              • (edit) hadoop-tools/hadoop-kafka/pom.xml
              • (edit) hadoop-tools/hadoop-kafka/src/test/java/org/apache/hadoop/metrics2/impl/TestKafkaMetrics.java
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11533 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11533/ ) HADOOP-14280 . Fix compilation of TestKafkaMetrics. (wang: rev 7eea8d83fa64268469e24d6b3acde73598d56c7f) (edit) hadoop-tools/hadoop-kafka/pom.xml (edit) hadoop-tools/hadoop-kafka/src/test/java/org/apache/hadoop/metrics2/impl/TestKafkaMetrics.java
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/)
              HADOOP-14280. Fix compilation of TestKafkaMetrics. (wang: rev 7eea8d83fa64268469e24d6b3acde73598d56c7f)

              • (edit) hadoop-tools/hadoop-kafka/src/test/java/org/apache/hadoop/metrics2/impl/TestKafkaMetrics.java
              • (edit) hadoop-tools/hadoop-kafka/pom.xml
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11591 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11591/ ) HADOOP-14280 . Fix compilation of TestKafkaMetrics. (wang: rev 7eea8d83fa64268469e24d6b3acde73598d56c7f) (edit) hadoop-tools/hadoop-kafka/src/test/java/org/apache/hadoop/metrics2/impl/TestKafkaMetrics.java (edit) hadoop-tools/hadoop-kafka/pom.xml

                People

                • Assignee:
                  andrew.wang Andrew Wang
                  Reporter:
                  andrew.wang Andrew Wang
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development