Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14251

Credential provider should handle property key deprecation

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.2
    • Component/s: security
    • Labels:
      None

      Description

      The properties with old keys stored in a credential store can not be read via the new property keys, even though the old keys have been deprecated.

      1. HADOOP-14251.001.patch
        7 kB
        John Zhuge
      2. HADOOP-14251.002.patch
        6 kB
        John Zhuge
      3. HADOOP-14251.003.patch
        7 kB
        John Zhuge
      4. HADOOP-14251.004.patch
        9 kB
        John Zhuge
      5. HADOOP-14251.005.patch
        9 kB
        John Zhuge

        Issue Links

          Activity

          Hide
          djp Junping Du added a comment -

          Cool. Thanks John Zhuge!

          Show
          djp Junping Du added a comment - Cool. Thanks John Zhuge !
          Hide
          jzhuge John Zhuge added a comment -

          Backported to branch-2.8.2. Thanks for the reminder Junping Du.

          Show
          jzhuge John Zhuge added a comment - Backported to branch-2.8.2. Thanks for the reminder Junping Du .
          Hide
          djp Junping Du added a comment -

          We have branch-2.8.2 open for more than 1 month for all 2.8.2 commits. Can you merge it into branch-2.8.2 given we will close any merge on this branch by the end of today for kicking off RC.

          Show
          djp Junping Du added a comment - We have branch-2.8.2 open for more than 1 month for all 2.8.2 commits. Can you merge it into branch-2.8.2 given we will close any merge on this branch by the end of today for kicking off RC.
          Hide
          jzhuge John Zhuge added a comment -

          It is already backported to branch-2.8.

          Show
          jzhuge John Zhuge added a comment - It is already backported to branch-2.8.
          Hide
          jzhuge John Zhuge added a comment -

          Junping Du +1. Is 2.8.2 still open? If yes, I will backport.

          Show
          jzhuge John Zhuge added a comment - Junping Du +1. Is 2.8.2 still open? If yes, I will backport.
          Hide
          djp Junping Du added a comment -

          Hi John Zhuge, this should be bring into 2.8.2 given HADOOP-14038 is commit to branch-2.8.2. Isn't it?

          Show
          djp Junping Du added a comment - Hi John Zhuge , this should be bring into 2.8.2 given HADOOP-14038 is commit to branch-2.8.2. Isn't it?
          Hide
          jzhuge John Zhuge added a comment -

          Committed to trunk, branch-2, and branch-2.8.

          Thanks Steve Loughran for the review!

          Show
          jzhuge John Zhuge added a comment - Committed to trunk, branch-2, and branch-2.8. Thanks Steve Loughran for the review!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12231 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12231/)
          HADOOP-14251. Credential provider should handle property key (jzhuge: rev 7e6463d2fb5f9383d88baec290461868cf476e4c)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12231 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12231/ ) HADOOP-14251 . Credential provider should handle property key (jzhuge: rev 7e6463d2fb5f9383d88baec290461868cf476e4c) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LGTM

          +1

          nice useful piece of work

          Show
          stevel@apache.org Steve Loughran added a comment - LGTM +1 nice useful piece of work
          Hide
          jzhuge John Zhuge added a comment -

          Hi Steve Loughran, could you please take another look? Really appreciate your help. Sorry for bugging you but this is blocking a few of our internal tests.

          Show
          jzhuge John Zhuge added a comment - Hi Steve Loughran , could you please take another look? Really appreciate your help. Sorry for bugging you but this is blocking a few of our internal tests.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 19m 34s trunk passed
          +1 compile 22m 23s trunk passed
          +1 checkstyle 0m 56s trunk passed
          +1 mvnsite 2m 7s trunk passed
          +1 findbugs 2m 4s trunk passed
          +1 javadoc 1m 6s trunk passed
                Patch Compile Tests
          +1 mvninstall 1m 7s the patch passed
          +1 compile 17m 15s the patch passed
          +1 javac 17m 15s the patch passed
          +1 checkstyle 0m 51s the patch passed
          +1 mvnsite 1m 57s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 30s the patch passed
          +1 javadoc 1m 1s the patch passed
                Other Tests
          -1 unit 9m 5s hadoop-common in the patch failed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          85m 10s



          Reason Tests
          Failed junit tests hadoop.security.TestRaceWhenRelogin



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14251
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882718/HADOOP-14251.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bc666803dc6e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 436c263
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13074/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13074/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13074/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 19m 34s trunk passed +1 compile 22m 23s trunk passed +1 checkstyle 0m 56s trunk passed +1 mvnsite 2m 7s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 6s trunk passed       Patch Compile Tests +1 mvninstall 1m 7s the patch passed +1 compile 17m 15s the patch passed +1 javac 17m 15s the patch passed +1 checkstyle 0m 51s the patch passed +1 mvnsite 1m 57s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 30s the patch passed +1 javadoc 1m 1s the patch passed       Other Tests -1 unit 9m 5s hadoop-common in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 85m 10s Reason Tests Failed junit tests hadoop.security.TestRaceWhenRelogin Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14251 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882718/HADOOP-14251.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bc666803dc6e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 436c263 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13074/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13074/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13074/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Patch 005

          • Fix checkstyle and whitespace
          Show
          jzhuge John Zhuge added a comment - Patch 005 Fix checkstyle and whitespace
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 14m 56s trunk passed
          +1 compile 14m 3s trunk passed
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 1m 37s trunk passed
          +1 findbugs 1m 38s trunk passed
          +1 javadoc 0m 55s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 48s the patch passed
          +1 compile 11m 49s the patch passed
          +1 javac 11m 49s the patch passed
          -0 checkstyle 0m 40s hadoop-common-project/hadoop-common: The patch generated 1 new + 263 unchanged - 0 fixed = 264 total (was 263)
          +1 mvnsite 1m 33s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 0m 52s the patch passed
                Other Tests
          +1 unit 8m 29s hadoop-common in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          62m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14251
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882706/HADOOP-14251.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0b6c7bc24d0a 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 436c263
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13073/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/13073/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13073/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13073/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 56s trunk passed +1 compile 14m 3s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 37s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 0m 55s trunk passed       Patch Compile Tests +1 mvninstall 0m 48s the patch passed +1 compile 11m 49s the patch passed +1 javac 11m 49s the patch passed -0 checkstyle 0m 40s hadoop-common-project/hadoop-common: The patch generated 1 new + 263 unchanged - 0 fixed = 264 total (was 263) +1 mvnsite 1m 33s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 46s the patch passed +1 javadoc 0m 52s the patch passed       Other Tests +1 unit 8m 29s hadoop-common in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 62m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14251 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12882706/HADOOP-14251.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0b6c7bc24d0a 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 436c263 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13073/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/13073/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13073/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13073/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment - - edited

          Patch 004

          • Incorporated the comments.
          Show
          jzhuge John Zhuge added a comment - - edited Patch 004 Incorporated the comments.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I think the credential code could just hand off to the Configuration one; its telling the user off once and only once per process...the origin is moot. All that's needed for the credential API is to list the origin of the key for future diags. Actually, the standard one could maybe do that too, given that provenance is tracked

          Show
          stevel@apache.org Steve Loughran added a comment - I think the credential code could just hand off to the Configuration one; its telling the user off once and only once per process...the origin is moot. All that's needed for the credential API is to list the origin of the key for future diags. Actually, the standard one could maybe do that too, given that provenance is tracked
          Hide
          jzhuge John Zhuge added a comment -

          Ah, I see.
          handleDeprecation guarantees the deprecated property in config file is warned once and only once.
          The deprecated property in credential provider should also be warned once and only once.
          These 2 actions should not interfere with each other.
          Print the url for the credential provider so the user can track down the offender.

          Show
          jzhuge John Zhuge added a comment - Ah, I see. handleDeprecation guarantees the deprecated property in config file is warned once and only once. The deprecated property in credential provider should also be warned once and only once. These 2 actions should not interfere with each other. Print the url for the credential provider so the user can track down the offender.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Not quite yet.

          1. # Looking @ deprecation in a detail I've never done before, I can see that you can actually set a custom deprecation message, built with .DeprecatedKeyInfo.getWarningMessage(). I think we should somehow include that in the generated message, even if we still say it came from a credential provider (maybe also: list its Path?)
          2. Also need to use the{{getAndSetAccessed}} as a guard to printing the warning, so as to stop it reappearing on future reads.
          Show
          stevel@apache.org Steve Loughran added a comment - Not quite yet. # Looking @ deprecation in a detail I've never done before, I can see that you can actually set a custom deprecation message, built with .DeprecatedKeyInfo.getWarningMessage() . I think we should somehow include that in the generated message, even if we still say it came from a credential provider (maybe also: list its Path?) Also need to use the{{getAndSetAccessed}} as a guard to printing the warning, so as to stop it reappearing on future reads.
          Hide
          jzhuge John Zhuge added a comment -

          Steve Loughran Could you please take a look at patch 003?

          Show
          jzhuge John Zhuge added a comment - Steve Loughran Could you please take a look at patch 003?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 14m 6s trunk passed
          +1 compile 13m 56s trunk passed
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 1m 28s trunk passed
          +1 findbugs 1m 24s trunk passed
          +1 javadoc 0m 51s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 39s the patch passed
          +1 compile 10m 38s the patch passed
          +1 javac 10m 38s the patch passed
          +1 checkstyle 0m 39s the patch passed
          +1 mvnsite 1m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 32s the patch passed
          +1 javadoc 0m 51s the patch passed
                Other Tests
          -1 unit 8m 2s hadoop-common in the patch failed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          58m 43s



          Reason Tests
          Failed junit tests hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14251
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881677/HADOOP-14251.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e2ea0940242d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7769e96
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13027/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13027/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13027/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 6s trunk passed +1 compile 13m 56s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 28s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 51s trunk passed       Patch Compile Tests +1 mvninstall 0m 39s the patch passed +1 compile 10m 38s the patch passed +1 javac 10m 38s the patch passed +1 checkstyle 0m 39s the patch passed +1 mvnsite 1m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 51s the patch passed       Other Tests -1 unit 8m 2s hadoop-common in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 58m 43s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14251 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881677/HADOOP-14251.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e2ea0940242d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7769e96 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13027/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13027/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13027/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Good advice Steve Loughran. Patch 003 is attached. Also added code to delete the tmpDir recursively at the end of the 2 unit tests.

          Show
          jzhuge John Zhuge added a comment - Good advice Steve Loughran . Patch 003 is attached. Also added code to delete the tmpDir recursively at the end of the 2 unit tests.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LGTM

          The one change I'd like is that the deprecation messages go to the existing deprecation log under Configuration, [{"org.apache.hadoop.conf.Configuration.deprecation"}}. That way the existing way turn off the noise continues to work everywhere

          Show
          stevel@apache.org Steve Loughran added a comment - LGTM The one change I'd like is that the deprecation messages go to the existing deprecation log under Configuration, [{"org.apache.hadoop.conf.Configuration.deprecation"}}. That way the existing way turn off the noise continues to work everywhere
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 14m 22s trunk passed
          +1 compile 14m 59s trunk passed
          +1 checkstyle 0m 43s trunk passed
          +1 mvnsite 1m 32s trunk passed
          +1 findbugs 1m 35s trunk passed
          +1 javadoc 0m 47s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 39s the patch passed
          +1 compile 11m 8s the patch passed
          +1 javac 11m 8s the patch passed
          +1 checkstyle 0m 39s the patch passed
          +1 mvnsite 1m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 38s the patch passed
          +1 javadoc 0m 50s the patch passed
                Other Tests
          -1 unit 8m 9s hadoop-common in the patch failed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          61m 2s



          Reason Tests
          Failed junit tests hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14251
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881645/HADOOP-14251.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d886722ed96d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7769e96
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13026/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13026/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13026/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 14m 22s trunk passed +1 compile 14m 59s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 32s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 47s trunk passed       Patch Compile Tests +1 mvninstall 0m 39s the patch passed +1 compile 11m 8s the patch passed +1 javac 11m 8s the patch passed +1 checkstyle 0m 39s the patch passed +1 mvnsite 1m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 38s the patch passed +1 javadoc 0m 50s the patch passed       Other Tests -1 unit 8m 9s hadoop-common in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 61m 2s Reason Tests Failed junit tests hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14251 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881645/HADOOP-14251.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d886722ed96d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7769e96 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/13026/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13026/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13026/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Patch 002

          • Fix checkstyle and whitespace
          Show
          jzhuge John Zhuge added a comment - Patch 002 Fix checkstyle and whitespace
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 17m 9s trunk passed
          +1 compile 17m 57s trunk passed
          +1 checkstyle 0m 46s trunk passed
          +1 mvnsite 1m 45s trunk passed
          +1 findbugs 1m 48s trunk passed
          +1 javadoc 1m 1s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 51s the patch passed
          +1 compile 13m 36s the patch passed
          +1 javac 13m 36s the patch passed
          -0 checkstyle 0m 45s hadoop-common-project/hadoop-common: The patch generated 2 new + 263 unchanged - 0 fixed = 265 total (was 263)
          +1 mvnsite 1m 42s the patch passed
          -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 1m 56s the patch passed
          +1 javadoc 1m 0s the patch passed
                Other Tests
          +1 unit 9m 29s hadoop-common in the patch passed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          72m 40s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HADOOP-14251
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881643/HADOOP-14251.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b5f06586c63f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8b242f0
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13025/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/13025/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13025/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13025/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 17m 9s trunk passed +1 compile 17m 57s trunk passed +1 checkstyle 0m 46s trunk passed +1 mvnsite 1m 45s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 1m 1s trunk passed       Patch Compile Tests +1 mvninstall 0m 51s the patch passed +1 compile 13m 36s the patch passed +1 javac 13m 36s the patch passed -0 checkstyle 0m 45s hadoop-common-project/hadoop-common: The patch generated 2 new + 263 unchanged - 0 fixed = 265 total (was 263) +1 mvnsite 1m 42s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 56s the patch passed +1 javadoc 1m 0s the patch passed       Other Tests +1 unit 9m 29s hadoop-common in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 72m 40s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HADOOP-14251 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881643/HADOOP-14251.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b5f06586c63f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8b242f0 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/13025/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/13025/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/13025/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/13025/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Patch 001

          • Handle 2 cases of key deprecation when getting password from credential provider:
            • A deprecated key is stored in a credential provider
            • Call getPassword with a deprecated key
          Show
          jzhuge John Zhuge added a comment - Patch 001 Handle 2 cases of key deprecation when getting password from credential provider: A deprecated key is stored in a credential provider Call getPassword with a deprecated key
          Hide
          stevel@apache.org Steve Loughran added a comment -
          Show
          stevel@apache.org Steve Loughran added a comment - + larry mccay

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              jzhuge John Zhuge
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development