[HADOOP-14211] FilterFs and ChRootedFs are too aggressive about enforcing "authorityNeeded"

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.9.0, 2.7.4, 3.0.0-alpha4, 2.8.2
• Component/s: viewfs
• Assignee: Erik Krogen
• Reporter: Erik Krogen
• Created: 22/Mar/17 00:34
• Updated: 08/Jun/17 00:09
• Resolved: 24/Mar/17 18:14

Description

Right now FilterFs and ChRootedFs pass the following up to the AbstractFileSystem superconstructor:

    super(fs.getUri(), fs.getUri().getScheme(),
        fs.getUri().getAuthority() != null, fs.getUriDefaultPort());

This passes a value of authorityNeeded==true for any fs which has an authority, but this isn't necessarily the case - ViewFS is an example of this. You will encounter this issue if you try to filter a ViewFS, or nest one ViewFS within another. The authorityNeeded check isn't necessary in this case anyway; fs is already an instantiated AbstractFileSystem which means it has already used the same constructor with the value of authorityNeeded (and corresponding validation) that it actually requires.