[HADOOP-14170] FileSystemContractBaseTest is not cleaning up test directory clearly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.6
• Component/s: fs
• Target Version/s: 2.9.0, 3.0.0-alpha4
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 10/Mar/17 02:36
• Updated: 04/Mar/19 11:05
• Resolved: 14/Mar/17 22:07

Description

In FileSystemContractBaseTest::tearDown() method, it cleans up the path("/test") directory, which will be qualified as /test (against root instead of working directory because it's absolute):

  @Override
  protected void tearDown() throws Exception {
    try {
      if (fs != null) {
        fs.delete(path("/test"), true);
      }
    } catch (IOException e) {
      LOG.error("Error deleting /test: " + e, e);
    }
  }

But in the test, it uses path("test") sometimes, which will be made qualified against the working directory (e.g. /user/bob/test).

This makes some tests fail intermittently, e.g. ITestS3AFileSystemContract. Also see the discussion in HADOOP-13934.

Issue Links

• breaks: HADOOP-14192 Aliyun OSS FileSystem contract test should implement getTestBaseDir()
• contains: HADOOP-16160 TestAdlFileSystemContractLive fails in branch-2.8
• is related to: HADOOP-14180 FileSystem contract tests to replace JUnit 3 with 4
• relates to: HADOOP-14036 S3Guard: intermittent duplicate item keys failure