Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: HADOOP-13345
    • Fix Version/s: HADOOP-13345
    • Component/s: fs/s3
    • Labels:
      None

      Description

      Just noticed HADOOP-14020 introduced a bug in S3Guard#dirListingUnion.

      The offending change is here:

      -      if (dirMeta.get(s.getPath()) == null) {
      -        dirMeta.put(s);
      -      }
      +      changed = changed || dirMeta.put(s);
      +    }
      +
      

      hint: Logical OR is a short-circuit operator.
      Easy fix, but should probably come with a unit test for dirListingUnion().

        Attachments

          Activity

            People

            • Assignee:
              fabbri Aaron Fabbri
              Reporter:
              fabbri Aaron Fabbri
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: