Hadoop Common
  1. Hadoop Common
  2. HADOOP-1408

fix warning about cast of Map<String, Map<String, JobInfo>> in jobhistory.jsp

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.14.0
    • Component/s: None
    • Labels:
      None

      Description

      There is a warning where one of the attributes is cast to a map of the proper form. The fix is defining a wrapping class so that the cast is safe.

      1. hadoop-1408.patch
        4 kB
        Owen O'Malley
      2. no-jsp-cast-warn.patch
        4 kB
        Owen O'Malley

        Activity

        Hide
        Owen O'Malley added a comment -

        Creates a class that wraps the generic parameters in a real class that can be checked for at runtime.

        Show
        Owen O'Malley added a comment - Creates a class that wraps the generic parameters in a real class that can be checked for at runtime.
        Show
        Hadoop QA added a comment - +1 http://issues.apache.org/jira/secure/attachment/12357809/no-jsp-cast-warn.patch applied and successfully tested against trunk revision r540973. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/188/testReport/ Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/188/console
        Hide
        Doug Cutting added a comment -

        The new public class needs some javadoc.

        Show
        Doug Cutting added a comment - The new public class needs some javadoc.
        Hide
        Owen O'Malley added a comment -

        Added the relevant javadoc

        Show
        Owen O'Malley added a comment - Added the relevant javadoc
        Hide
        Doug Cutting added a comment -

        I just committed this. The javadoc comment you added was an implementation note, of no interest to the end user. I replaced it with something that describes what the class represents, rather than why it was written. Javadoc is for users.

        Show
        Doug Cutting added a comment - I just committed this. The javadoc comment you added was an implementation note, of no interest to the end user. I replaced it with something that describes what the class represents, rather than why it was written. Javadoc is for users.
        Show
        Hadoop QA added a comment - +1 http://issues.apache.org/jira/secure/attachment/12358023/hadoop-1408.patch applied and successfully tested against trunk revision r541070. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/193/testReport/ Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/193/console
        Hide
        Hadoop QA added a comment -
        Show
        Hadoop QA added a comment - Integrated in Hadoop-Nightly #99 (See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/99/ )

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development