[HADOOP-14028] S3A BlockOutputStreams doesn't delete temporary files in multipart uploads or handle part upload failures

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.8.0, 3.0.0-alpha4
• Component/s: fs/s3

Environment

JDK 8 + ORC 1.3.0 + hadoop-aws 3.0.0-alpha2

• Target Version/s: 2.8.0
• Assignee: Steve Loughran
• Reporter: Seth Fitzsimmons
• Created: 26/Jan/17 22:15
• Updated: 21/Apr/17 21:53
• Resolved: 25/Feb/17 16:17

Description

I have `fs.s3a.fast.upload` enabled with 3.0.0-alpha2 (it's exactly what I was looking for after running into the same OOM problems) and don't see it cleaning up the disk-cached blocks.

I'm generating a ~50GB file on an instance with ~6GB free when the process starts. My expectation is that local copies of the blocks would be deleted after those parts finish uploading, but I'm seeing more than 15 blocks in /tmp (and none of them have been deleted thus far).

I see that DiskBlock deletes temporary files when closed, but is it closed after individual blocks have finished uploading or when the entire file has been fully written to the FS (full upload completed, including all parts)?

As a temporary workaround to avoid running out of space, I'm listing files, sorting by atime, and deleting anything older than the first 20: `ls -ut | tail -n +21 | xargs rm`

Steve Loughran says:

> They should be deleted as soon as the upload completes; the close() call that the AWS httpclient makes on the input stream triggers the deletion. Though there aren't tests for it, as I recall.

Issue Links

• incorporates: HADOOP-14071 S3a: Failed to reset the request input stream
• is broken by: HADOOP-13560 S3ABlockOutputStream to support huge (many GB) file writes
• is depended upon by: HADOOP-11694 Über-jira: S3a phase II: robustness, scale and performance
• is related to: HADOOP-14081 S3A: Consider avoiding array copy in S3ABlockOutputStream (ByteArrayBlock)