Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14017

User friendly name for ADLS user and group

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 2.8.0, 3.0.0-alpha4
    • Component/s: fs/adl
    • Labels:
      None

      Description

      ADLS displays GUID whenever user or group displayed, e.g., ls, getfacl.
      ADLS requires GUID whenever user or group input is needed, e.g., setfacl, chown.

      1. HADOOP-14017.01.patch
        8 kB
        Vishwajeet Dusane
      2. HADOOP-14017.02.patch
        10 kB
        Vishwajeet Dusane
      3. HADOOP-14017.03.patch
        10 kB
        Vishwajeet Dusane

        Activity

        Hide
        jzhuge John Zhuge added a comment -

        Both setfacl and getfacl are supported.

        One issue: names shown as GUID

        $ hdfs dfs -Ddfs.adls.oauth2.access.token.provider.type='ClientCredential' ... -getfacl adl://account.azuredatalakestore.net/file
        # file: adl://account.azuredatalakestore.net/file
        # owner: aaaaaaaa-bbbb-1234-5678-cccccccccccc
        # group: dddddddd-bbbb-3a53-f678-ccccc3cc2ccc
        user::rw-
        group::r--
        other::r--
        

        Another issue: names must be GUID to setfacl

        hdfs dfs -Ddfs.adls.oauth2.access.token.provider.type='ClientCredential' -Dhadoop.security.credential.provider.path=localjceks://file/tmp/creds.jceks -setfacl -m user:foo:rw- adl://account.azuredatalakestore.net/file
        setfacl: Invalid named user or group in <aclStr> : user:foo:rw-. The allowed names are must be a GUID. [a3aa9a0a-0bbb-12f4-5678-cccccccccccc][2017-01-22T11:02:01.2277079-08:00]
        
        Show
        jzhuge John Zhuge added a comment - Both setfacl and getfacl are supported. One issue: names shown as GUID $ hdfs dfs -Ddfs.adls.oauth2.access.token.provider.type='ClientCredential' ... -getfacl adl://account.azuredatalakestore.net/file # file: adl://account.azuredatalakestore.net/file # owner: aaaaaaaa-bbbb-1234-5678-cccccccccccc # group: dddddddd-bbbb-3a53-f678-ccccc3cc2ccc user::rw- group::r-- other::r-- Another issue: names must be GUID to setfacl hdfs dfs -Ddfs.adls.oauth2.access.token.provider.type='ClientCredential' -Dhadoop.security.credential.provider.path=localjceks://file/tmp/creds.jceks -setfacl -m user:foo:rw- adl://account.azuredatalakestore.net/file setfacl: Invalid named user or group in <aclStr> : user:foo:rw-. The allowed names are must be a GUID. [a3aa9a0a-0bbb-12f4-5678-cccccccccccc][2017-01-22T11:02:01.2277079-08:00]
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        Thanks John Zhuge, This is a known limitation and provokes user to configure ACL from Azure portal till the functionality for setfacl and getfacl is available.

        User and group information returned as ListStatus and GetFileStatus is in form of GUID associated in Azure Active Directory.

        However we are already working (Under testing) on supporting user friendly name as a configurable option instead of GUID associated with Azure Active Directory.

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Thanks John Zhuge , This is a known limitation and provokes user to configure ACL from Azure portal till the functionality for setfacl and getfacl is available. User and group information returned as ListStatus and GetFileStatus is in form of GUID associated in Azure Active Directory. However we are already working (Under testing) on supporting user friendly name as a configurable option instead of GUID associated with Azure Active Directory.
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Vishwajeet Dusane for the info.

        Show
        jzhuge John Zhuge added a comment - Thanks Vishwajeet Dusane for the info.
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        Closing this bug since this is known issue and relative change would be available as feature in separate JIRA.

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Closing this bug since this is known issue and relative change would be available as feature in separate JIRA.
        Hide
        jzhuge John Zhuge added a comment -

        IMHO it is still not ideal to display AAD user friendly name. I am looking for an integration with Hadoop users and groups.

        Show
        jzhuge John Zhuge added a comment - IMHO it is still not ideal to display AAD user friendly name. I am looking for an integration with Hadoop users and groups.
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        Support for AAD user friendly name would be required to setfacl or getfacl but not enough for integration with Hadoop U/G. Would you like to file specific JIRA for integration with Hadoop users and groups?

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Support for AAD user friendly name would be required to setfacl or getfacl but not enough for integration with Hadoop U/G. Would you like to file specific JIRA for integration with Hadoop users and groups?
        Hide
        jzhuge John Zhuge added a comment -

        Could we make it possible to display either GUID or user-friendly name? My use case is -ls -i to be introduced by HDFS-10233.

        Show
        jzhuge John Zhuge added a comment - Could we make it possible to display either GUID or user-friendly name? My use case is -ls -i to be introduced by HDFS-10233 .
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        Based on the discussion on the same thread with John Zhuge. Reopening this issue instead of creating new feature request.

        ADLS to support configuration toggle between OID and UPN (User friendly name).

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Based on the discussion on the same thread with John Zhuge . Reopening this issue instead of creating new feature request. ADLS to support configuration toggle between OID and UPN (User friendly name).
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        Added configuration support to return user/group as user friendly name or unique identifier from Azure AD profile (Object ID as GUID).

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Added configuration support to return user/group as user friendly name or unique identifier from Azure AD profile (Object ID as GUID).
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 12m 19s trunk passed
        +1 compile 0m 15s trunk passed
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 16s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 21s trunk passed
        +1 javadoc 0m 11s trunk passed
        +1 mvninstall 0m 12s the patch passed
        +1 compile 0m 12s the patch passed
        +1 javac 0m 12s the patch passed
        +1 checkstyle 0m 9s the patch passed
        +1 mvnsite 0m 14s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 24s the patch passed
        +1 javadoc 0m 9s the patch passed
        +1 unit 3m 27s hadoop-azure-datalake in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        20m 30s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-14017
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12852823/HADOOP-14017.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3d58c9a901d1 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 859bd15
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11631/testReport/
        modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11631/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 19s trunk passed +1 compile 0m 15s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 16s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 21s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 12s the patch passed +1 compile 0m 12s the patch passed +1 javac 0m 12s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 14s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 24s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 3m 27s hadoop-azure-datalake in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 20m 30s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14017 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12852823/HADOOP-14017.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3d58c9a901d1 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 859bd15 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11631/testReport/ modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11631/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Vishwajeet Dusane for working on the issue. I will take a look and try it.

        The patch only support ls and getfacl, do you plan to add support for chown and setfacl?

        Show
        jzhuge John Zhuge added a comment - Thanks Vishwajeet Dusane for working on the issue. I will take a look and try it. The patch only support ls and getfacl , do you plan to add support for chown and setfacl ?
        Hide
        liuml07 Mingliang Liu added a comment - - edited

        The patch only support ls and getfacl, do you plan to add support for chown and setfacl?

        That will be nice to have, though I expect extra work as ADLS sdk is not supporting directly this I guess?

        Show
        liuml07 Mingliang Liu added a comment - - edited The patch only support ls and getfacl, do you plan to add support for chown and setfacl? That will be nice to have, though I expect extra work as ADLS sdk is not supporting directly this I guess?
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        chown and setfacl accepts user and group name as set in Azure AD tenant when run against ADLS FileSystem. The change was required in ADLS store back-end and is available in prod environment now.

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - chown and setfacl accepts user and group name as set in Azure AD tenant when run against ADLS FileSystem . The change was required in ADLS store back-end and is available in prod environment now.
        Hide
        jzhuge John Zhuge added a comment -

        Thank you Vishwajeet Dusane for adding this very nice feature. Tested -ls and -getfacl. Also verified -chown with user name.

        +1 (non-binding) with minor nitpicks below:

        AdlConfKeys

        • #90: Could we add suffix “_KEY” to the key name? Also add a constant ADL_ENABLEUPN_FOR_OWNERGROUP_DEFAULT, default to false

        AdlFileSystem

        • #188: Use ADL_ENABLEUPN_FOR_OWNERGROUP_DEFAULT instead of the literal “false”
        • #189: Add a space after “if”
        • #451: line wrap
        • #762: line wrap after the “=“ on the previous line
        • #977: remove the extra space after “void”

        TestMetadata

        • #21: Unused import org.apache.hadoop.conf.Configuration
        • #26: Unused import org.apache.hadoop.fs.adl.AdlConfKeys

        index.md

        • #225: new line before
        • #243: new line after
        Show
        jzhuge John Zhuge added a comment - Thank you Vishwajeet Dusane for adding this very nice feature. Tested -ls and -getfacl . Also verified -chown with user name. +1 (non-binding) with minor nitpicks below: AdlConfKeys #90: Could we add suffix “_KEY” to the key name? Also add a constant ADL_ENABLEUPN_FOR_OWNERGROUP_DEFAULT, default to false AdlFileSystem #188: Use ADL_ENABLEUPN_FOR_OWNERGROUP_DEFAULT instead of the literal “false” #189: Add a space after “if” #451: line wrap #762: line wrap after the “=“ on the previous line #977: remove the extra space after “void” TestMetadata #21: Unused import org.apache.hadoop.conf.Configuration #26: Unused import org.apache.hadoop.fs.adl.AdlConfKeys index.md #225: new line before #243: new line after
        Hide
        jzhuge John Zhuge added a comment -

        Does chown and setfacl accept both UPN and OID?

        Show
        jzhuge John Zhuge added a comment - Does chown and setfacl accept both UPN and OID?
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -
        • Incorporated comments from John Zhuge.
        • Updated index.md on recommendation to keep adl.feature.ownerandgroup.enableupn as false to avoid performance overhead.
        • Added configuration test to validate adl.feature.ownerandgroup.enableupn configuration and default value.
        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Incorporated comments from John Zhuge . Updated index.md on recommendation to keep adl.feature.ownerandgroup.enableupn as false to avoid performance overhead. Added configuration test to validate adl.feature.ownerandgroup.enableupn configuration and default value.
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        Thanks John Zhuge for the review. Incorporated your comments in patch 02.

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Thanks John Zhuge for the review. Incorporated your comments in patch 02.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 11m 23s trunk passed
        +1 compile 0m 12s trunk passed
        +1 checkstyle 0m 9s trunk passed
        +1 mvnsite 0m 14s trunk passed
        +1 mvneclipse 1m 3s trunk passed
        +1 findbugs 0m 19s trunk passed
        +1 javadoc 0m 9s trunk passed
        +1 mvninstall 0m 11s the patch passed
        +1 compile 0m 10s the patch passed
        +1 javac 0m 10s the patch passed
        +1 checkstyle 0m 7s the patch passed
        +1 mvnsite 0m 11s the patch passed
        +1 mvneclipse 0m 8s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 23s the patch passed
        +1 javadoc 0m 7s the patch passed
        +1 unit 3m 28s hadoop-azure-datalake in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        19m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-14017
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853668/HADOOP-14017.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0533ac079c13 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6ba61d2
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11668/testReport/
        modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11668/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 11m 23s trunk passed +1 compile 0m 12s trunk passed +1 checkstyle 0m 9s trunk passed +1 mvnsite 0m 14s trunk passed +1 mvneclipse 1m 3s trunk passed +1 findbugs 0m 19s trunk passed +1 javadoc 0m 9s trunk passed +1 mvninstall 0m 11s the patch passed +1 compile 0m 10s the patch passed +1 javac 0m 10s the patch passed +1 checkstyle 0m 7s the patch passed +1 mvnsite 0m 11s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 23s the patch passed +1 javadoc 0m 7s the patch passed +1 unit 3m 28s hadoop-azure-datalake in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 19m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14017 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853668/HADOOP-14017.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0533ac079c13 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6ba61d2 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11668/testReport/ modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11668/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        John Zhuge - chown and setfacl accept both UPN and OID.

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - John Zhuge - chown and setfacl accept both UPN and OID.
        Hide
        jzhuge John Zhuge added a comment -

        +1. Rev 02 Looks great! Very few minor nitpicks:

        AdlConfKeys

        • #92: line wrap after “=“ ? This way, the entire string value is on 1 line.

        AdlFileSystem

        • #190-192, #88: Consider “oidOrUpn = enableUPN ? UserGroupRepresentation.UPN : UserGroupRepresentation.OID;” and remove the initializer at #88. What do you think?

        index.md

        • #238-240:
        • Document the default value is false for the sake of performance
        • Mention that setOwner/setAcl accept both UPN and OID
        • Lower case getFileStatus/listStatus/getAclStatus

        BTW, how much is the performance impact when UPN is on?

        Show
        jzhuge John Zhuge added a comment - +1. Rev 02 Looks great! Very few minor nitpicks: AdlConfKeys #92: line wrap after “=“ ? This way, the entire string value is on 1 line. AdlFileSystem #190-192, #88: Consider “oidOrUpn = enableUPN ? UserGroupRepresentation.UPN : UserGroupRepresentation.OID;” and remove the initializer at #88. What do you think? index.md #238-240: Document the default value is false for the sake of performance Mention that setOwner/setAcl accept both UPN and OID Lower case getFileStatus/listStatus/getAclStatus BTW, how much is the performance impact when UPN is on?
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        Thanks for the comment John Zhuge.

        1.

        #190-192, #88: Consider “oidOrUpn = enableUPN ? UserGroupRepresentation.UPN : UserGroupRepresentation.OID;” and remove the initializer at #88. What do you think?

        Are you suggesting?

        private UserGroupRepresentation oidOrUpn;
        ...
        oidOrUpn = enableUPN ? UserGroupRepresentation.UPN : UserGroupRepresentation.OID;
        

        instead of

        private UserGroupRepresentation oidOrUpn = UserGroupRepresentation.OID;
        ...
        if (enableUPN) {
           oidOrUpn = UserGroupRepresentation.UPN;
        }
        

        2.

        Document the default value is false for the sake of performance

        Documentation is already there in patch 02 as

                    When false (default) : User and Group in FileStatus/AclStatus
                    response is represented by the unique identifier from Azure AD
                    profile (Object ID as GUID).
        
                    For performance optimization, Recommended default value.
        

        Please let me know if you had different suggestion?

        3.

        Mention that setOwner/setAcl accept both UPN and OID

        Good point. Will mention in the Features section.

        4. Performance impact depends upon the number of unique user from the retrieved list and if explicit look up is required with Azure AD for name resolution.

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Thanks for the comment John Zhuge . 1. #190-192, #88: Consider “oidOrUpn = enableUPN ? UserGroupRepresentation.UPN : UserGroupRepresentation.OID;” and remove the initializer at #88. What do you think? Are you suggesting? private UserGroupRepresentation oidOrUpn; ... oidOrUpn = enableUPN ? UserGroupRepresentation.UPN : UserGroupRepresentation.OID; instead of private UserGroupRepresentation oidOrUpn = UserGroupRepresentation.OID; ... if (enableUPN) { oidOrUpn = UserGroupRepresentation.UPN; } 2. Document the default value is false for the sake of performance Documentation is already there in patch 02 as When false (default) : User and Group in FileStatus/AclStatus response is represented by the unique identifier from Azure AD profile (Object ID as GUID). For performance optimization, Recommended default value. Please let me know if you had different suggestion? 3. Mention that setOwner/setAcl accept both UPN and OID Good point. Will mention in the Features section. 4. Performance impact depends upon the number of unique user from the retrieved list and if explicit look up is required with Azure AD for name resolution.
        Hide
        jzhuge John Zhuge added a comment -

        1. Yes
        2. It is ok. Sorry I missed it.

        Show
        jzhuge John Zhuge added a comment - 1. Yes 2. It is ok. Sorry I missed it.
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        Minor changes - Incorporated comments from John Zhuge

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Minor changes - Incorporated comments from John Zhuge
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 14m 45s trunk passed
        +1 compile 0m 18s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 19s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 26s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 16s the patch passed
        +1 compile 0m 14s the patch passed
        +1 javac 0m 14s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 16s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 32s the patch passed
        +1 javadoc 0m 11s the patch passed
        +1 unit 3m 35s hadoop-azure-datalake in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        24m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-14017
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853785/HADOOP-14017.03.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1eefe95159d5 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4804050
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11677/testReport/
        modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11677/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 14m 45s trunk passed +1 compile 0m 18s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 16s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 3m 35s hadoop-azure-datalake in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 24m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-14017 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12853785/HADOOP-14017.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1eefe95159d5 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4804050 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11677/testReport/ modules C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11677/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        +1 Rev 03 LGTM

        Show
        jzhuge John Zhuge added a comment - +1 Rev 03 LGTM
        Hide
        liuml07 Mingliang Liu added a comment -

        +1 Will commit shortly.

        Show
        liuml07 Mingliang Liu added a comment - +1 Will commit shortly.
        Hide
        liuml07 Mingliang Liu added a comment -

        I have committed to trunk branch. Thanks Vishwajeet Dusane for your contribution; thanks John Zhuge for your helpful review and comments!

        Show
        liuml07 Mingliang Liu added a comment - I have committed to trunk branch. Thanks Vishwajeet Dusane for your contribution; thanks John Zhuge for your helpful review and comments!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11284 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11284/)
        HADOOP-14017. User friendly name for ADLS user and group. Contributed by (liuml07: rev 924def78544a64449785f305cb6984c3559aea4d)

        • (edit) hadoop-tools/hadoop-azure-datalake/src/main/java/org/apache/hadoop/fs/adl/AdlConfKeys.java
        • (edit) hadoop-tools/hadoop-azure-datalake/src/main/java/org/apache/hadoop/fs/adl/AdlFileSystem.java
        • (edit) hadoop-tools/hadoop-azure-datalake/src/site/markdown/index.md
        • (edit) hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/TestValidateConfiguration.java
        • (edit) hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestMetadata.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11284 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11284/ ) HADOOP-14017 . User friendly name for ADLS user and group. Contributed by (liuml07: rev 924def78544a64449785f305cb6984c3559aea4d) (edit) hadoop-tools/hadoop-azure-datalake/src/main/java/org/apache/hadoop/fs/adl/AdlConfKeys.java (edit) hadoop-tools/hadoop-azure-datalake/src/main/java/org/apache/hadoop/fs/adl/AdlFileSystem.java (edit) hadoop-tools/hadoop-azure-datalake/src/site/markdown/index.md (edit) hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/TestValidateConfiguration.java (edit) hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestMetadata.java
        Hide
        vishwajeet.dusane Vishwajeet Dusane added a comment -

        Thank you Mingliang Liu and John Zhuge.

        Show
        vishwajeet.dusane Vishwajeet Dusane added a comment - Thank you Mingliang Liu and John Zhuge .

          People

          • Assignee:
            vishwajeet.dusane Vishwajeet Dusane
            Reporter:
            jzhuge John Zhuge
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development