Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14003

Make additional KMS tomcat settings configurable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.9.0
    • Component/s: kms
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      <!-- markdown -->

      The KMS can now be configured with the additional environment variables `KMS_PROTOCOL`, `KMS_ACCEPT_COUNT`, and `KMS_ACCEPTOR_THREAD_COUNT`. See `kms-env.sh` for more information about these variables.
      Show
      <!-- markdown --> The KMS can now be configured with the additional environment variables `KMS_PROTOCOL`, `KMS_ACCEPT_COUNT`, and `KMS_ACCEPTOR_THREAD_COUNT`. See `kms-env.sh` for more information about these variables.

      Description

      Doing some Tomcat performance tuning on a loaded cluster, we found that acceptCount, acceptorThreadCount, and protocol can be useful. Let's make these configurable in the kms startup script.

      Since the KMS is Jetty in 3.x, this is targeted at just branch-2.

      1. hadoop-14003.001.patch
        6 kB
        Andrew Wang
      2. hadoop-14003-branch-2.001.patch
        6 kB
        Andrew Wang
      3. HADOOP-14003.branch-2.002.patch
        6 kB
        Xiao Chen
      4. HADOOP-14003.branch-2.003.patch
        6 kB
        Andrew Wang

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for the review and commit Xiao, I've also added a release note.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for the review and commit Xiao, I've also added a release note.
        Hide
        xiaochen Xiao Chen added a comment -

        Committed to branch-2. Thanks, Andrew.

        Do we want a release note?

        Show
        xiaochen Xiao Chen added a comment - Committed to branch-2. Thanks, Andrew. Do we want a release note?
        Hide
        xiaochen Xiao Chen added a comment -

        Config change, no test needed. Manually verified the config takes effect by compiling and starting a KMS locally:
        Jan 26, 2017 11:11:23 AM org.apache.coyote.http11.Http11NioProtocol init v.s. Jan 26, 2017 11:09:34 AM org.apache.coyote.http11.Http11Protocol init

        +1, committing this.

        Show
        xiaochen Xiao Chen added a comment - Config change, no test needed. Manually verified the config takes effect by compiling and starting a KMS locally: Jan 26, 2017 11:11:23 AM org.apache.coyote.http11.Http11NioProtocol init v.s. Jan 26, 2017 11:09:34 AM org.apache.coyote.http11.Http11Protocol init +1, committing this.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 52s branch-2 passed
        +1 compile 5m 56s branch-2 passed with JDK v1.8.0_121
        +1 compile 6m 43s branch-2 passed with JDK v1.7.0_121
        +1 mvnsite 0m 25s branch-2 passed
        +1 mvneclipse 0m 18s branch-2 passed
        +1 javadoc 0m 15s branch-2 passed with JDK v1.8.0_121
        +1 javadoc 0m 16s branch-2 passed with JDK v1.7.0_121
        +1 mvninstall 0m 20s the patch passed
        +1 compile 5m 44s the patch passed with JDK v1.8.0_121
        +1 javac 5m 44s the patch passed
        +1 compile 6m 45s the patch passed with JDK v1.7.0_121
        +1 javac 6m 45s the patch passed
        +1 mvnsite 0m 26s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 shellcheck 0m 8s There were no new shellcheck issues.
        +1 shelldocs 0m 9s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 javadoc 0m 14s the patch passed with JDK v1.8.0_121
        +1 javadoc 0m 17s the patch passed with JDK v1.7.0_121
        +1 unit 1m 45s hadoop-kms in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 26s The patch does not generate ASF License warnings.
        40m 34s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HADOOP-14003
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849383/HADOOP-14003.branch-2.003.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall xml
        uname Linux 9699a5fed566 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / deb3ef4
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        shellcheck v0.4.5
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11513/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11513/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 52s branch-2 passed +1 compile 5m 56s branch-2 passed with JDK v1.8.0_121 +1 compile 6m 43s branch-2 passed with JDK v1.7.0_121 +1 mvnsite 0m 25s branch-2 passed +1 mvneclipse 0m 18s branch-2 passed +1 javadoc 0m 15s branch-2 passed with JDK v1.8.0_121 +1 javadoc 0m 16s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 20s the patch passed +1 compile 5m 44s the patch passed with JDK v1.8.0_121 +1 javac 5m 44s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_121 +1 javac 6m 45s the patch passed +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 18s the patch passed +1 shellcheck 0m 8s There were no new shellcheck issues. +1 shelldocs 0m 9s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 14s the patch passed with JDK v1.8.0_121 +1 javadoc 0m 17s the patch passed with JDK v1.7.0_121 +1 unit 1m 45s hadoop-kms in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 40m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-14003 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849383/HADOOP-14003.branch-2.003.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall xml uname Linux 9699a5fed566 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / deb3ef4 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 shellcheck v0.4.5 JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11513/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11513/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Aforementioned jira reverted from branch-2. kicked jenkins

        Show
        xiaochen Xiao Chen added a comment - Aforementioned jira reverted from branch-2. kicked jenkins
        Hide
        xiaochen Xiao Chen added a comment -

        Good catch Andrew. Patch 3 LGTM.

        jenkins -1 is due to YARN-5641, pinged that jira. +1 pending a new jenkins once that's fixed.

        Show
        xiaochen Xiao Chen added a comment - Good catch Andrew. Patch 3 LGTM. jenkins -1 is due to YARN-5641 , pinged that jira. +1 pending a new jenkins once that's fixed.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        -1 mvninstall 4m 30s root in branch-2 failed.
        +1 compile 6m 50s branch-2 passed with JDK v1.8.0_121
        -1 compile 3m 32s root in branch-2 failed with JDK v1.7.0_121.
        +1 mvnsite 0m 27s branch-2 passed
        +1 mvneclipse 0m 18s branch-2 passed
        +1 javadoc 0m 15s branch-2 passed with JDK v1.8.0_121
        +1 javadoc 0m 18s branch-2 passed with JDK v1.7.0_121
        +1 mvninstall 0m 21s the patch passed
        +1 compile 6m 41s the patch passed with JDK v1.8.0_121
        +1 javac 6m 41s the patch passed
        -1 compile 3m 47s root in the patch failed with JDK v1.7.0_121.
        -1 javac 3m 47s root in the patch failed with JDK v1.7.0_121.
        +1 mvnsite 0m 27s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 shellcheck 0m 8s There were no new shellcheck issues.
        +1 shelldocs 0m 9s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 0m 16s the patch passed with JDK v1.8.0_121
        +1 javadoc 0m 18s the patch passed with JDK v1.7.0_121
        +1 unit 1m 52s hadoop-kms in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        34m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HADOOP-14003
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849383/HADOOP-14003.branch-2.003.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall xml
        uname Linux 2df145db0105 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / b799ea7
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/artifact/patchprocess/branch-mvninstall-root.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/artifact/patchprocess/branch-compile-root-jdk1.7.0_121.txt
        shellcheck v0.4.5
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/artifact/patchprocess/patch-compile-root-jdk1.7.0_121.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/artifact/patchprocess/patch-compile-root-jdk1.7.0_121.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 4m 30s root in branch-2 failed. +1 compile 6m 50s branch-2 passed with JDK v1.8.0_121 -1 compile 3m 32s root in branch-2 failed with JDK v1.7.0_121. +1 mvnsite 0m 27s branch-2 passed +1 mvneclipse 0m 18s branch-2 passed +1 javadoc 0m 15s branch-2 passed with JDK v1.8.0_121 +1 javadoc 0m 18s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 21s the patch passed +1 compile 6m 41s the patch passed with JDK v1.8.0_121 +1 javac 6m 41s the patch passed -1 compile 3m 47s root in the patch failed with JDK v1.7.0_121. -1 javac 3m 47s root in the patch failed with JDK v1.7.0_121. +1 mvnsite 0m 27s the patch passed +1 mvneclipse 0m 18s the patch passed +1 shellcheck 0m 8s There were no new shellcheck issues. +1 shelldocs 0m 9s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 16s the patch passed with JDK v1.8.0_121 +1 javadoc 0m 18s the patch passed with JDK v1.7.0_121 +1 unit 1m 52s hadoop-kms in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 34m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-14003 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849383/HADOOP-14003.branch-2.003.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall xml uname Linux 2df145db0105 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / b799ea7 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/artifact/patchprocess/branch-compile-root-jdk1.7.0_121.txt shellcheck v0.4.5 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/artifact/patchprocess/patch-compile-root-jdk1.7.0_121.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/artifact/patchprocess/patch-compile-root-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11511/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Here's one more rev. I realized that non-1 values of acceptorThreadCount requires the NIO connector, so set the default to 1 and document this.

        Show
        andrew.wang Andrew Wang added a comment - Here's one more rev. I realized that non-1 values of acceptorThreadCount requires the NIO connector, so set the default to 1 and document this.
        Hide
        xiaochen Xiao Chen added a comment -

        Manually tested the configs to work, don't think a unit test is necessary.
        Reviewed Andrew Wang's patch 1 before posting the patch here.

        Show
        xiaochen Xiao Chen added a comment - Manually tested the configs to work, don't think a unit test is necessary. Reviewed Andrew Wang 's patch 1 before posting the patch here.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 16m 48s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 13m 1s branch-2 passed
        +1 compile 6m 16s branch-2 passed with JDK v1.8.0_121
        +1 compile 6m 33s branch-2 passed with JDK v1.7.0_121
        +1 mvnsite 0m 25s branch-2 passed
        +1 mvneclipse 0m 18s branch-2 passed
        +1 javadoc 0m 16s branch-2 passed with JDK v1.8.0_121
        +1 javadoc 0m 14s branch-2 passed with JDK v1.7.0_121
        +1 mvninstall 0m 18s the patch passed
        +1 compile 6m 0s the patch passed with JDK v1.8.0_121
        +1 javac 6m 0s the patch passed
        +1 compile 6m 39s the patch passed with JDK v1.7.0_121
        +1 javac 6m 39s the patch passed
        +1 mvnsite 0m 23s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 shellcheck 0m 8s There were no new shellcheck issues.
        +1 shelldocs 0m 8s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 javadoc 0m 14s the patch passed with JDK v1.8.0_121
        +1 javadoc 0m 59s the patch passed with JDK v1.7.0_121
        +1 unit 3m 10s hadoop-kms in the patch passed with JDK v1.7.0_121.
        +1 asflicense 1m 21s The patch does not generate ASF License warnings.
        69m 5s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HADOOP-14003
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849198/HADOOP-14003.branch-2.002.patch
        Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall xml
        uname Linux c60684641aa9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 8027c3e
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        shellcheck v0.4.5
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11504/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11504/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 16m 48s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 1s branch-2 passed +1 compile 6m 16s branch-2 passed with JDK v1.8.0_121 +1 compile 6m 33s branch-2 passed with JDK v1.7.0_121 +1 mvnsite 0m 25s branch-2 passed +1 mvneclipse 0m 18s branch-2 passed +1 javadoc 0m 16s branch-2 passed with JDK v1.8.0_121 +1 javadoc 0m 14s branch-2 passed with JDK v1.7.0_121 +1 mvninstall 0m 18s the patch passed +1 compile 6m 0s the patch passed with JDK v1.8.0_121 +1 javac 6m 0s the patch passed +1 compile 6m 39s the patch passed with JDK v1.7.0_121 +1 javac 6m 39s the patch passed +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 15s the patch passed +1 shellcheck 0m 8s There were no new shellcheck issues. +1 shelldocs 0m 8s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 14s the patch passed with JDK v1.8.0_121 +1 javadoc 0m 59s the patch passed with JDK v1.7.0_121 +1 unit 3m 10s hadoop-kms in the patch passed with JDK v1.7.0_121. +1 asflicense 1m 21s The patch does not generate ASF License warnings. 69m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-14003 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849198/HADOOP-14003.branch-2.002.patch Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall xml uname Linux c60684641aa9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 8027c3e Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 shellcheck v0.4.5 JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11504/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11504/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks a lot Andrew Wang for the patch!

        Attached a rebase of branch-2, and fixed a bug where kms.sh missed KMS_PROTOCOL.

        Show
        xiaochen Xiao Chen added a comment - Thanks a lot Andrew Wang for the patch! Attached a rebase of branch-2, and fixed a bug where kms.sh missed KMS_PROTOCOL .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 7s HADOOP-14003 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HADOOP-14003
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848452/hadoop-14003-branch-2.001.patch
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11478/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 7s HADOOP-14003 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-14003 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848452/hadoop-14003-branch-2.001.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11478/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        forgot to name it with "branch-2", same patch different name

        Show
        andrew.wang Andrew Wang added a comment - forgot to name it with "branch-2", same patch different name
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s HADOOP-14003 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HADOOP-14003
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848431/hadoop-14003.001.patch
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11476/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HADOOP-14003 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-14003 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848431/hadoop-14003.001.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11476/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Patch attached, did some manual testing. You can check in the /kms/jmx endpoint to validate that tomcat is picking up the configuration settings.

        Show
        andrew.wang Andrew Wang added a comment - Patch attached, did some manual testing. You can check in the /kms/jmx endpoint to validate that tomcat is picking up the configuration settings.

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development