Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-14002

Document -DskipShade property in BUILDING.txt

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha4
    • Component/s: build, documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-13999 added a maven profile to disable client jar shading. This property should be documented in BUILDING.txt.

      1. HADOOP-14002.000.patch
        0.4 kB
        Hanisha Koneru
      2. HADOOP-14002.001.patch
        0.5 kB
        Hanisha Koneru

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11150 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11150/)
        HADOOP-14002. Document -DskipShade property in BUILDING.txt. Contributed (arp: rev 60865c8ea08053f3d6ac23f81c3376a3de3ca996)

        • (edit) BUILDING.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11150 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11150/ ) HADOOP-14002 . Document -DskipShade property in BUILDING.txt. Contributed (arp: rev 60865c8ea08053f3d6ac23f81c3376a3de3ca996) (edit) BUILDING.txt
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the review Arun Suresh. Committed this to trunk.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the review Arun Suresh . Committed this to trunk.
        Hide
        asuresh Arun Suresh added a comment -

        +1 from me too.. Thanks

        Show
        asuresh Arun Suresh added a comment - +1 from me too.. Thanks
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 thanks Hanisha Koneru. Arun Suresh, does this look accurate to you?

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 thanks Hanisha Koneru . Arun Suresh , does this look accurate to you?
        Hide
        hanishakoneru Hanisha Koneru added a comment -

        Thanks Arpit Agarwal and Arun Suresh for reviewing the patch.
        I have addressed your comments in patch v01.

        Show
        hanishakoneru Hanisha Koneru added a comment - Thanks Arpit Agarwal and Arun Suresh for reviewing the patch. I have addressed your comments in patch v01.
        Hide
        asuresh Arun Suresh added a comment -

        Thanks for the patch Hanisha. You should maybe also mention that this should be used only for dev environments to quickly compile the codebase, and should ideally NOT be used when creating a distribution using mvn package -Pdist ..

        Show
        asuresh Arun Suresh added a comment - Thanks for the patch Hanisha. You should maybe also mention that this should be used only for dev environments to quickly compile the codebase, and should ideally NOT be used when creating a distribution using mvn package -Pdist ..
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for documenting this Hanisha Koneru. Can you please add a comment that the option may be used to speed up build times in a development environment and should not be used to build release artifacts.

        Also it can be added it as a bullet point to the Build options section earlier to make it more visible.

         Build options:
        
          * Use -Pnative to compile/bundle native code
          * Use -Pdocs to generate & bundle the documentation in the distribution (using -Pdist)
          * Use -Psrc to create a project source TAR.GZ
          * Use -Dtar to create a TAR with the distribution (using -Pdist)
          * Use -Preleasedocs to include the changelog and release docs (requires Internet connectivity)
          * Use -Pyarn-ui to build YARN UI v2. (Requires Internet connectivity)
        
        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for documenting this Hanisha Koneru . Can you please add a comment that the option may be used to speed up build times in a development environment and should not be used to build release artifacts. Also it can be added it as a bullet point to the Build options section earlier to make it more visible. Build options: * Use -Pnative to compile/bundle native code * Use -Pdocs to generate & bundle the documentation in the distribution (using -Pdist) * Use -Psrc to create a project source TAR.GZ * Use -Dtar to create a TAR with the distribution (using -Pdist) * Use -Preleasedocs to include the changelog and release docs (requires Internet connectivity) * Use -Pyarn-ui to build YARN UI v2. (Requires Internet connectivity)

          People

          • Assignee:
            hanishakoneru Hanisha Koneru
            Reporter:
            hanishakoneru Hanisha Koneru
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development