Found some build issues while doing some test runs with the create-release.sh script.
Fixed two issues:
Allen Wittenauer perchance you can do a quick review?
This message was automatically generated.
I'm having trouble getting a full build to complete due to the gpg-agent timing out while running it in a Docker container on my Mac. Now that the build takes significant longer (YARN UI, shading, and probably some other big, time consumers have been added), we probably need to bump up the TTL too.
I'll play with it some more.
FWIW, I'm also seeing:
This is with "create-release --asfrelease --docker".
At this point, I'm really concerned about the stability of the tree. I've been debating adding a create-release run in the qbt build and it's looking like a better idea more and more.
FWIW I am able to build a release with these changes on my computer, so I'd like to get them in so we can branch and kick off an RC by next week.
If you want to JIRA these other issues, I promise to review promptly.
the TTL increase should be part of this patch given that create-release is the one that sets it.
Sure, here's a new patch which also doubles the gpg agent TTL.
OK, I lazily doubled the ttl and that fixed the signing issues. The other stuff can certainly be done elsewhere.
(FWIW, I'm curious as to what changed that cause the clean to not install the maven plugin prior to executing, but not enough to dig it out.)
I think it might have been related to the SNAPSHOT builds failing when the shading patch first went in. Regardless, it seems like we should follow the instructions in our own BUILDING.txt when building a release.
Thanks for the review, I'll commit this shortly.
Committed to trunk, thanks for the reviews Allen!
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11137 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11137/)
HADOOP-13996. Fix some release build issues. (wang: rev 2bf4c6e2d622570af43f50a5f3738dfe0004b55b)
Hi Andrew Wang and Allen Wittenauer, I share the same pain for agent timeout (2 hours is not enough) in releasing 2.8 on my local Mac. May be we should backport this patch to branch-2 also?
Reopen for jenkins test on branch-2 patch.
Upload patch for branch-2.
Hi Andrew Wang, can you give a quick look? Thx!
LGTM +1, thanks Junping!
I have merged the patch to branch-2 and branch-2.8. Thanks Andrew Wang for delivering the original patch and review!