Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13820

Replace ugi.getUsername() with ugi.getShortUserName() in viewFS

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: viewfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When defaultFS is configured as viewfs –

      <name>fs.defaultFS</name>
      <value>viewfs://CLUSTER/</value>

      List Files showing Realm as User –
      hdfs dfs -ls /
      Found 2 items
      -r-xr-xr-x - hdfs@HADOOP.COM hadoop 0 2016-11-07 15:31 /Dir1
      -r-xr-xr-x - hdfs@HADOOP.COM hadoop 0 2016-11-07 15:31 /Dir2

      1. HADOOP-13820-006.patch
        9 kB
        Brahma Reddy Battula
      2. HADOOP-13820-005.patch
        9 kB
        Brahma Reddy Battula
      3. HADOOP-13820-004.patch
        9 kB
        Brahma Reddy Battula
      4. HADOOP-13820-003.patch
        8 kB
        Brahma Reddy Battula
      5. HADOOP-13820-002.patch
        8 kB
        Brahma Reddy Battula
      6. HADOOP-13820.patch
        1 kB
        Brahma Reddy Battula

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10893 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10893/)
        HADOOP-13820. Replace ugi.getUsername() with ugi.getShortUserName() in (brahma: rev ee3d437a33c2106ea416078e722ff6184106a0bc)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
        • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10893 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10893/ ) HADOOP-13820 . Replace ugi.getUsername() with ugi.getShortUserName() in (brahma: rev ee3d437a33c2106ea416078e722ff6184106a0bc) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        My late +1. Thanks Brahma for updating the patch and committing it.

        Show
        ajisakaa Akira Ajisaka added a comment - My late +1. Thanks Brahma for updating the patch and committing it.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk,branch-2 and branch-2.8.
        Archana T thanks for reporting and thanks to Akira Ajisaka and Manoj Govindassamy for review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2 and branch-2.8. Archana T thanks for reporting and thanks to Akira Ajisaka and Manoj Govindassamy for review..
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 44s trunk passed
        +1 compile 9m 38s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 47s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 9m 13s the patch passed
        +1 javac 9m 13s the patch passed
        +1 checkstyle 0m 32s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 32s the patch passed
        +1 javadoc 0m 48s the patch passed
        +1 unit 8m 23s hadoop-common in the patch passed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        45m 25s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13820
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840506/HADOOP-13820-006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 24496d577643 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / bb1b5e0
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11139/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11139/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 9m 38s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 9m 13s the patch passed +1 javac 9m 13s the patch passed +1 checkstyle 0m 32s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 48s the patch passed +1 unit 8m 23s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 45m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13820 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840506/HADOOP-13820-006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 24496d577643 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bb1b5e0 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11139/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11139/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch address above comment.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch address above comment.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Brahma Reddy Battula for updating the patch.

        ViewFileSystemBaseTest.java,ViewFsBaseTest.java
              public Object run() throws IOException {
        

        One minor nit: Would you add @Override annotation to the run methods? I'm +1 if that is addressed.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for updating the patch. ViewFileSystemBaseTest.java,ViewFsBaseTest.java public Object run() throws IOException { One minor nit: Would you add @Override annotation to the run methods? I'm +1 if that is addressed.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 47s trunk passed
        +1 compile 9m 32s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 26s trunk passed
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 9m 10s the patch passed
        +1 javac 9m 10s the patch passed
        -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 1 new + 256 unchanged - 0 fixed = 257 total (was 256)
        +1 mvnsite 1m 2s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 33s the patch passed
        +1 javadoc 0m 49s the patch passed
        +1 unit 8m 23s hadoop-common in the patch passed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        45m 23s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13820
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840487/HADOOP-13820-005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6b6f91be4fda 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 636f754
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11138/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11138/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11138/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 9m 32s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 26s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 9m 10s the patch passed +1 javac 9m 10s the patch passed -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 1 new + 256 unchanged - 0 fixed = 257 total (was 256) +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 8m 23s hadoop-common in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 45m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13820 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840487/HADOOP-13820-005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6b6f91be4fda 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 636f754 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11138/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11138/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11138/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Rebased patch..Akira Ajisaka thanks for your review..checkstyle also addressed.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Rebased patch.. Akira Ajisaka thanks for your review..checkstyle also addressed.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Mostly looks good to me. Hi Brahma Reddy Battula, would you rebase the patch and fix the checkstyle warning?

        Show
        ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. Hi Brahma Reddy Battula , would you rebase the patch and fix the checkstyle warning?
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 1s trunk passed
        +1 compile 9m 31s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 0m 47s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 9m 11s the patch passed
        +1 javac 9m 11s the patch passed
        -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 1 new + 257 unchanged - 0 fixed = 258 total (was 257)
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 33s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 8m 21s hadoop-common in the patch passed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        45m 35s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13820
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839748/HADOOP-13820-004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 52c8f4a16159 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c65d6b6
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11105/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11105/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11105/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 1s trunk passed +1 compile 9m 31s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 1m 24s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 9m 11s the patch passed +1 javac 9m 11s the patch passed -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 1 new + 257 unchanged - 0 fixed = 258 total (was 257) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 8m 21s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 45m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13820 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839748/HADOOP-13820-004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 52c8f4a16159 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c65d6b6 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11105/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11105/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11105/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        To go beyond trunk made UserGroupInformation as final and updated getFileLinkStatus also which was using ugi.getUsername.

        Manoj Govindassamy thanks for your +1.To commit this I need to wait for committer +1..

        Show
        brahmareddy Brahma Reddy Battula added a comment - To go beyond trunk made UserGroupInformation as final and updated getFileLinkStatus also which was using ugi.getUsername . Manoj Govindassamy thanks for your +1.To commit this I need to wait for committer +1..
        Hide
        manojg Manoj Govindassamy added a comment -

        Thanks Brahma Reddy Battula. Changes in HADOOP-13820-003.patch look good to me. +1 (non-binding)

        Show
        manojg Manoj Govindassamy added a comment - Thanks Brahma Reddy Battula . Changes in HADOOP-13820-003.patch look good to me. +1 (non-binding)
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 8m 59s trunk passed
        +1 compile 11m 24s trunk passed
        +1 checkstyle 0m 33s trunk passed
        +1 mvnsite 1m 8s trunk passed
        +1 mvneclipse 0m 20s trunk passed
        +1 findbugs 1m 49s trunk passed
        +1 javadoc 0m 49s trunk passed
        +1 mvninstall 0m 43s the patch passed
        +1 compile 10m 49s the patch passed
        +1 javac 10m 49s the patch passed
        -0 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 1 new + 257 unchanged - 0 fixed = 258 total (was 257)
        +1 mvnsite 1m 3s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 0m 52s the patch passed
        +1 unit 8m 59s hadoop-common in the patch passed.
        +1 asflicense 0m 34s The patch does not generate ASF License warnings.
        52m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13820
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839388/HADOOP-13820-003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4f7f9ba42010 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b2d4b7b
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11091/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11091/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11091/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 59s trunk passed +1 compile 11m 24s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 20s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 49s trunk passed +1 mvninstall 0m 43s the patch passed +1 compile 10m 49s the patch passed +1 javac 10m 49s the patch passed -0 checkstyle 0m 36s hadoop-common-project/hadoop-common: The patch generated 1 new + 257 unchanged - 0 fixed = 258 total (was 257) +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 52s the patch passed +1 unit 8m 59s hadoop-common in the patch passed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 52m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13820 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839388/HADOOP-13820-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4f7f9ba42010 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b2d4b7b Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11091/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11091/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11091/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch to Fix the checkstyle issues.lat one can be ignored.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch to Fix the checkstyle issues.lat one can be ignored.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 46s trunk passed
        +1 compile 9m 29s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 1m 23s trunk passed
        +1 javadoc 0m 47s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 9m 10s the patch passed
        +1 javac 9m 10s the patch passed
        -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 4 new + 257 unchanged - 0 fixed = 261 total (was 257)
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 34s the patch passed
        +1 javadoc 0m 46s the patch passed
        +1 unit 8m 21s hadoop-common in the patch passed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        45m 9s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13820
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839362/HADOOP-13820-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7565b5aff3f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / aab9737
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11088/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11088/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11088/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 46s trunk passed +1 compile 9m 29s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 10s the patch passed +1 javac 9m 10s the patch passed -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 4 new + 257 unchanged - 0 fixed = 261 total (was 257) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 34s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 8m 21s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 45m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13820 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839362/HADOOP-13820-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7565b5aff3f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / aab9737 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11088/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11088/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11088/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Manoj Govindassamy thanks for taking look..
        Uploaded patch to address your comments and replaced remaining places also..

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Manoj Govindassamy thanks for taking look.. Uploaded patch to address your comments and replaced remaining places also..
        Hide
        manojg Manoj Govindassamy added a comment -

        Archana T, Brahma Reddy Battula,

        1. hadoop fs -stat "%F %u:%g %b %y %n" /Dir1 might also have the same problem. Please verify. If so, a similar fix might be needed for #getFileStatus also.
        2. So far, ViewFileSystem has been very identical to the FileContext ViewFs. So, should we also fix ViewFs#InternalDirOfViewFs#listStatus ?
        Show
        manojg Manoj Govindassamy added a comment - Archana T , Brahma Reddy Battula , hadoop fs -stat "%F %u:%g %b %y %n" /Dir1 might also have the same problem. Please verify. If so, a similar fix might be needed for #getFileStatus also. So far, ViewFileSystem has been very identical to the FileContext ViewFs . So, should we also fix ViewFs#InternalDirOfViewFs#listStatus ?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 42s trunk passed
        +1 compile 9m 30s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 25s trunk passed
        +1 javadoc 0m 46s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 9m 6s the patch passed
        +1 javac 9m 6s the patch passed
        +1 checkstyle 0m 29s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 33s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 8m 19s hadoop-common in the patch passed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        44m 54s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-13820
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839157/HADOOP-13820.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f2894b235aab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d656035
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11077/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11077/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 42s trunk passed +1 compile 9m 30s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 9m 6s the patch passed +1 javac 9m 6s the patch passed +1 checkstyle 0m 29s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 8m 19s hadoop-common in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 44m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13820 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839157/HADOOP-13820.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f2894b235aab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d656035 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11077/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11077/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch..Kindly Review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch..Kindly Review.

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            archanat Archana T
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development