Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13815

TestKMS#testDelegationTokensOpsSimple and TestKMS#testDelegationTokensOpsKerberized Fails in Trunk

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Expected to find 'tries to renew a token with renewer' but got unexpected exception:java.io.IOException: HTTP status [403], message [org.apache.hadoop.security.AccessControlException: client tries to renew a token (kms-dt owner=client, renewer=client1, realUser=, issueDate=1479025952525, maxDate=1479630752525, sequenceNumber=1, masterKeyId=2) with non-matching renewer client1]
       at org.apache.hadoop.util.HttpExceptionUtils.validateResponse(HttpExceptionUtils.java:169)
       at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticator.doDelegationTokenOperation(DelegationTokenAuthenticator.java:300)
       at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticator.renewDelegationToken(DelegationTokenAuthenticator.java:216)
       at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticatedURL.renewDelegationToken(DelegationTokenAuthenticatedURL.java:415)
       at org.apache.hadoop.crypto.key.kms.KMSClientProvider$2.run(KMSClientProvider.java:906)
       at org.apache.hadoop.crypto.key.kms.KMSClientProvider$2.run(KMSClientProvider.java:903)
       at java.security.AccessController.doPrivileged(Native Method)
       at javax.security.auth.Subject.doAs(Subject.java:422)
       at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1857)
       at org.apache.hadoop.crypto.key.kms.KMSClientProvider.renewDelegationToken(KMSClientProvider.java:902)
       at org.apache.hadoop.crypto.key.kms.KMSClientProvider$KMSTokenRenewer.renew(KMSClientProvider.java:183)
       at org.apache.hadoop.security.token.Token.renew(Token.java:490)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS$14$1.run(TestKMS.java:1820)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS$14$1.run(TestKMS.java:1793)
       at java.security.AccessController.doPrivileged(Native Method)
       at javax.security.auth.Subject.doAs(Subject.java:422)
       at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1857)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS.doAs(TestKMS.java:292)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS.access$100(TestKMS.java:80)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS$14.call(TestKMS.java:1793)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS$14.call(TestKMS.java:1785)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS.runServer(TestKMS.java:140)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS.runServer(TestKMS.java:122)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS.testDelegationTokensOps(TestKMS.java:1785)
       at org.apache.hadoop.crypto.key.kms.server.TestKMS.testDelegationTokensOpsKerberized(TestKMS.java:1768)
      

      Reference:

      https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/224/testReport/junit/

      1. HADOOP-13815.01.patch
        0.8 kB
        Xiao Chen
      2. HADOOP-13815.02.patch
        0.8 kB
        Xiao Chen
      3. HADOOP-13815.03.patch
        1 kB
        Xiao Chen

        Issue Links

          Activity

          Hide
          xiaochen Xiao Chen added a comment -

          Thanks for reporting this Brahma Reddy Battula!

          Looks like HADOOP-13720 broke this. Attaching a patch to fix it.

          Show
          xiaochen Xiao Chen added a comment - Thanks for reporting this Brahma Reddy Battula ! Looks like HADOOP-13720 broke this. Attaching a patch to fix it.
          Hide
          xiaochen Xiao Chen added a comment -

          Patch 1 to loose the exception message check. Yongjun Zhang, could you please take a look?

          Show
          xiaochen Xiao Chen added a comment - Patch 1 to loose the exception message check. Yongjun Zhang , could you please take a look?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 5s trunk passed
          +1 compile 9m 32s trunk passed
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 24s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 16s trunk passed
          +1 mvninstall 0m 16s the patch passed
          +1 compile 9m 11s the patch passed
          +1 javac 9m 11s the patch passed
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 0m 24s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 35s the patch passed
          +1 javadoc 0m 17s the patch passed
          +1 unit 2m 10s hadoop-kms in the patch passed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          34m 10s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13815
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838889/HADOOP-13815.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f4f6435a22c3 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 99c2bbd
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11064/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11064/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 5s trunk passed +1 compile 9m 32s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 16s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 9m 11s the patch passed +1 javac 9m 11s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 35s the patch passed +1 javadoc 0m 17s the patch passed +1 unit 2m 10s hadoop-kms in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 34m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13815 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838889/HADOOP-13815.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f4f6435a22c3 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99c2bbd Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11064/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11064/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Xiao Chen thanks for quick patch.

          How about fixing like below..?

          catch (IOException e) {
                          GenericTestUtils.assertExceptionContains(
                              "tries to renew a token ("+ token.decodeIdentifier()+")", e);
                        }
          

          Looks like HADOOP-13720 broke this.

          Pre-commit of HADOOP-13720 did n't catch two failures ( HADOOP-13813 and this) because both are from different projects (HDFS and KMS). And while are running tests,we do like below..Could have been avoided,if we run on dependent projects.

          May be we can cd to parent project and run tests such that we can get impact earlier( i.e hadoop-common project should include KMS).

          ============================================================================
          ============================================================================
                                      Running unit tests
          ============================================================================
          ============================================================================
          
          
          cd /testptch/hadoop/hadoop-common-project/hadoop-common
          mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-trunk-patch-0 -Ptest-patch -Pparallel-tests -P!shelltest -Pnative -Drequire.libwebhdfs -Drequire.snappy -Drequire.openssl -Drequire.fuse -Drequire.test.libhadoop -Pyarn-ui clean test -fae > /testptch/hadoop/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt 2>&1
          Elapsed:   8m 21s
          
          hadoop-common in the patch passed.
          
          Show
          brahmareddy Brahma Reddy Battula added a comment - Xiao Chen thanks for quick patch. How about fixing like below..? catch (IOException e) { GenericTestUtils.assertExceptionContains( "tries to renew a token (" + token.decodeIdentifier()+ ")" , e); } Looks like HADOOP-13720 broke this. Pre-commit of HADOOP-13720 did n't catch two failures ( HADOOP-13813 and this) because both are from different projects (HDFS and KMS). And while are running tests,we do like below..Could have been avoided,if we run on dependent projects. May be we can cd to parent project and run tests such that we can get impact earlier( i.e hadoop-common project should include KMS). ============================================================================ ============================================================================ Running unit tests ============================================================================ ============================================================================ cd /testptch/hadoop/hadoop-common-project/hadoop-common mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-trunk-patch-0 -Ptest-patch -Pparallel-tests -P!shelltest -Pnative -Drequire.libwebhdfs -Drequire.snappy -Drequire.openssl -Drequire.fuse -Drequire.test.libhadoop -Pyarn-ui clean test -fae > /testptch/hadoop/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt 2>&1 Elapsed: 8m 21s hadoop-common in the patch passed.
          Hide
          xiaochen Xiao Chen added a comment -

          Hi Brahma Reddy Battula,

          I didn't add the token itself to assertion because I think the test here is just verifying the renew action failed with another renewer. What the token decodes to is a bit irrelevant. Also understand your concern as there may be other 'tries to renew a token' instances, so changed to a more unique text in patch 2. What do you think?

          About running tests... sorry for breaking this of course. I think that's a pain point now. Even if we manually run hadoop-common, the hdfs one in HADOOP-13813 is still missing.... The only way I think would be to do a full unit-test run. We should keep in mind of this in the future, so when a hadoop-common change touches some basic things, we should diligently run a full test.
          Since yarn also uses delegation tokens, I suggest to have a full run anyway to be sure. Yongjun Zhang, would you be able to do that?

          Show
          xiaochen Xiao Chen added a comment - Hi Brahma Reddy Battula , I didn't add the token itself to assertion because I think the test here is just verifying the renew action failed with another renewer. What the token decodes to is a bit irrelevant. Also understand your concern as there may be other 'tries to renew a token' instances, so changed to a more unique text in patch 2. What do you think? About running tests... sorry for breaking this of course. I think that's a pain point now. Even if we manually run hadoop-common, the hdfs one in HADOOP-13813 is still missing.... The only way I think would be to do a full unit-test run. We should keep in mind of this in the future, so when a hadoop-common change touches some basic things, we should diligently run a full test. Since yarn also uses delegation tokens, I suggest to have a full run anyway to be sure. Yongjun Zhang , would you be able to do that?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 41s trunk passed
          +1 compile 9m 30s trunk passed
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 24s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 18s trunk passed
          +1 mvninstall 0m 16s the patch passed
          +1 compile 9m 45s the patch passed
          +1 javac 9m 45s the patch passed
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 0m 24s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 36s the patch passed
          +1 javadoc 0m 17s the patch passed
          +1 unit 2m 10s hadoop-kms in the patch passed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          34m 37s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13815
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838918/HADOOP-13815.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 77f1be7ec3c3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 04014c4
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11065/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11065/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 41s trunk passed +1 compile 9m 30s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 18s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 9m 45s the patch passed +1 javac 9m 45s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 36s the patch passed +1 javadoc 0m 17s the patch passed +1 unit 2m 10s hadoop-kms in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 34m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13815 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838918/HADOOP-13815.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 77f1be7ec3c3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 04014c4 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11065/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11065/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Brahma Reddy Battula for reporting the issue and Xiao Chen for working on this.
          As an alternative, we can keep the original verification by decoding the KMS DT identifier like below. I've tested that both failure cases passed with the change below.

                         } catch (Exception e) {
          +                byte[] tokenId = token.getIdentifier();
          +                DelegationTokenIdentifier identifier =
          +                    new DelegationTokenIdentifier(KMSDelegationToken.TOKEN_KIND);
          +                identifier.readFields(new DataInputStream(
          +                        new ByteArrayInputStream(tokenId)));
          +
                           GenericTestUtils.assertExceptionContains(
          -                    "tries to renew a token with renewer", e);
          +                    "tries to renew a token (" + identifier + ")", e);
                         }
          
          Show
          xyao Xiaoyu Yao added a comment - Thanks Brahma Reddy Battula for reporting the issue and Xiao Chen for working on this. As an alternative, we can keep the original verification by decoding the KMS DT identifier like below. I've tested that both failure cases passed with the change below. } catch (Exception e) { + byte [] tokenId = token.getIdentifier(); + DelegationTokenIdentifier identifier = + new DelegationTokenIdentifier(KMSDelegationToken.TOKEN_KIND); + identifier.readFields( new DataInputStream( + new ByteArrayInputStream(tokenId))); + GenericTestUtils.assertExceptionContains( - "tries to renew a token with renewer" , e); + "tries to renew a token (" + identifier + ")" , e); }
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Xiaoyu Yao for the review.

          My initial argument is that we just want to assert the exception is failed for token renewal, and details of that token doesn't matter. But seems both you and Brahma lean on that direction, so I concede. Patch 3 to verify the token too.

          Show
          xiaochen Xiao Chen added a comment - Thanks Xiaoyu Yao for the review. My initial argument is that we just want to assert the exception is failed for token renewal, and details of that token doesn't matter. But seems both you and Brahma lean on that direction, so I concede. Patch 3 to verify the token too.
          Hide
          xiaochen Xiao Chen added a comment -

          Searching a little more, found there's a failure in yarn as well. While still planning to run a full test, let's get these fixed first. If you feel we should get a yarn jira for that fix, I'm okay to go with patch 3 too.

          Thanks for the reviews!

          Show
          xiaochen Xiao Chen added a comment - Searching a little more, found there's a failure in yarn as well. While still planning to run a full test, let's get these fixed first. If you feel we should get a yarn jira for that fix, I'm okay to go with patch 3 too. Thanks for the reviews!
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Xiao Chen for updating the patch. +1 for patch v3 pending Jenkins.
          Let's open a separate ticket for the YARN fix.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Xiao Chen for updating the patch. +1 for patch v3 pending Jenkins. Let's open a separate ticket for the YARN fix.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Xiaoyu for the prompt response. Found out YARN-5875 fixed the YARN bug.

          Show
          xiaochen Xiao Chen added a comment - Thanks Xiaoyu for the prompt response. Found out YARN-5875 fixed the YARN bug.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 6m 41s trunk passed
          +1 compile 9m 28s trunk passed
          +1 checkstyle 1m 34s trunk passed
          +1 mvnsite 1m 10s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 1m 36s trunk passed
          +1 javadoc 0m 48s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 0m 53s the patch passed
          +1 compile 9m 31s the patch passed
          +1 javac 9m 31s the patch passed
          +1 checkstyle 1m 39s the patch passed
          +1 mvnsite 1m 17s the patch passed
          +1 mvneclipse 0m 49s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 58s the patch passed
          +1 javadoc 0m 57s the patch passed
          +1 unit 2m 20s hadoop-kms in the patch passed.
          -1 unit 39m 2s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 36s The patch does not generate ASF License warnings.
          105m 25s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestNodeBlacklistingOnAMFailures



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13815
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839047/HADOOP-13815.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 866e5d99a59e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 264ddb1
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11069/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11069/testReport/
          modules C: hadoop-common-project/hadoop-kms hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11069/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 41s trunk passed +1 compile 9m 28s trunk passed +1 checkstyle 1m 34s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 0m 48s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 0m 53s the patch passed +1 compile 9m 31s the patch passed +1 javac 9m 31s the patch passed +1 checkstyle 1m 39s the patch passed +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 49s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 57s the patch passed +1 unit 2m 20s hadoop-kms in the patch passed. -1 unit 39m 2s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 105m 25s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestNodeBlacklistingOnAMFailures Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13815 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839047/HADOOP-13815.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 866e5d99a59e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 264ddb1 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11069/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11069/testReport/ modules C: hadoop-common-project/hadoop-kms hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11069/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Hm, patch 3 got skipped by jenkins. Just triggered a new run.

          Show
          xiaochen Xiao Chen added a comment - Hm, patch 3 got skipped by jenkins. Just triggered a new run.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 23s trunk passed
          +1 compile 11m 18s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 27s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 17s trunk passed
          +1 mvninstall 0m 18s the patch passed
          +1 compile 11m 3s the patch passed
          +1 javac 11m 3s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 24s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 33s the patch passed
          +1 javadoc 0m 16s the patch passed
          +1 unit 2m 9s hadoop-kms in the patch passed.
          +1 asflicense 0m 32s The patch does not generate ASF License warnings.
          39m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-13815
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839046/HADOOP-13815.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8d005da7073d 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f121d0b
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11073/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11073/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 23s trunk passed +1 compile 11m 18s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 27s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 17s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 11m 3s the patch passed +1 javac 11m 3s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 33s the patch passed +1 javadoc 0m 16s the patch passed +1 unit 2m 9s hadoop-kms in the patch passed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 39m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-13815 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839046/HADOOP-13815.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8d005da7073d 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f121d0b Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11073/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11073/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Committed to trunk, branch-2 and branch-2.8. Thanks Brahma Reddy Battula for reporting the issue and review. Also thanks Xiaoyu Yao for the reviews.

          I've gone through trunk nightlies and didn't find anything else broken besides YARN-5875. Also appreciate John Zhuge on his help running some tests.

          Show
          xiaochen Xiao Chen added a comment - Committed to trunk, branch-2 and branch-2.8. Thanks Brahma Reddy Battula for reporting the issue and review. Also thanks Xiaoyu Yao for the reviews. I've gone through trunk nightlies and didn't find anything else broken besides YARN-5875 . Also appreciate John Zhuge on his help running some tests.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10843 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10843/)
          HADOOP-13815. TestKMS#testDelegationTokensOpsSimple and (xiao: rev 61c0bedf775e6e794d4704485ec2c41a95aecae9)

          • (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10843 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10843/ ) HADOOP-13815 . TestKMS#testDelegationTokensOpsSimple and (xiao: rev 61c0bedf775e6e794d4704485ec2c41a95aecae9) (edit) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java

            People

            • Assignee:
              xiaochen Xiao Chen
              Reporter:
              brahmareddy Brahma Reddy Battula
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development