Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13802

Make generic options help more consistent, and aligned

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      The generic options have always been this:

      Generic options supported are
      -conf <configuration file>     specify an application configuration file
      -D <property=value>            use value for given property
      -fs <local|namenode:port>      specify a namenode
      -jt <local|resourcemanager:port>    specify a ResourceManager
      -files <comma separated list of files>    specify comma separated files to be copied to the map reduce cluster
      -libjars <comma separated list of jars>    specify comma separated jar files to include in the classpath.
      -archives <comma separated list of archives>    specify comma separated archives to be unarchived on the compute machines.
      
      The general command line syntax is
      bin/hadoop command [genericOptions] [commandOptions]
      

      However, almost all the hadoop command help follow an unwritten style which is similar to man page descriptions.
      This is the proposed improvement.

      Generic options supported are:
      -conf <configuration file>     specify an application configuration file
      -D <property=value>            define a value for given property
      -fs <local|namenode:port>      specify a namenode
      -jt <local|jobtracker:port>    specify a job tracker
      -files <file1,...>             specify a comma-separated list of files to be copied to the map reduce cluster
      -libjars <jar1,...>            specify a comma-separated list of jar files to be included in the classpath
      -archives <archive1,...>       specify a comma-separated list of archives to be unarchived on the compute machines
      
      1. HADOOP-13802.1.patch
        3 kB
        Grant Sohn
      2. HADOOP-13802.2.patch
        2 kB
        Grant Sohn
      3. HADOOP-13802.3.patch
        3 kB
        Grant Sohn
      4. HADOOP-13802.4.patch
        3 kB
        Mingliang Liu

        Issue Links

          Activity

          Hide
          gsohn Grant Sohn added a comment -

          Mingliang Liu, thanks for your help getting this in.

          Show
          gsohn Grant Sohn added a comment - Mingliang Liu , thanks for your help getting this in.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10792 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10792/)
          HADOOP-13802. Make generic options help more consistent, and aligned. (liuml07: rev 2a65eb121e23243fcb642d28b3f74241536485d8)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10792 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10792/ ) HADOOP-13802 . Make generic options help more consistent, and aligned. (liuml07: rev 2a65eb121e23243fcb642d28b3f74241536485d8) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
          Hide
          liuml07 Mingliang Liu added a comment -

          Committed to trunk and branch-2. Thanks for your contribution, Grant Sohn.

          Show
          liuml07 Mingliang Liu added a comment - Committed to trunk and branch-2 . Thanks for your contribution, Grant Sohn .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 46s trunk passed
          +1 compile 10m 46s trunk passed
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 1m 5s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          +1 findbugs 1m 27s trunk passed
          +1 javadoc 0m 51s trunk passed
          +1 mvninstall 0m 36s the patch passed
          +1 compile 9m 14s the patch passed
          +1 javac 9m 14s the patch passed
          +1 checkstyle 0m 33s hadoop-common-project/hadoop-common: The patch generated 0 new + 30 unchanged - 4 fixed = 30 total (was 34)
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 36s the patch passed
          +1 javadoc 0m 51s the patch passed
          -1 unit 7m 26s hadoop-common in the patch failed.
          +1 asflicense 0m 38s The patch does not generate ASF License warnings.
          46m 33s



          Reason Tests
          Failed junit tests hadoop.net.TestClusterTopology



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13802
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838066/HADOOP-13802.4.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ce58a75a275f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 29e3b34
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11033/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11033/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11033/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 46s trunk passed +1 compile 10m 46s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 21s trunk passed +1 findbugs 1m 27s trunk passed +1 javadoc 0m 51s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 9m 14s the patch passed +1 javac 9m 14s the patch passed +1 checkstyle 0m 33s hadoop-common-project/hadoop-common: The patch generated 0 new + 30 unchanged - 4 fixed = 30 total (was 34) +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 36s the patch passed +1 javadoc 0m 51s the patch passed -1 unit 7m 26s hadoop-common in the patch failed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 46m 33s Reason Tests Failed junit tests hadoop.net.TestClusterTopology Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13802 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838066/HADOOP-13802.4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ce58a75a275f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 29e3b34 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/11033/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11033/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11033/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          The v4 patch fixes the checkstyle warnings. I'll commit this if Jenkins does not complain again. Not tests needed.

          Show
          liuml07 Mingliang Liu added a comment - The v4 patch fixes the checkstyle warnings. I'll commit this if Jenkins does not complain again. Not tests needed.
          Hide
          gsohn Grant Sohn added a comment -

          Code change only reformatting text, does not require a test.

          Show
          gsohn Grant Sohn added a comment - Code change only reformatting text, does not require a test.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 29s trunk passed
          +1 compile 11m 17s trunk passed
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 findbugs 1m 30s trunk passed
          +1 javadoc 0m 52s trunk passed
          +1 mvninstall 0m 36s the patch passed
          +1 compile 10m 5s the patch passed
          +1 javac 10m 5s the patch passed
          -0 checkstyle 0m 34s hadoop-common-project/hadoop-common: The patch generated 6 new + 30 unchanged - 4 fixed = 36 total (was 34)
          +1 mvnsite 1m 13s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 53s the patch passed
          +1 javadoc 0m 53s the patch passed
          +1 unit 8m 53s hadoop-common in the patch passed.
          +1 asflicense 0m 42s The patch does not generate ASF License warnings.
          50m 42s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13802
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838035/HADOOP-13802.3.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 455dd2b763c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dbb133c
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11027/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11027/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11027/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 29s trunk passed +1 compile 11m 17s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 1m 30s trunk passed +1 javadoc 0m 52s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 10m 5s the patch passed +1 javac 10m 5s the patch passed -0 checkstyle 0m 34s hadoop-common-project/hadoop-common: The patch generated 6 new + 30 unchanged - 4 fixed = 36 total (was 34) +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 8m 53s hadoop-common in the patch passed. +1 asflicense 0m 42s The patch does not generate ASF License warnings. 50m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13802 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12838035/HADOOP-13802.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 455dd2b763c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbb133c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11027/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11027/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11027/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          gsohn Grant Sohn added a comment -

          Fixed.

          Show
          gsohn Grant Sohn added a comment - Fixed.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Agreed.

          Show
          ajisakaa Akira Ajisaka added a comment - Agreed.
          Hide
          gsohn Grant Sohn added a comment -

          Would it okay, I replace the '\n' with println() instead? This implicitly uses line.separator.

          Show
          gsohn Grant Sohn added a comment - Would it okay, I replace the '\n' with println() instead? This implicitly uses line.separator.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Mostly looks good to me.
          Would you replace \n with System.getProperty("line.separator") to support Windows environment?

          Show
          ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. Would you replace \n with System.getProperty("line.separator") to support Windows environment?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 7s trunk passed
          +1 compile 12m 5s trunk passed
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 1m 15s trunk passed
          +1 mvneclipse 0m 22s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 0m 52s trunk passed
          +1 mvninstall 0m 39s the patch passed
          +1 compile 10m 31s the patch passed
          +1 javac 10m 31s the patch passed
          -0 checkstyle 0m 31s hadoop-common-project/hadoop-common: The patch generated 6 new + 30 unchanged - 4 fixed = 36 total (was 34)
          +1 mvnsite 1m 15s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 55s the patch passed
          +1 javadoc 0m 55s the patch passed
          +1 unit 9m 3s hadoop-common in the patch passed.
          +1 asflicense 0m 40s The patch does not generate ASF License warnings.
          53m 14s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13802
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837836/HADOOP-13802.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b7e633c0909b 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / de3b4aa
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11012/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11012/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11012/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 7s trunk passed +1 compile 12m 5s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 15s trunk passed +1 mvneclipse 0m 22s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 52s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 10m 31s the patch passed +1 javac 10m 31s the patch passed -0 checkstyle 0m 31s hadoop-common-project/hadoop-common: The patch generated 6 new + 30 unchanged - 4 fixed = 36 total (was 34) +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 55s the patch passed +1 javadoc 0m 55s the patch passed +1 unit 9m 3s hadoop-common in the patch passed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 53m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13802 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837836/HADOOP-13802.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b7e633c0909b 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / de3b4aa Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11012/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11012/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11012/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 14s trunk passed
          +1 compile 12m 49s trunk passed
          +1 checkstyle 0m 34s trunk passed
          +1 mvnsite 1m 12s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 52s trunk passed
          +1 mvninstall 0m 39s the patch passed
          +1 compile 9m 40s the patch passed
          +1 javac 9m 40s the patch passed
          -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 6 new + 30 unchanged - 4 fixed = 36 total (was 34)
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 39s the patch passed
          +1 javadoc 0m 57s the patch passed
          +1 unit 9m 15s hadoop-common in the patch passed.
          +1 asflicense 0m 41s The patch does not generate ASF License warnings.
          51m 59s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e809691
          JIRA Issue HADOOP-13802
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837827/HADOOP-13802.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4c89f01f1505 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / de3b4aa
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11011/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11011/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11011/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 14s trunk passed +1 compile 12m 49s trunk passed +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 12s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 52s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 9m 40s the patch passed +1 javac 9m 40s the patch passed -0 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 6 new + 30 unchanged - 4 fixed = 36 total (was 34) +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 39s the patch passed +1 javadoc 0m 57s the patch passed +1 unit 9m 15s hadoop-common in the patch passed. +1 asflicense 0m 41s The patch does not generate ASF License warnings. 51m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Issue HADOOP-13802 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837827/HADOOP-13802.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4c89f01f1505 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / de3b4aa Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11011/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11011/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11011/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          gsohn Grant Sohn added a comment -

          Removed bin/hadoop as that no longer appears in trunk.

          Show
          gsohn Grant Sohn added a comment - Removed bin/hadoop as that no longer appears in trunk.
          Hide
          liuml07 Mingliang Liu added a comment -
              out.println("bin/hadoop command [genericOptions] [commandOptions]\n");
          

          we can simply replace bin/hadoop with hadoop. The PATH may be set, and the working directory may not be the $HADOOP_HOME.

          +1 other than that (pending on Jenkins).

          Ping Akira Ajisaka for 2nd opinion.

          Show
          liuml07 Mingliang Liu added a comment - out.println( "bin/hadoop command [genericOptions] [commandOptions]\n" ); we can simply replace bin/hadoop with hadoop. The PATH may be set, and the working directory may not be the $HADOOP_HOME. +1 other than that (pending on Jenkins). Ping Akira Ajisaka for 2nd opinion.
          Hide
          gsohn Grant Sohn added a comment -

          Patch is against trunk.

          Show
          gsohn Grant Sohn added a comment - Patch is against trunk.
          Hide
          gsohn Grant Sohn added a comment -

          I'll try to add one shortly.

          Show
          gsohn Grant Sohn added a comment - I'll try to add one shortly.
          Hide
          liuml07 Mingliang Liu added a comment -

          Do you mind providing a patch? I can review/commit this after that. If I'm asking too much, I'll assign this to someone else.

          Show
          liuml07 Mingliang Liu added a comment - Do you mind providing a patch? I can review/commit this after that. If I'm asking too much, I'll assign this to someone else.
          Hide
          liuml07 Mingliang Liu added a comment -

          My only nit on this is adding the ":" at the end of "The general command line syntax is:".

          ...and the option/description is aligned?

          Show
          liuml07 Mingliang Liu added a comment - My only nit on this is adding the ":" at the end of "The general command line syntax is:". ...and the option/description is aligned?
          Hide
          gsohn Grant Sohn added a comment -

          That was a mistake on my part. Here is the corrected version.

          Generic options supported are:
          -conf <configuration file>     specify an application configuration file
          -D <property=value>            define a value for given property
          -fs <local|namenode:port>      specify a namenode
          -jt <local|jobtracker:port>    specify a job tracker
          -files <file1,...>             specify a comma-separated list of files to be copied to the map reduce cluster
          -libjars <jar1,...>            specify a comma-separated list of jar files to be included in the classpath
          -archives <archive1,...>       specify a comma-separated list of archives to be unarchived on the compute machines
          
          The general command line syntax is:
          bin/hadoop command [genericOptions] [commandOptions]
          

          My only nit on this is adding the ":" at the end of "The general command line syntax is:".

          Show
          gsohn Grant Sohn added a comment - That was a mistake on my part. Here is the corrected version. Generic options supported are: -conf <configuration file> specify an application configuration file -D <property=value> define a value for given property -fs <local|namenode:port> specify a namenode -jt <local|jobtracker:port> specify a job tracker -files <file1,...> specify a comma-separated list of files to be copied to the map reduce cluster -libjars <jar1,...> specify a comma-separated list of jar files to be included in the classpath -archives <archive1,...> specify a comma-separated list of archives to be unarchived on the compute machines The general command line syntax is: bin/hadoop command [genericOptions] [commandOptions] My only nit on this is adding the ":" at the end of "The general command line syntax is:".
          Hide
          liuml07 Mingliang Liu added a comment -

          The format looks pretty good.

          Are we removing

           The general command line syntax is bin/hadoop command [genericOptions] [commandOptions]
          

          which I don't quite support. We have to tell the user that genericOptions comes before commandOptions, don't we?

          Show
          liuml07 Mingliang Liu added a comment - The format looks pretty good. Are we removing The general command line syntax is bin/hadoop command [genericOptions] [commandOptions] which I don't quite support. We have to tell the user that genericOptions comes before commandOptions, don't we?

            People

            • Assignee:
              gsohn Grant Sohn
              Reporter:
              gsohn Grant Sohn
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development